[GUI Plugin] Library Codes

[DaltonST]

Favourites plugin issue, not LCs. I suspect that using it like you do was never explicitly supported many years ago when Favourites was created.

[ownedbycats]

I don't follow. I use it for menu items that don't fit on my toolbar and sub-menu items that I want convenient access to, which...is exactly what's mentioned in the original post.

[DaltonST]

You are adding LC in 2 places, as I said before.

[ownedbycats]

I also have Job Spy and some of Job Spy's submenu items. They work. Kobo Utilities and Customize KoboTouchExtended too. It's only Library Codes that fails, and even if I only add a submenu item.

[DaltonST]

Favourites plugin design issue, not mine. I am finished with this topic.

[JimmXinu]

Originally Posted by DaltonST

Favourites plugin issue, not LCs.

I just installed LC, briefly tested, and looked in the code. At the bottom of LC's version of common_utils.py, create_menu_action_unique() does this:

    # For use by the Favourites Menu plugin. If this menu action has text
    # that is not constant through the life of this plugin, then we need
    # to attribute it with something that will be constant that the
    # Favourites Menu plugin can use to identify it.
    favourites_menu_unique_name = 'Library Codes'
    if favourites_menu_unique_name:
        ac.favourites_menu_unique_name = favourites_menu_unique_name

Which explains why *all* LC menu options are named 'Library Codes'. Is that the intention? If so, why are different names passed in ui.py? I would speculate it was a bit of test code accidentally left in.

I've never delved deeply into how FM works, but it won't surprise me if it gets confused when handed a whole stack of items all with the same 'unique' name.

[DaltonST]

Actually, a unique name is passed by each and every menu action, but one final line of code was deleted somewhere along the line:

if not favourites_menu_unique_name:

favourites_menu_unique_name = 'Library Codes'

That fall-through should never been executed, since a unique name is passed by each and every menu action.

Thanks for the catch.


DaltonST

[JimmXinu]

Originally Posted by DaltonST

That fall-through should never been executed, since a unique name is passed by each and every menu action.

I would suggest that a non-unique default value for favourites_menu_unique_name, even as a fall though, would be contraindicated.

If every action has a favourites_menu_unique_name and the fall through never gets used, it doesn't matter. Until it does. So I don't think I'd keep that fall through at all. favourites_menu_unique_name is not required.

[DaltonST]

Version 1.0.48 - 2020-11-24 Favourites plugin accommodation.


DaltonST

[ownedbycats]

It works now!

[DaltonST]

Version 1.0.49 - 2020-12-15 Miscellaneous technical improvements.


DaltonST

[DaltonST]

Version 1.0.50 - 2020-12-22 Miscellaneous Technical changes.


DaltonST

[sle7en]

I always get this message; "calibre, version 5.9.0
Library Codes: Nothing Updated For Any Books, But There Were No Errors. Visit: http://classify.oclc.org/classify2/" when I'm scanning for LCC/DDC/FAST tags for books with valid ISBN's. Is there any particular reason for that ? I already do have the #lcc #ddc #fast columns present fyi. Any help is welcome! Thank you for the tool @DaltonST !

[Georgie W]

Hi, could you point me at the download link for this plugin for earlier versions of Calibre? I'm running Calibre 4.22 (due to the KFX conversion issue)? many thanks

[ownedbycats]

Here: https://www.mobileread.com/forums/sh...9&postcount=21