Please stop adding extra paragraphs??

[un_pogaz]

So, to get the expected behavior (like that of a W3C compliant browser) you have to add a specific Qt CSS property ?! (or to be exact, kept)
...
Whoah.
Great.
Absolutely obvious.
*sighs*
All right, then. Just in case, could you try <p></p> if it works?
I know currently than Calibre filter and delete empty paragraphs, but if it works, it would be probaly a more elegant solution.

[kovidgoyal]

No, empty paragraph is simply discarded by QTextBrowser. However, with yet another workaround for a Qt bug, <p>&nbsp;</p> does work, so I have changed it to that.

https://github.com/kovidgoyal/calibr...ac2d06b4a01bfa

[un_pogaz]

YES, thanks.
Also work in 4.8 and propably all V4.

EDIT: Arf NOoooo
The HTML view repalce all entities. And worse, replace "unbreakable space" by "normal space"

The HTML <p>&nbsp;</p> becomes <p> </p> (with normal space) and will therefore be deleted the next time it is loaded in HTML mode.

Damnit

[kovidgoyal]

Originally Posted by un_pogaz

The HTML view repalce all entities. And worse, replace "unbreakable space" by "normal space"

You need to include the fix using PlainTextEdit from that patch. That works around the bug with QPlainTextEdit replacing nbsp

[un_pogaz]

The update is arrived and bug report:
When I switch from "HTML code" to "Normal View", this message appears and the changes are not saved.

Spoiler:

calibre, version 4.9.0
ERREUR : Exception non gérée: <b>TypeError</b>:unbound method toPlainText() must be called with PlainTextEdit instance as first argument (got QPlainTextEdit instance instead)

calibre 4.9 Portable embedded-python: True is64bit: False
Windows-7-6.1.7601-SP1 Windows ('32bit', 'WindowsPE')
32bit process running on 64bit windows
('Windows', '7', '6.1.7601')
Python 2.7.16+
Windows: ('7', '6.1.7601', 'SP1', u'Multiprocessor Free')
Interface language: fr
Successfully initialized third party plugins: Modify ePub (1, 4, 0) && KePub Output (3, 1, 3)
Traceback (most recent call last):
File "site-packages\calibre\gui2\comments_editor.py", line 1142, in change_tab
TypeError: unbound method toPlainText() must be called with PlainTextEdit instance as first argument (got QPlainTextEdit instance instead)

[kovidgoyal]

weird I cannot reproduce o my development machine, must be specific to PyQt version, in any case this fixes it: https://github.com/kovidgoyal/calibr...9d7ad1fcabcaeb

[thiago.eec]

Originally Posted by un_pogaz

The update is arrived and bug report:
When I switch from "HTML code" to "Normal View", this message appears and the changes are not saved.

It also happens here (Win 10, x64).

[Rev. Bob]

Originally Posted by kovidgoyal

in any case this fixes it: https://github.com/kovidgoyal/calibr...9d7ad1fcabcaeb

I was just about to report that bug, but this does indeed fix it. (By the by, is there any way to stop this module from spontaneously inserting inline styles?)

Unfortunately, I have another 4.9 bug to report, which is unaffected by that patch. In the standard calibre "library list" view, highlighting multiple ebooks and selecting "Edit metadata individually" (either by typing "e" or using the context menu) brings up the bulk editor instead.

EDIT: Almost forgot, there's another comments-editor bug that's persisted through at least the last few versions. When highlighting a boldface word or phrase from right to left, highlighting the "last" character (the first one in the word) causes the "bold" button to switch to "normal" status and neither clicking it nor pressing control-B has any effect. The selection stays bold, and only by highlighting from left to right can the it be debolded. The same goes for italics and underlined text, and it manifests in both the "review downloaded metadata" and "edit metadata individually" comment environments (which I expect use the same coding, but it's good to be thorough).

[un_pogaz]

4.9.1
Yes.
It's works.
Thanks you so mush Kovid.

[kovidgoyal]

Originally Posted by Rev. Bob

I was just about to report that bug, but this does indeed fix it. (By the by, is there any way to stop this module from spontaneously inserting inline styles?)

no, there isn't.

Unfortunately, I have another 4.9 bug to report, which is unaffected by that patch. In the standard calibre "library list" view, highlighting multiple ebooks and selecting "Edit metadata individually" (either by typing "e" or using the context menu) brings up the bulk editor instead.

Will be fixed in the next release.

EDIT: Almost forgot, there's another comments-editor bug that's persisted through at least the last few versions. When highlighting a boldface word or phrase from right to left, highlighting the "last" character (the first one in the word) causes the "bold" button to switch to "normal" status and neither clicking it nor pressing control-B has any effect. The selection stays bold, and only by highlighting from left to right can the it be debolded. The same goes for italics and underlined text, and it manifests in both the "review downloaded metadata" and "edit metadata individually" comment environments (which I expect use the same coding, but it's good to be thorough).

that's a limitation of QTextEdit, not much I can do about it. formatting style applies left of cursor. When you select from right to left, left of cursor is before the formatting. You can see this in action by simply moving the cursor without doing any selecting.

[Geremia]

I get this issue, too.

Calibre 4.x adds a blank line

<p><br></p>

after each newline of comments added in Calibre 3.x and earlier versions, thereby "double-spacing" newlines. Why is this?

[un_pogaz]

Read the topic

TLDR:
The problem arose with the use of the new QtWebEngine in V4.0.0.
The problem was solved in 4.9.1.

However, I discovered that old comments made before 4.9 still retain the <p><br></p>, but this is normal, Calibre will correct and update the comment only when YOU make a edition.

[BetterRed]

There is no such thing a calibre 4.x. The current release is 4.11.2, if you are not using that version then you should install it.

As discussed in the preceding 20+ posts there were a couple updates in recent releases to address the 'blank lines in comments' issue.

BR

[Geremia]

Originally Posted by BetterRed

The current release is 4.11.2, if you are not using that version then you should install it.

I'm using 4.12.

Originally Posted by BetterRed

As discussed in the preceding 20+ posts there were a couple updates in recent releases to address the 'blank lines in comments' issue.

Perhaps when I had Calibre 3 it put those empty <p> tags. Still, Calibre 4.12 doesn't strip them.

[theducks]

Originally Posted by Geremia

I'm using 4.12.Perhaps when I had Calibre 3 it put those empty <p> tags. Still, Calibre 4.12 doesn't strip them.

Calibre never auto touches EXISTING STUFF. You need to clean existing comments.