kobopatch - A new (WIP) patching system - Page 5

geek1011 · 04-29-2018, 03:18 PM

Quote:

Originally Posted by oren64

Windows 10 64bit.

OK. I'm not sure why it is not working for you. I'll try to figure it out later this week, as I don't have much time today or tomorrow. Thanks for your help testing!

jackie_w · 04-29-2018, 05:09 PM

Quote:

Originally Posted by oren64

Same thing, the WinRar only show two files and the KoboRoot.tgz file have different file size every run.

@geek1011,

My experience with your latest release is the same as Oren's.

geek1011 · 04-29-2018, 07:48 PM

Quote:

Originally Posted by jackie_w

@geek1011,

My experience with your latest release is the same as Oren's.

For me on Linux and macOS, it works perfectly every time. If it comes down to it, I'll have it call an external tar binary to create the tar.

Do all 4 files appear if you extract using 7-zip or the tar command? I have a feeling this is a WinRAR problem.

jackie_w · 04-29-2018, 08:31 PM

Quote:

Originally Posted by geek1011

Do all 4 files appear if you extract using 7-zip or the tar command? I have a feeling this is a WinRAR problem.

I didn't have any problems with the .tgz output from either v5 or v5.1 when using 7-zip.

7-zip is my unzip utility of choice, which is why I didn't initially understand why Oren was having problems on Win10 and I wasn't.

The current Patcher system produces a .tgz output file which WinRar opens without a problem. Probably because Geoff uses 7-zip to create it. I wonder if this is precisely why he did decide to bundle 7-zip with the Patcher.

Sorry, I don't know what a tar command is.

geek1011 · 04-29-2018, 08:41 PM

Quote:

Originally Posted by jackie_w

I didn't have any problems with the .tgz output from either v5 or v5.1 when using 7-zip.

7-zip is my unzip utility of choice, which is why I didn't initially understand why Oren was having problems on Win10 and I wasn't.

The current Patcher system produces a .tgz output file which WinRar opens without a problem. Probably because Geoff uses 7-zip to create it. I wonder if this is precisely why he did decide to bundle 7-zip with the Patcher.

Sorry, I don't know what a tar command is.

Yes, that sounds right. This also means the patches should apply fine to the Kobo (I actually tried it on mine).

The reason why Geoff used 7-zip is because there is no built-in to create tar files on windows.

You can download tar here: http://gnuwin32.sourceforge.net/packages/libarchive.htm

oren64 · 04-30-2018, 12:42 AM

The thing that bothers me is different size file it mean that there is data missing from the files.

In GeoffR bother it first compress the files to .tar and then change it to .tgz, maybe you should do the same thing.

Terisa de morgan · 04-30-2018, 03:31 AM

I've tested it at Windows7 64 bits:

Corrupt file according to Winrar and only two files inside (neither libadobe nor librmsdk were included).
OK file according to 7zip (extraction in two steps) and all the files inside
Tar file ok according to Winrar after extracting the tar from the tgz with 7zip

So, perhaps we can think that the problem is not the tar itself but the tgz (the compression).

Additional info: The initial KoboRoot.tar.gz has a size of 14.614.52 bytes, and after using gunzip and gzip (I have cygwin installed in my computer), the size is 14.311.424 bytes and Winrar doesn't complain about the file.

geek1011 · 04-30-2018, 07:33 AM

Quote:

Originally Posted by Terisa de morgan

I've tested it at Windows7 64 bits:

Corrupt file according to Winrar and only two files inside (neither libadobe nor librmsdk were included).
OK file according to 7zip (extraction in two steps) and all the files inside
Tar file ok according to Winrar after extracting the tar from the tgz with 7zip

So, perhaps we can think that the problem is not the tar itself but the tgz (the compression).

Additional info: The initial KoboRoot.tar.gz has a size of 14.614.52 bytes, and after using gunzip and gzip (I have cygwin installed in my computer), the size is 14.311.424 bytes and Winrar doesn't complain about the file.

Ok, that helps. I guess WinRar might just have a buggy implementation, as all tools on Linux which I know about work fine with it. This also means it should work fine on the Kobo. For peace of mind, I could set the compression level to 0 so it is still a tgz, but the only compression would be the Huffman dict. This should fix any issues WinRAR is having if it is about the compression.

Does WinRAR have any sort of verbose mode or log I can look at?

Edit: can you also try using https://github.com/mholt/archiver to create a tar.gz out of some files and see if it also gives you an issue with WinRAR.

Terisa de morgan · 04-30-2018, 07:39 AM

Quote:

Originally Posted by geek1011

Does WinRAR have any sort of verbose mode or log I can look at?

I think that, if you call if in the command windows, you can get a verbose mode, but I'm not sure-

oren64 · 04-30-2018, 08:07 AM

@geek1011 where the temp files are stored before it generate tgz file?

geek1011 · 04-30-2018, 09:48 AM

Quote:

Originally Posted by oren64

@geek1011 where the temp files are stored before it generate tgz file?

In memory.

JSWolf · 04-30-2018, 06:59 PM

Besides the configuration file so we can enable/disable the patches we want, I would like to be notified of new patches so we can enable/disable and also, notify us of conflicting enables where we cannot enable certain patches with other patches.

geek1011 · 04-30-2018, 07:02 PM

Quote:

Originally Posted by JSWolf

Besides the configuration file so we can enable/disable the patches we want, I would like to be notified of new patches so we can enable/disable and also, notify us of conflicting enables where we cannot enable certain patches with other patches.

I'm not going to implement notifications, as it would add a lot of complexity. As for conflicts, would you want it to be automatically detected (at the cost of speed), or manually set?

geek1011 · 04-30-2018, 07:06 PM

Can someone on windows who is willing and knows how to restore a SD card image test out the patch zip? It seems to work fine in everything except for WinRAR, and it works fine with all the Linux and Mac OS tools so I think it should be safe to try. I know the Linux version works though, as I tried it on both my Kobos.

boriar · 05-01-2018, 04:51 AM

@geek1011
What do you think about that:
For implement my idea from here may be a good way process firstly the user list of patches (an unique file for all patches enables and disables) to write temporary individual files for each archive (nickel, libnickel, etc) to use with your kobopatch. With that way the complexity and delay will be little

04-30-2018, 12:42 AM	#66
oren64 I need a chapter break Posts: 4,042 Karma: 56058267 Join Date: Mar 2015 Location: Israel Device: Kobo Glo	The thing that bothers me is different size file it mean that there is data missing from the files. In GeoffR bother it first compress the files to .tar and then change it to .tgz, maybe you should do the same thing. Last edited by oren64; 04-30-2018 at 06:55 AM.

04-30-2018, 03:31 AM	#67
Terisa de morgan Grand Sorcerer Posts: 6,686 Karma: 12595249 Join Date: Jun 2009 Location: Madrid, Spain Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2	I've tested it at Windows7 64 bits: Corrupt file according to Winrar and only two files inside (neither libadobe nor librmsdk were included). OK file according to 7zip (extraction in two steps) and all the files inside Tar file ok according to Winrar after extracting the tar from the tgz with 7zip So, perhaps we can think that the problem is not the tar itself but the tgz (the compression). Additional info: The initial KoboRoot.tar.gz has a size of 14.614.52 bytes, and after using gunzip and gzip (I have cygwin installed in my computer), the size is 14.311.424 bytes and Winrar doesn't complain about the file. Last edited by Terisa de morgan; 04-30-2018 at 03:43 AM.

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Glo [WIP] Port of Kindle Paperwhite OS	giorgio130	Kobo Developer's Corner	59	04-26-2016 08:25 AM
Android [WIP] Overclocking the PE	plasticarmyman	enTourage eDGe	16	06-11-2012 07:08 PM
Seriously thoughtful I always knew Windows was a WIP	GeoffC	Lounge	4	02-06-2010 02:20 AM
Thirty - WIP - comments wanted	ravenlife	Writers' Corner	20	08-16-2009 12:10 PM
Opinions needed on a WIP ebook	Nate the great	Workshop	5	07-15-2009 11:38 AM

04-30-2018, 08:07 AM	#70
oren64 I need a chapter break Posts: 4,042 Karma: 56058267 Join Date: Mar 2015 Location: Israel Device: Kobo Glo	@geek1011 where the temp files are stored before it generate tgz file?

04-30-2018, 06:59 PM	#72
JSWolf Resident Curmudgeon Posts: 80,742 Karma: 150249619 Join Date: Nov 2006 Location: Roslindale, Massachusetts Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3	Besides the configuration file so we can enable/disable the patches we want, I would like to be notified of new patches so we can enable/disable and also, notify us of conflicting enables where we cannot enable certain patches with other patches.

04-30-2018, 07:06 PM	#74
geek1011 Wizard Posts: 2,808 Karma: 7423683 Join Date: May 2016 Location: Ontario, Canada Device: Kobo Mini, Aura Edition 2 v1, Clara HD, Clara BW, Libra Colour	Can someone on windows who is willing and knows how to restore a SD card image test out the patch zip? It seems to work fine in everything except for WinRAR, and it works fine with all the Linux and Mac OS tools so I think it should be safe to try. I know the Linux version works though, as I tried it on both my Kobos.

05-01-2018, 04:51 AM	#75
boriar Evangelist Posts: 407 Karma: 314204 Join Date: Jan 2015 Device: bq Avant XL, Kobo Aura H2O, Onyx Boox M96C Plus	@geek1011 What do you think about that: For implement my idea from here may be a good way process firstly the user list of patches (an unique file for all patches enables and disables) to write temporary individual files for each archive (nickel, libnickel, etc) to use with your kobopatch. With that way the complexity and delay will be little