[0.9.2] Code prettification issues

[Bosparan]

Hi guys,

I'm having an issue with the prettify functionality since installing 0.9.2:
The "Format code on Save" option is broken. I can safe all day without results. Always have to do it manually (Tools > Format...).

A separate issue if you will (though probably no bug per se), is how <br/> tags are formatted. I've been using an ancient release (don't remember the exact version, several years out of date) until fairly recently, when I upgraded to 0.9.1 and now to 0.9.2.
Previously, it would display a paragraph with <br /> Tags inside on multiple lines (by breaking line behind the <br /> Tag).
With 0.9.1 it added an additional lines, making it hard to distinguish from regular paragraphs.
With 0.9.2 no linebreaks are added, making it harder to read.

If possible I'd appreciate having it back to the original behavior (or to have an option for it if this change was intentional).
Example results after prettifying in codeview:

Ancient Version (and how I prefer it):
<p>This<br />
is<br />
an<br />
Example</p>

Version 0.9.1
<p>This<br />

is<br />

an<br />

Example</p>

Version 0.9.2
<p>This<br />is<br />an<br />Example</p>

Cheers,
Bosparan

[DiapDealer]

Originally Posted by Bosparan

Hi guys,

I'm having an issue with the prettify functionality since installing 0.9.2:
The "Format code on Save" option is broken. I can safe all day without results. Always have to do it manually (Tools > Format...).

It's not broken. There IS no "Pretty Print/Prettify/Beautify on Save" any more. That's why the checkbox is no longer available in the Clean Source settings. This change was in the 0.9.2 release announcement. The only current Open/Save formatting option is whether or not your code gets automatically "mended" (a minimally invasive repair--which will rarely, if ever, alter well-formed code). All Prettifying (which is invasive and can potentially affect rendering) is done manually at the user's request through the Tools menu, the Code View context menu, or an assigned keyboard shortcut.

Originally Posted by Bosparan

A separate issue if you will (though probably no bug per se), is how <br/> tags are formatted. I've been using an ancient release (don't remember the exact version, several years out of date) until fairly recently, when I upgraded to 0.9.1 and now to 0.9.2.
Previously, it would display a paragraph with <br /> Tags inside on multiple lines (by breaking line behind the <br /> Tag).
With 0.9.1 it added an additional lines, making it hard to distinguish from regular paragraphs.
With 0.9.2 no linebreaks are added, making it harder to read.

If possible I'd appreciate having it back to the original behavior (or to have an option for it if this change was intentional).
Example results after prettifying in codeview:

Ancient Version (and how I prefer it):
<p>This<br />
is<br />
an<br />
Example</p>

Version 0.9.1
<p>This<br />

is<br />

an<br />

Example</p>

Version 0.9.2
<p>This<br />is<br />an<br />Example</p>

Cheers,
Bosparan

We'll take it under advisement. Extra lines are still added after br tags in divs and blockquotes and the like, but for the purpose of Prettifying, p tags are currently being treated as "inline" WRT br tags.

[Bosparan]

Hi DiapDealer,

thanks for the near instant answer!

Regarding the format on save:
Too bad that's gone for good. Ah well, even old habits will have to change sometimes. Thanks for the advice about the keyboard shortcuts - didn't find it there when I first looked, revisited the menu after your post and found it now. Memorizing another keybind isn't too much of a trouble, so that issue is well settled.

As for the styling of <br /> Tags in paragraphs ... well, that's more inconvenient, since much of the <br /> use I encounter is in paragraphs.
If that's the way it will be ... well little choice but to live with it (I'm sure you had good reasons for the change on how paragraphs are treated).

Cheers and thanks for all the effort spent on this awesome tool,
Bosparan

Ps.: For reference: I'm using Sigil almost exclusively to edit existing ebooks, creating a uniform formatting design in the books I read. This means I'm mostly doing bulk edits on formattings of all kind.
Don't know whether that's a typical use-case for the program, but it's the point of view I'm experiencing it from.

[Notjohn]

You might be happier with 0.8.6, which you can get at https://github.com/Sigil-Ebook/Sigil/releases/tag/0.8.6

I'm using 0.8.7, but it's said to have some bugs.