[GUI Plugin] FanFicFare

[FandomWitch]

So it might break later, but I've tested using FFF 4.19.0 and FFD 0.9.5. The method on the wiki seems to work with those versions. I got a clean download. Don't know for how much longer it will work due to adapters and stuff but at this moment it appears to be a solution.

[JimmXinu]

FYI, I've removed the FanFictionDownloader FanFicFare Batch wiki page.

[JimmXinu]

New Version Released

Version 4.25.0 - 2023-07-03
- Fix for make_firstimage_cover causing embedded image to also use cover.jpg.
- adapter_wuxiaworldxyz: Paginated TOC
- Add use_workskin option for AO3 (& squidgeworld). PR#967, thanks niacdoial
- Make Rejects List Note column orderable.
- fix_relative_text_links fix for #anchors doesn't handle '.' in id. Fixes #966 refer #952
- AO3 Check for hidden work after login.
- adapter_storiesonlinenet: Login now has a hidden token. - #962 Thanks, mvlcek
- Allow for href='' in fix_relative_text_links processing.

[applegaa]

I've noticed on Literotica that while stories that have "Ch. 1" or "Pt. 1" have that completely removed when a second chapter/part is added, if they don't include the period then the "Ch" or "Pt" is left as part of the title and only the number is removed. (I can private message if you want specific examples.)

How hard/troublesome would it be for you to change the code to also remove the instances without periods?

- Andrew

[JimmXinu]

In general, nothing about that site is easy. But I'll look into it. Yes, please PM me some examples.

[JimmXinu]

New Test Version Posted

2023-07-04
- Fix for ficbook.net date change. Closes #973

[applegaa]

Originally Posted by JimmXinu

In general, nothing about that site is easy. But I'll look into it. Yes, please PM me some examples.

Actually, when I went to find some examples for you, the first couple I found actually do have a period. So, I'm not sure why the "Ch" and "Pt" are being left in the title.

I'll send you the links.

- Andrew

[JimmXinu]

First, you have to have clean_chapter_titles:true set. (I assume you do, but I didn't know that at first.)

That code operates by looking at the story title (what literotica calls 'series'), removing that from chapter title, then looking for 'Ch.' or 'Pt.' at the beginning of the chapter title.

Those particular stories include 'Ch' or 'Pt' as part of the story title.

The ch/pt is removed as part of the story title, not there to be found when the next code looks for it and therefore not replaced.

So, here are some possible solutions from most to least 'invasive':

1. Add code to specifically remove trailing 'Pt' or 'Ch' from story titles in adapter_literotica. That will change the story title for existing stories with this problem.
   
2. The above, but only when clean_chapter_titles:true is set.
   
3. Add code to ignore trailing 'Pt' or 'Ch' in story titles only while running clean_chapter_titles:true, but keep it in the official title metadata. Can still be addressed by user with replace_metadata.
   
4. Declare this to be author error and leave it up to the user to pursue options using replace_metadata on title and strip_chapter_numbers if they want to fix it.

I'm most inclined towards options 3 & 4.

How frequently is this issue?

[applegaa]

Originally Posted by JimmXinu

First, you have to have clean_chapter_titles:true set. (I assume you do, but I didn't know that at first.)

That code operates by looking at the story title (what literotica calls 'series'), removing that from chapter title, then looking for 'Ch.' or 'Pt.' at the beginning of the chapter title.

Those particular stories include 'Ch' or 'Pt' as part of the story title.

The ch/pt is removed as part of the story title, not there to be found when the next code looks for it and therefore not replaced.

So, here are some possible solutions from most to least 'invasive':

1. Add code to specifically remove trailing 'Pt' or 'Ch' from story titles in adapter_literotica. That will change the story title for existing stories with this problem.
   
2. The above, but only when clean_chapter_titles:true is set.
   
3. Add code to ignore trailing 'Pt' or 'Ch' in story titles only while running clean_chapter_titles:true, but keep it in the official title metadata. Can still be addressed by user with replace_metadata.
   
4. Declare this to be author error and leave it up to the user to pursue options using replace_metadata on title and strip_chapter_numbers if they want to fix it.

I'm most inclined towards options 3 & 4.

How frequently is this issue?

I'm not sure. Most of the time it works and removes those bits. I've manually cleaned up a lot of the ones that failed, so I don't have good data at the moment on how many fail.

I'll start paying closer attention to which ones work and which ones don't and see what I can figure out about what differs between them.

- Andrew

[ownedbycats]

If you use [storyUrl] sections, watch for duplicated ones. I found adding ## Author - Title comments helps prevent those.

[ownedbycats]

I just got this error upon updating a fanfic with a data folder. The metadata updated, but the ePub wasn't.

Traceback (most recent call last):
  File "calibre_plugins.fanficfare_plugin.fff_plugin", line 1798, in update_books_loop
  File "calibre_plugins.fanficfare_plugin.fff_plugin", line 2268, in update_metadata
  File "calibre\db\legacy.py", line 588, in set_metadata
  File "calibre\db\cache.py", line 85, in call_func_with_lock
  File "calibre\db\cache.py", line 1691, in set_metadata
  File "calibre\db\cache.py", line 1686, in set_field
  File "calibre\db\cache.py", line 1481, in set_field
  File "calibre\db\backend.py", line 1726, in windows_check_if_files_in_use
  File "calibre\utils\copy_files.py", line 249, in windows_check_if_files_in_use
  File "calibre\utils\copy_files.py", line 231, in register_folder_recursively
  File "os.py", line 225, in makedirs
PermissionError: [WinError 5] Access is denied: 'C:\\WINDOWS\\system32\\data'

After removing the data folder it updates properly as expected.

Additional info if needed for replication:

The data folder contains an image (the cover art) inside. I don't have a cover path set for the story in personal.ini.

Neither the ePub nor book folder was open anywhere and there were no open locks when I checked with an unlocker tool. However, I did use Everything to search for and open the ePub yesterday or today.

I use a custom temporary folder, set with the env var. This is set to D:\Temporary\Calibre\temp\. The ePub was downloaded to there, just copying it to the library folder failed.

The system32 path is confusing. I don't think there is a data folder in there.

[JimmXinu]

Originally Posted by ownedbycats

I just got this error upon updating a fanfic with a data folder. The metadata updated, but the ePub wasn't.

An error at that location should have the opposite effect you describe--updated epub but not metadata. Unless Calibre didn't roll back the update, in which case, you might still see metadata update.

That's Calibre code and the 'data' dir is a Calibre feature. Kovid has decided Calibre needs to be a lot more assertive about windows file locking. I don't know enough about it to say whether he's correct or not.

After the third time I bumped into the problem I reported I went back to Calibre v6.19.1. I was seeing it happen with file explorer 'Quick access', not just searches.

I haven't done anything with data directories, but judging by the system32 directory, I would suspect it's something somewhere looking for a relative 'data' without a full path.

[ownedbycats]

I posted my issue in the thread -- is very baffling. For now, I can either move the data folder out or copy the file in from the temp folder see below post . Or just put the cover art somewhere else, sigh.

[ownedbycats]

Also, oops I read the dialog backwards -- it said this:

calibre, version 6.22.0
ERROR: Error Updating Metadata: <p>An error has occurred while FanFicFare was updating calibre's metadata for <a href='...'>[removed for not family-friendly]</a>.</p>The ebook has been updated, but the metadata has not.

[JimmXinu]

2023-07-08
- adapter_literotica: 'Fix' clean_chapter_titles for titles ending with Pt or Ch

I've elected to address applegaa's issue with option 3. I also added a Fixing Literotica Titles ending in Ch or Pt section to the MetadataManagement wiki page.

Originally Posted by JimmXinu

...

1. Add code to specifically remove trailing 'Pt' or 'Ch' from story titles in adapter_literotica. That will change the story title for existing stories with this problem.
   
2. The above, but only when clean_chapter_titles:true is set.
   
3. Add code to ignore trailing 'Pt' or 'Ch' in story titles only while running clean_chapter_titles:true, but keep it in the official title metadata. Can still be addressed by user with replace_metadata.
   
4. Declare this to be author error and leave it up to the user to pursue options using replace_metadata on title and strip_chapter_numbers if they want to fix it.