Koreader running on Kobos (all of them, hopefully!)

[giorgio130]

Originally Posted by jlynton

In the two latest builds, 583 & 589, the font size setting appear to have changed. I previously used the 3rd option from the left, and that was perfect, but now that setting give too large a size for my taste, while the 2nd is too small.
Would it be possible to change it so the font size can be chosen by numerical value? And ideally the margin size too.
Add a battery icon, and everything would be perfect!
Many thanks.

What is your model? There has been a fix for font size scaling with dpi, so the third option as an example should be the same size on a mini, glo or aurahd. There was also a fine-tune control in older builds, but that seems to have been removed. I'll have a look.

[jlynton]

Originally Posted by giorgio130

What is your model? There has been a fix for font size scaling with dpi, so the third option as an example should be the same size on a mini, glo or aurahd. There was also a fine-tune control in older builds, but that seems to have been removed. I'll have a look.

Thanks Giorgio, mine is a glo. When I open a book, it is on the 3rd size, which is much too big, so I change it to the 2nd which is too small, then I change it back to 3rd, which this time is the right size.

[giorgio130]

Originally Posted by jlynton

Thanks Giorgio, mine is a glo. When I open a book, it is on the 3rd size, which is much too big, so I change it to the 2nd which is too small, then I change it back to 3rd, which this time is the right size.

I see, I didn't get what was the behaviour! definitely a bug. The best way to see those fixed is to report them on github, otherwise I think I am the only developer seeing them... I'll have a look nonetheless!

[jlynton]

Thanks, should I report this on github?

[Ken Maltby]

Originally Posted by jlynton

Thanks Giorgio, mine is a glo. When I open a book, it is on the 3rd size, which is much too big, so I change it to the 2nd which is too small, then I change it back to 3rd, which this time is the right size.

I remember having to do something similar, with the sizes, to get a change in font to complete correctly. Once things were right they remained that way, for that book at least. Odd, but I can live with it.

Luck;
Ken

[jlynton]

Originally Posted by Ken Maltby

I remember having to do something similar, with the sizes, to get a change in font to complete correctly. Once things were right they remained that way, for that book at least. Odd, but I can live with it.

Luck;
Ken

Like Ken's, mine remain that way until I either finish the book, or exit koreader and restart it.

[Markismus]

So, did it seem to anyone else, that build 602 is snappier? Or is it just wishful thinking due to al that talk on github about no more global variables?

[hawhill]

I think the changes are only there from rev 613 onwards. What they make faster are mainly UI components, i.e. not rendering of documents. Might not even be perceptible, though. Although the change was a large one in terms of source code lines changed, it is just a small refactoring of the code (and a paradigm shift). Not so relevant from an end user's perspective, I guess.

[Markismus]

Ah, that would explain the global variable=nil errors I started getting with build 613.

[hawhill]

Errm, right :-/ Thank you for all the debugging help in Github!

[jlynton]

Originally Posted by giorgio130

I see, I didn't get what was the behaviour! definitely a bug. The best way to see those fixed is to report them on github, otherwise I think I am the only developer seeing them... I'll have a look nonetheless!

I just tried build 623 on my glo, and this time any attempt to change the font size resulted in the frontlight flashing off, then on again, at which point the glo restarted. The same thing happened 3 times consecutively.

[Ken Maltby]

Build 623? Where did you get it?

Luck;
Ken

[Markismus]

Originally Posted by jlynton

I just tried build 623 on my glo, and this time any attempt to change the font size resulted in the frontlight flashing off, then on again, at which point the glo restarted. The same thing happened 3 times consecutively.

They fixed it here.

[giorgio130]

Originally Posted by jlynton

I just tried build 623 on my glo, and this time any attempt to change the font size resulted in the frontlight flashing off, then on again, at which point the glo restarted. The same thing happened 3 times consecutively.

Markismus reported it on github and it got fixed within 30 minutes I guess you started building koreader yourself?

whoops, posted together with M

[Markismus]

Originally Posted by giorgio130

I guess you started building koreader yourself?

No. Just trying to debug that OCR-lookup problem. No idea why it doesn't work. deBugging the hell out of me.