CoolReader3 Fork

[LucyOne]

That was fast! Awesome!

[brucelee]

Originally Posted by LucyOne

That was fast! Awesome!

This is why it was fast:

PHP Code:

// Shitty bug fix (some black line shows up at the right of the icons)
int shittyWidth = round(icon_width*0.04);
FillArea(position+icon_width-shittyWidth, 0, shittyWidth, icon_height, 0x00FFFFFF); 


I just draw a white patch over 4% of the icon width. I still don't know what causes the black lines to show up. As the code says... Shitty bug fix. But it works.

[trewelu]

Can anyone with touch hd confirm that the folder/level expand/collapse in TOC is too small? On Inkpad it is hard to collapse/expand the folder/level

[brucelee]

Known issue since PB626 TL2.
The TOC is a system app which is launched from CR3. To fix that I'd have to make CR3 extract the theme from system, change stuff around, pack it up, and then apply the new theme (the manually generated one breaks the WiFi button in FW5.14).
Or the second option would be to write a new TOC window from scratch. And that would take some time... I don't think I'll do that.

[LucyOne]

Does that mean you won't be able to fix the TOC symbols that can only be operated with a touch pen?

[brucelee]

I'll try the theme thing. Writing a new TOC window would take too much time.

[trewelu]

I would be fine with all expanded by default if theming also difficult. Creating TOC from scratch will be a huge effort.

[brucelee]

Originally Posted by trewelu

I would be fine with all expanded by default if theming also difficult. Creating TOC from scratch will be a huge effort.

I can't do anything about that. I just call a system method and have no control over that stuff.

PHP Code:

void OpenContents(tocentry *toc, int count, long long position, iv_tochandler hproc); 


[brucelee]

Actually I remembered I made an attempt at rewriting the TOC once. Completely forgot about it. Here's a build using that one. It's in an alpha stage but it's usable. Definitely better than nothing for you.

It has all the TOC entries thrown in a window. It doesn't even automatically select the current chapter.

[LucyOne]

Originally Posted by brucelee

Actually I remembered I made an attempt at rewriting the TOC once. Completely forgot about it. Here's a build using that one. It's in an alpha stage but it's usable. Definitely better than nothing for you.

It has all the TOC entries thrown in a window. It doesn't even automatically select the current chapter.

Thanks, it works well. If you could do some finetuning like more entries on one page and differentiating between chapters and subchapters, that would be the cherry on top.

[brucelee]

v0.0.6-17-58

- Rewritten TOC window (for touch devices with FW5 skin)
- More lines in menus (fw5 skins)

Edit:
I'd like to see a screenshot of the TOC from Touch HD or InkPad 2. Just out of curiosity as I expect it to look fine. Thanks

[Marshal Kilgore]

Looks really fine, but the font doesn't scale. >;-)

May I suggest boldface to mark the current chapter (instead of the chevron.)

Touch HD

[trewelu]

Here. Is it possible to make inkpad's page next/prev button to work in TOC as well later? The new TOC looks good. I am seconding tthe idea of bolding the current chapter/subchapter instead of chevron

ps: Inkpad and Inkpad2 has the same screen resolution. You can drop the "2" from release note mentioning inkpad 2

[brucelee]

No bolding yet. The chevron is not a feature. It's there because I didn't figure how to set the default selection when opening the TOC window. Strange enough, the setPage method does what it's supposed to but the setItem doesn't.
Physical buttons are not a priority but I'll consider it.

[Marshal Kilgore]

Checked it: on the Touch HD, prev/next buttons work in the new TOC, so this is a device specific issue.