CoolReader3 Fork

[Zetmolm]

The 'Added front light to tap actions' feature is an extremely valuable addition. It is not an on/off toggle. It does not have the same function as the long press on the hardware Menu key, which only switches the light on or off, without displaying the slide bar (at least in my 4.4 firmware).

Brucelee's tap action displays the slide bar, which allows you to modify the light strength. This is indeed a feature that was missing.

And I'm going to use it a lot (reading in different places with different light conditions)!

[brucelee]

Originally Posted by j0r13n

...
it would be awesome when you can extend the top menu bar to a 'normal' level so you can use it without finger picking exercises,
...

If you mean to show and expand the system panel with one touch (fw5)... I doubt I'll be able to push events to it, but I'll try.
Collapsing and hiding it would still require two touches because the app can't receive events while the system panel is expanded.
If that's not the case, please rephrase.

Originally Posted by j0r13n

...
and it would also be a 'big' leap forward if you can fix the buffering in the menu's: more than once unsuspected settings are applied when selecting a menu item.
...

I know about that. It's annoying but I don't feel like it being a priority (especially since I'm still not used to the coolreader backend).

Originally Posted by j0r13n

...
the dictionary is functioning different as I'm used to: when selecting a word which doesn't result in a direct hit, normally I'm choosing an item which comes as close as it gets and thereafter this item can be used as it was a direct hit...
...

I didn't know that happened. It probably got screwed when I added Google and Wikipedia.

0.0.6-16-8: (Only Pro updates)
- Book cover is set as power off logo in FW5 but it has poor quality for the moment
- If there is no book cover CR generates an ugly one for you

[Zetmolm]

Originally Posted by brucelee

If you mean to show and expand the system panel with one touch (fw5)... I doubt I'll be able to push events to it, but I'll try.
Collapsing and hiding it would still require two touches because the app can't receive events while the system panel is expanded.
If that's not the case, please rephrase.

I think what is meant (but correct me if I'm wrong, j0r13n) is that the 'buttons' in the top menu bar are too small, and it takes quite some effort to tap them. At least that is my problem. In particular the arrow left and arrow right to page back and forth are difficult to hit. So the question is: could you increase the height of the top menu bar and make the 'buttons' a bit bigger?

Thanks again for the good work. This version of CR works very well on my new PB626.

[brucelee]

That is one of the things I want to change. It's an issue for all the devices having resolution greater than 600x800. It's awfully difficult to hit the left/right arrows.

[j0r13n]

Originally Posted by Zetmolm

I think what is meant (but correct me if I'm wrong, j0r13n) is that the 'buttons' in the top menu bar are too small, and it takes quite some effort to tap them. At least that is my problem. In particular the arrow left and arrow right to page back and forth are difficult to hit. So the question is: could you increase the height of the top menu bar and make the 'buttons' a bit bigger?

Thanks again for the good work. This version of CR works very well on my new PB626.

That's exactly what I mean!

The difficulty lies in the fact that not only the graphic design must be altered but also the corresponding tap areas...

[sadowski]

From my wishlist: For note-taking (without touch, i.e., with the 4-way button), allow selections down to words. Currently, the smallest unit that can be selected is whole sentences.

[sadowski]

Now I see: the 4-way button on the PB Mini does not work at all in both note and dictionary mode.

[brucelee]

Originally Posted by sadowski

Now I see: the 4-way button on the PB Mini does not work at all in both note and dictionary mode.

Maybe the keys are not mapped correctly.

Try downloading the corresponding package from here and replace your keymaps (system/share/cr3/keymaps).

It should work fine as I didn't change anything there.

[sadowski]

Originally Posted by brucelee

Maybe the keys are not mapped correctly.

Try downloading the corresponding package from here and replace your keymaps (system/share/cr3/keymaps).

It should work fine as I didn't change anything there.

I tried this, with the same result. More specifically:

- all buttons work fine when reading.

- in "notes" mode, left and right do not work at all and forward/backward are swapped. Up/down/OK, OKlong still work. Forward/backward are not part of the 4-way button.

- in "dictionary" mode, all 4 (up, down, left, right) do no work. "OK" still works.

Could this be since the PB mini is on FW 4?

Jens

[brucelee]

I doubt it's firmware related. If the key codes would change you shouldn't be able to use the buttons anywhere in the app.
It's either some wrong key configuration in keymaps.ini in the [cite] and [dict] sections, or some change in the app commands that broke things.

Do you know/have a coolreader package that has notes&dictionary working fine for you?

[sadowski]

Originally Posted by brucelee

I doubt it's firmware related. If the key codes would change you shouldn't be able to use the buttons anywhere in the app.
It's either some wrong key configuration in keymaps.ini in the [cite] and [dict] sections, or some change in the app commands that broke things.

Do you know/have a coolreader package that has notes&dictionary working fine for you?

Yes, I have the original one from the Russian site that works fine with respect to the buttons: pkb-cr3-pb-pro-0.0.6-16_3.0.57-15.zip

I tried keymap files from all three packages (some differ, som not): yours, the one I already had, and the one you pointed to at lesen.net. All with the same result.

I did, however, not do a full install of your package. I just copied the cr3_pk.app file. Is there any reason why I should replace all files?

Also, in dictionary mode, if I enter the dictionary window, the cursor is slightly off the small icons at the top (and of course does not move since the buttons do nothing).

[brucelee]

Originally Posted by sadowski

Yes, I have the original one from the Russian site that works fine with respect to the buttons: pkb-cr3-pb-pro-0.0.6-16_3.0.57-15.zip

Then I suppose it's a bug. I'll try to fix it although I won't be able to test.

Originally Posted by sadowski

Also, in dictionary mode, if I enter the dictionary window, the cursor is slightly off the small icons at the top

That's because there are 6 buttons instead of 4. You have to update the skins. However, if you did update the skins... then there's another bug.
The only changed files are the binary and the skins (for the moment).

[sadowski]

Originally Posted by brucelee

Then I suppose it's a bug. I'll try to fix it although I won't be able to test.

Happy to test!

Originally Posted by brucelee

That's because there are 6 buttons instead of 4. You have to update the skins. However, if you did update the skins... then there's another bug.
The only changed files are the binary and the skins (for the moment).

I did not update the skins. So this is no bug then.

[sadowski]

Skins: I verified that the cursor placement is correct with your skins.

In addition: in note mode, the little help text next to the small icons at the bottom has disappeared in your version, irrespectively of which skins are used. Maybe this hints to where the button problem is.

[gyeben]

Hi!

I have a request: could you please add an option to move the status bar to the bottom of the screen?

Thanks!