PRS+: Enhanced firmware for Sony Reader, Folders, Games & more

[kartu]

sideburnt
It looks fine. Weird that it doesn't work.
But quite many folders. Could you try to move folders other than PRSPInstaller into a TEMP subfolder and/or temporarily rename Sony Reader folder in the root of SD card?

PS
And don't try to start installer via menu any more. If it doesn't autostart (provided sd card scan is enabled) then the reader doesn't see installer's folders for some reason.

PPS
Could you check if PRSPInstaller folder is visible via "Browse Folders" menu please?

[PaladinBL]

Originally Posted by kartu

I plan to move localization files into "languages/<language name>" subfolders, and probably have 1 lang file (i.e. BrowseFolders.lang.js or BrowseFolders.lang) per addon (to allow concurrent modifications) that would then be combined into one language file by the build script.

I'll ask you to translate them, when they are finished.

This localization/translation is for everything in menus and for PRS+ installation process? Maybe I can try to make one when you finish what you are planing. You will just need to give me some pointers what to translate, what files.

[VICTORSJG]

Originally Posted by kartu

Yes, most of them. Translating "USB connected" is too much effort for next to no result imo, as well as "about" screen.

In my reader I can translate the different messeage like this (USB conected) from the menu about changing the language. (the translations are in the mainstorage.xml and storageStarts.xml files)

[sideburnt]

well I reformatted another SD card and moved the PRSInstall files onto it. First connection to the device and Bingo. All installed correctly. Thanks again for your support Kartu, looks like an error thrown up by PRO DUO cards, most likely as you've pointed out due to an incorrect drive assigned in the js file, but I think that either the additional content on the card and/or the fact its a PRO DUO card may be causing additional conflicts.

[elcreative]

And a to Kartu... just installed the new PRS and it was how installations should be... simple, straightforward and it worked. Will explore further over the next few days but if installation is anything to go by then we have another masterpiece...

[thawk]

We use main.xml to translate strings (PRS+ and original) into Chinese, using getTitle()/getValie() function. I hope it will be helpful for you.

If you have decided how to do localization, I have the Chinese translations and can be modified to the format you need.

    <group id="MENU_GROUP" left="0" right="0" top="0" bottom="0">
        <kbookMenu id="MENU" left="0" right="0" top="0" bottom="30" href="x-id://tableData">
            <code>
                        <function id="getTitle"><![CDATA[
    var strings = {
        // Keys
        "Volume-"                             : "音量-",
        "Hold Volume-"                        : "长按音量-",
...
    };

    var result = arguments.callee.grammar.call(this);
    var text="";

    if (strings[result])
    {
        return strings[result];
    }

    return result;
                ]]></function>
                <function id="getValue" params="record, field"><![CDATA[
...

[DoctorOhh]

kartu

Excellent install! The only discrepancy I see with your firmware upgrade is on the about page. With just plain old Sony firmware it says 1/2 at the bottom but with your firmware it says 1/1 even though there is a second page.

I also love being able to change the key binding on the center joypad button to next page. Is there any way to assign the function that was the default of the joypad center button (it is used to select menu items) to another button? Having a select or enter button for viewing news recipes is critical to navigating the document.

Until then I can just swap via the menu as needed.

[kartu]

PaladinBL
The localization affects nearly all files in code repository as well as the build lscript, in parallel, I plan to do heavy refactoring (utils.js has grown ugly as hell, browsefolders was a Frankenstein from the beginning) that will also affect nearly all files, it hardly makes sense to split this work. If you feel like contributing to PRS+ there are dozens of feature requests on the corresponding wiki page...

VICTORSJG
It's just seems like a lot of overhead just to replace single "USB is connected" string, since I cannot simply hardcode it in xml.

thawk
I've seen this code in porkupan's (boroda) firmwares. What I don't like about it is: it ALWAYS does lookup strings in a giant hashtable, instead of setting them once and for good.

Another thing (not related), does anyone understand why this call works:
var result = arguments.callee.grammar.call(this);

this kind of calls was made for anonymous functions to be able to recursively call themselves. But what I see in the code is not a recursion and should lead to stack overflow. (I know, that it doesn't, just don't get why)

elcreative
Thanks for the warm words.

sideburnt

well I reformatted another SD card and moved the PRSInstall files onto it. First connection to the device and Bingo.

So probably reader couldn't read entire folder stucture, strange. If this was the case, then moving most root folders into a subfolder would have worked as well.

dwanthny

With just plain old Sony firmware it says 1/2 at the bottom but with your firmware it says 1/1 even though there is a second page.

Yes, I'll have a look one day, thanks for reporting.

Is there any way to assign the function that was the default of the joypad center button (it is used to select menu items) to another button?

I think it would be 2 different actions, one for menu and one for books, but yes, it's possible.

[klawong]

Thank you very much for this brilliant piece of software!!!

Now it makes really fun reading with my 505 - before using PRS+ it was hell!

I can hardly expect the next step forward...

Cheers.

[surquizu]

Kartu,

With the PRS+ installer does not generate automatically the fonts folder (in the root of internal memory) or folder epub (in the folder PRSPlus) . Are necesary to use the css files (style epub)

[thawk]

Originally Posted by kartu

thawk
I've seen this code in porkupan's (boroda) firmwares. What I don't like about it is: it ALWAYS does lookup strings in a giant hashtable, instead of setting them once and for good.

Another thing (not related), does anyone understand why this call works:
var result = arguments.callee.grammar.call(this);

this kind of calls was made for anonymous functions to be able to recursively call themselves. But what I see in the code is not a recursion and should lead to stack overflow. (I know, that it doesn't, just don't get why)

Agree. It's better not to lookup every string every time.

I don't know about that call too. After some google, I found arguments.callee.call(), but not arguments.callee.grammar.

But anyway, I found that this line also exists in the original PRS+ firmware. (line 645 of main.xml, in getValue() function insides ABOUT_GROUP)

[kartu]

Originally Posted by surquizu

Kartu,

With the PRS+ installer does not generate automatically the fonts folder (in the root of internal memory) or folder epub (in the folder PRSPlus) . Are necesary to use the css files (style epub)

I'll add "epub" generation, probably, maybe even with sample files. But "fonts" could be anywhere user decides.

[surquizu]

Originally Posted by kartu

I'll add "epub" generation, probably, maybe even with sample files. But "fonts" could be anywhere user decides.

You could leave the folder "fonts" empty, but if you include facilitating the user know where to copy the fonts for a epub books.

If you want I can send my css and associated fonts for a examples

[kartu]

surquizu

You could leave the folder "fonts" empty, but if you include facilitating the user know where to copy the fonts for a epub books.

In this case most users would believe that fonts path is hardcoded, which I wanted to avoid.

If you want I can send my css and associated fonts for a examples

Yes please.

[surquizu]

Originally Posted by kartu

surquizu

If you want I can send my css and associated fonts for a examples


Yes please.

OK, attached file