[GUI Plugin] FanFicFare

[chrnno]

Having trouble downloading the ones below from fiction.live as they give a comment of 'contentRating', which I am guessing might be due to them being teen, another(chapter 8 of the series, so easy to find by going to author, is mature so not sure I should post here) says 'unhashable type: 'dict'.

https://fiction.live/stories/Golden-...7-f04d7eeca1ab
https://fiction.live/stories/Golden-...c-a89666375ac6
https://fiction.live/stories/Golden-...6-2299c7feddf8

I think this is not on my side(unlike all the timeouts which seem to be network issue given it can happen across all sites I updated fics) so assuming you will see the same and I don't need to post log, will do if I am wrong though.

[JimmXinu]

I don't think I've seen HazelSh here on MR forums, so I opened an issue(#547) on GitHub I could flag for their attention.

[JimmXinu]

New Test Version Posted

2020-09-16
- Add setting `remove_tags:script,style` replacing script remove hardcode, adding style remove. Closes #553.
- New Site: novelupdates.cc (possible transition dest for wuxiaworld.co?) - Thanks ElminsterAU!
- Fix for adapter_wuxiaworldsite not setting authorUrl.
- Fix for adapter_wuxiaworldco not setting authorUrl.
- Add dedup_img_files option(default:false). #550 (added a few hours later, only one download since.)

[ILB]

Originally Posted by JimmXinu

New Test Version Posted

2020-09-16

- New Site: novelupdates.cc (possible transition dest for wuxiaworld.co?) - Thanks ElminsterAU!

I tried https://www.novelupdates.cc/The-Legendary-Mechanic/
and got an error message.


Do I need to config something in personal.ini?

[JimmXinu]

Originally Posted by ILB

I tried https://www.novelupdates.cc/The-Legendary-Mechanic/
and got an error message.
Attachment 181991

Do I need to config something in personal.ini?

I've opened an issue for this: https://github.com/JimmXinu/FanFicFare/issues/555

[JimmXinu]

New Test Version Posted


2020-09-16
- Add setting `remove_tags:script,style` replacing script remove hardcode, adding style remove. Closes #553.
- New Site: novelupdates.cc (possible transition dest for wuxiaworld.co?) - Thanks ElminsterAU!
- Fix for adapter_wuxiaworldsite not setting authorUrl.
- Add dedup_img_files option(default:false). #550
- wuxiaworld.co and novelupdates.cc don't author links after all?

[ownedbycats]

I found what might be a bug. I'm able to reliably replicate it (at least when an ePub update is available):

Note: While bookmarks are enabled in ebook-viewer, they don't store in the epub files.

1. I finish reading what chapters are currently available. I leave the saved position at the last page of the latest chapter.
2. A new chapter becomes available, and I update the fic.
3. When I open the book again, the saved position is shifted to the beginning of the now second-to-latest chapter. (I've not been able to test what happens if multiple chapters are added.)

Is this usual behaviour? I'm not sure if this is a bug on or if it can even be fixed on the user/FFF end.

[JimmXinu]

New Test Version Posted

2020-09-17
- Add include_author_notes option (defaults on) to adapter_royalroadcom Closes #556
- adapter_fictionlive: Handle stories with missing contentRating, storyStatus & support beta.fictionlive.com domain, thanks HazelSh!

[JimmXinu]

Originally Posted by ownedbycats

I found what might be a bug. I'm able to reliably replicate it (at least when an ePub update is available):

Using the Calibre GUI Viewer in Calibre v4.99.16(64bit Win10), what I see is the 'last page' position being (apparently) discarded on epub update and I'm back at the beginning.

Which is honestly not an unreasonable thing for Calibre to do.

I tested by using http://test1.com?sid=6[-1], then http://test1.com?sid=6[-2], http://test1.com?sid=6[-3], etc to simulate updates.

BTW, I've fond of the mark_new_chapters setting to mark newly downloaded chapters. Especially useful if new chapters are inserted in the middle.

## If true, when updating an epub that already has old chapters, new
## chapters will be marked in the TOC and chapter header by using
## chapter_title_new_pattern and chapter_title_addnew_pattern to set
## the chapter title.
## If set to latestonly, only new chapters downloaded this time will
## be marked (new) and existing chapters will have any (new) marks
## removed.
## mark_new_chapters can be true, false or latestonly
mark_new_chapters:true

[ownedbycats]

I wonder if this would also mean bookmarks and the new annotations would be discarded as well, at least if they're stored within the ePub.

I'd expect "overwrite always" to get rid of them because it's an entirely new file but if updating also got rid of them that might be a bit frustrating for some users.

[JimmXinu]

Could be.

I know my Kindle's notes and highlights move around when the ebook is updated.

[chrnno]

Originally Posted by JimmXinu

New Test Version Posted

2020-09-17
- Add include_author_notes option (defaults on) to adapter_royalroadcom Closes #556
- adapter_fictionlive: Handle stories with missing contentRating, storyStatus & support beta.fictionlive.com domain, thanks HazelSh!

Tested and the dict issue no longer happens, contentRating still does though.

A look at the adapter in the file&github and it seems those parts weren't included in this test version, tried to do it manually but must have made a mistake somewhere.

[Lyen]

I was wondering if it would be possible to have EpubSplit integration into FFF for an option to automatically split off new chapters when updating an epub.

Also I probably should ask in the EpubSplit thread but, would also be nice for more customization options for the title of a split epub. An option to do both {chapter} - {title} as the new title instead of only {chapter} or {title}.

[JimmXinu]

New Test Version Posted -- for real

2020-09-17
- Add include_author_notes option (defaults on) to adapter_royalroadcom Closes #556
- adapter_fictionlive: Handle stories with missing contentRating, storyStatus & support beta.fictionlive.com domain, thanks HazelSh!

My bad. Sorry about that.

Originally Posted by chrnno

Tested and the dict issue no longer happens, contentRating still does though.

A look at the adapter in the file&github and it seems those parts weren't included in this test version, tried to do it manually but must have made a mistake somewhere.

[chrnno]

Originally Posted by JimmXinu

New Test Version Posted -- for real

2020-09-17
- Add include_author_notes option (defaults on) to adapter_royalroadcom Closes #556
- adapter_fictionlive: Handle stories with missing contentRating, storyStatus & support beta.fictionlive.com domain, thanks HazelSh!

My bad. Sorry about that.

Don't worry about it, tested and it is working now.

Also the dedup images is great for fiction.live, some authors reuse images a lot so it helps on keeping epub size more manageable.