calibre 5: Beta testers needed

[chaley]

See this thread for a description of the template language changes.

[jony08]

The main viewer seem perfect to me in calibre 4.99.14 but I would want some of the same features in the server viewer as well. For example the modify notes, show the style of each highlight next to the entry, go back to where you were before searching and everything seems bigger to me compared to the main viewer (controls, selection bar etc.).

[thiago.eec]

Originally Posted by kovidgoyal

2) The viewer highlights panel now shows the style of each highlight
next to the entry and the grouping is by the lowest level in the ToC,
not the highest.

I'm getting an error when double-clicking on the group (chapter) title:

Spoiler:

calibre, version 4.99.14
ERROR: Unhandled exception: <b>TypeError</b>:'NoneType' object is not subscriptable

calibre 4.99.14 Portable embedded-python: True is64bit: False
Windows-10-10.0.19041-SP0 Windows ('32bit', 'WindowsPE')
32bit process running on 64bit windows
('Windows', '10', '10.0.19041')
Python 3.8.5
Windows: ('10', '10.0.19041', 'SP0', 'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: ACE (1, 1, 1) && Skoob Books (1, 4, 0) && Skoob Sync (0, 3, 5)
Traceback (most recent call last):
File "site-packages\calibre\gui2\viewer\highlights.py", line 447, in jump_to_highlight
TypeError: 'NoneType' object is not subscriptable

Originally Posted by kovidgoyal

7) Viewer: Fix error when creating more than one custom highlight style

All good now.

[kovidgoyal]

@thiago: Thanks, fixed.

@jony08: The size of controls is the same, its the exact same code. Overall size is controlled by font size of your browser. And the server viewer is always going to be less capable than the main one, I have only so much time on my hands.

[jony08]

@kovid: the size seems larger in the server. The first two sceenshots are from the main viewer and the others come from the server viewer.

[jony08]

Just a small thing, the close button and the button to show the panel in its own window looks pixelated.

[kovidgoyal]

As I said, change the font size in your browser, that controls over all sizes. And yes the pixelated icons are a long standing bug in Qt.

[jony08]

Originally Posted by kovidgoyal

As I said, change the font size in your browser, that controls over all sizes. And yes the pixelated icons are a long standing bug in Qt.

I changed the zoom to 80% in Chromium and now the size is similar to the main viewer. The font sizes are the same.

[chaley]

Could people running the latest beta (4.99.14) please verify that all column icon/color rules and composite columns still work? It is unfortunately possible that I broke something and I would rather know now than after calibre 5 is released.

[davidfor]

Originally Posted by chaley

Could people running the latest beta (4.99.14) please verify that all column icon/color rules and composite columns still work? It is unfortunately possible that I broke something and I would rather know now than after calibre 5 is released.

It all looks good here.

I have a few icon and colour rules across my libraries. Some are simple comparisons, but a few use general program mode.

My metadata plugboard that adds last read, rating, page and word count to the comments is working fine. That only adds the value and text if the value exists. And, I just realised I have versions in both template program and general program modes.

And as a last test, I changed one of the recent templates I wrote for someone here:

program:
test(
	field('series'),
	strcat('__Series__/',field('series'),'/',format_number(field('series_index'),'{0:02d}'),' - ',field('title'),' - ',field('author_sort')),
	strcat(substr(field('author_sort'),0,1),'/',field('author_sort'),'/',field('title'))
	)

To:

program:
if field('series') then
	strcat('__Series__/',field('series'),'/',format_number(field('series_index'),'{0:02d}'),' - ',field('title'),' - ',field('author_sort'));
else
	strcat(substr(field('author_sort'),0,1),'/',field('author_sort'),'/',field('title'))
fi

That is in a custom column and works perfectly.

[nixsee]

I'm loving v14. Thanks for the color icons and line spacing!

I think it would really be helpful if there was a Collapse/Expand all button though - both for Highlights and, especially, Search.

[chaley]

Originally Posted by davidfor

It all looks good here.

Thanks for checking!

I have a few icon and colour rules across my libraries. Some are simple comparisons, but a few use general program mode.

Standard rules are implemented using generated GPM templates. Good that they work.

program:
if field('series') then
	strcat('__Series__/',field('series'),'/',format_number(field('series_index'),'{0:02d}'),' - ',field('title'),' - ',field('author_sort'));
else
	strcat(substr(field('author_sort'),0,1),'/',field('author_sort'),'/',field('title'))
fi

That is in a custom column and works perfectly.

I am surprised. In GPM a ';' is a statement separator, not a statement terminator. For if-then-else that means a ';' before 'else' or 'fi' is a syntax error. My suspicion is that your quick test was only on books with no series, in which case the interpreter swallows the 'then' part without verifying the syntax.

BTW: the "field()" function is now inlined, directly executed by the GPM interpreter. That means that now there is little performance difference between using a local variable and using "field", where before a local variable was around 10 times faster.

[nixsee]

I'm getting an error when I try to search highlights. I've tried it on a few books, cleared all highlights, etc... and nothing helps.

calibre, version 4.99.14
ERROR: Unhandled exception: <b>AttributeError</b>:'Highlights' object has no attribute 'currentRow'

calibre 4.99.14 Portable embedded-python: True is64bit: False
Windows-10-10.0.19041-SP0 Windows ('32bit', 'WindowsPE')
32bit process running on 64bit windows
('Windows', '10', '10.0.19041')
Python 3.8.5
Windows: ('10', '10.0.19041', 'SP0', 'Multiprocessor Free')
Interface language: None
Traceback (most recent call last):
  File "site-packages\calibre\gui2\viewer\highlights.py", line 439, in search_requested
  File "site-packages\calibre\gui2\viewer\highlights.py", line 252, in find_query
AttributeError: 'Highlights' object has no attribute 'currentRow'

[davidfor]

Originally Posted by chaley

I am surprised. In GPM a ';' is a statement separator, not a statement terminator. For if-then-else that means a ';' before 'else' or 'fi' is a syntax error. My suspicion is that your quick test was only on books with no series, in which case the interpreter swallows the 'then' part without verifying the syntax.

You're right. I just happened that the first screen worth of books didn't have a series. And I didn't scroll down as everything seemed to be working. I could see the errors when I scrolled down. Removing the semi-colon fixed it.

BTW: the "field()" function is now inlined, directly executed by the GPM interpreter. That means that now there is little performance difference between using a local variable and using "field", where before a local variable was around 10 times faster.

Good to know. What about "raw_field()"? I probably use that as much as "field()".

[kovidgoyal]

@nixsee: Yeah, silly typo left over from when I changed the list to be a tree. Fixed in next release.