calibre 5: Beta testers needed

[jony08]

Bug 1: Closing a panel while having text selected will move the handles away from the selection. I could send a picture but I don't know how to do it on this forum.

Bug 2: I am not sure why but my main calibre has the light theme while the server has the dark theme. How can I change this?

Bug 3: The Book details on the Content server has black text and dark background which makes the text impossible to read.

Bug 4: Double clicking on the text in the book selects the whole paragraph in 4.22, while in 4.99.10 double clicking only selects one word.

[kovidgoyal]

1. Generally speaking any resize of window will cause handles to lose position, this will be fixed in next release. EDIT: Actually no, doesnt happen for me, looks like resizes are already handled.

2. calibre follows your system theme settings. Am guessing you are on linux which has no system theme setting. Use the CALIBRE_USE_DARK_PALETTE=1 environment variable.

3. That will happen if your book details specify an actual color in their markup, it might be worth having calibre override these in dark theme.

4. Doesnt happen for me

[kovidgoyal]

Actually, no, I was mistaken, the comments being in black in the book details page in dark mode is indeed a bug, fixed in next beta.

[nixsee]

Another tremendous improvement Kovid! I'm extremely impressed and pleased with this now.

Some suggestions and bug reports:
1. I agree with The_Ad that the selection handles are too large. I actually do a double take each time they pop-up. Perhaps there's a way to have an invisible/transparent "touch zone" that surrounds a handle that is 80% smaller?

2. The "Search for selection in the book" button requires you to press enter when the search panel opens. Could it automatically apply the search?

3. I agree with thiago that the "Delete" and "Delete Selected" in the main "Browse Annotations" window are redundant - you only need one of them to work for

4. "Delete Selected" in "Browse Annotations" doesn't seem to do anything.

5. "Delete" doesn't seem to work when you have multiple selected in the "Browse Annotations" window. "Remove" in the Viewer's Highlights Pane allows for deleting multiple however. Perhaps synchronize the term in the two windows - either Remove or Delete?

6. I agree with thiago's suggestion/bug report that when you double click a highlight, a line break in a note should show as a line break, rather than putting them on the same line. Same thing in the Browse Annotations window. A single line break works in the Highlights panel of Viewer.

7. We shouldn't be allowed to click "Edit" in the Browse Annotations window when multiple highlights are selected. That would also fix the problem that it only edits one of the selected annotations when you do so.

8. The icon for Quick Highlight in the Selection Behavior configuration menu is still the same as the full Highlight Selection option, whereas they've been differentiated in the popup bar.

9. I agree with jony08's "Suggestion 5: Selecting a highlight in the Highlight panel should show the note under the highlight just like in the Search panel, instead on the bottom of the panel."

10. An old suggestion: show a small icon at the end of a highlight that indicates there is a note, to differentiate it from a bare highlight. Kindle for PC has this and it is very nice. See below:



11. "Edit" in the Viewer's Highlights panel doesn't work if there is already a note. Only if it is a bare highlight.

12. I get the same problem as jony's "Bug 4: Double clicking on the text in the book selects the whole paragraph in 4.22, while in 4.99.10 double clicking only selects one word." In 4.21 I can "triple click" to select a whole paragraph, but it stays limited to one word in 4.99.10.

Thanks so much for your hard work!

[kovidgoyal]

1. No. Having invisible zones is just confusing. Deal with a big handle.

2. No searching automatically jumps to a potentially different place in the book, which is very disorienting

3. One deletes selected items, one deletes the current item. Am glad you dont need both, use whiever one you prefer

4. That is a bug fixed in next beta

5. See 3

6. See my reply to thiago

7. Again, the buttons in the panel operate on the current highlight.

8. Yes, its the same icon, except that in the bar it shows a color underneath. And I have changed it for the next beta to have a bar of color underneath it in the preferences as well.

9. See my reply to jony

10. Not worth the effort for me, patches welcome

11. Works for me

12. Double clicking is supposed to select a word. If it selects a whole paragraph in 4.22 that's a bug. Although as I said it selects a word for me in 4.22 as well.

[kovidgoyal]

I changed the delete selected button to only be visible if more than one item is selected, that should reduce confusion.

[kovidgoyal]

On second thoughts adding an indicator after a highlight with notes is not too hard, will be in next beta.

[thiago.eec]

Originally Posted by kovidgoyal

I changed the delete selected button to only be visible if more than one item is selected, that should reduce confusion.

Originally Posted by kovidgoyal

On second thoughts adding an indicator after a highlight with notes is not too hard, will be in next beta.

Great news. Thanks, Kovid!

[nixsee]

Glad to see the various bug fixes, icon and Delete selected only when multiple are selected!

6. See my reply to thiago

I think we're having a miscommunication. Here are some screenshots to show what I'm (we're?) talking about.

Annotation with single and double line break


When double click annotation: First two lines are on the same line, then there's a double space and the 3rd line


In the Highlights Pane, it looks exactly as originally entered and expected.


In the Browse Annotations window, it looks how it does with the double click on Highlight.


It would be nice if they all presented as it does in the Highlights pane, which is how it was originally entered.

9. See my reply to jony

"5. Not worth the trouble to implement at least for me"

I hope it can be added to a "Someday/Backlog" sort of list!

11. Works for me

Seems to be working for me again now... I promise that it wasn't before. I'll repost if I can find specific steps to recreate it.

12. Double clicking is supposed to select a word. If it selects a whole paragraph in 4.22 that's a bug. Although as I said it selects a word for me in 4.22 as well.

As I mentioned, triple clicking allows for selecting a paragraph, but doesn't go past the current word in 4.99. GIF below:

[kovidgoyal]

If lines are wrapped at single line breaks it means the text becomes not reflowable. If you view the notes in a panel that is narrower than the original panel they were created in, you get ugly multiple breaks caused by wrapping.

This is why *all* text markup languages use blank lines to denote paragraphs and single line breaks are treated as spaces. That is what calibre is doing everywhere except the viewer highlight panel, which was a bug, now fixed.

[nixsee]

Understood. Thank you for explaining this to me. I am starting to get into writing in Markdown so will have to get used to this formatting for that as well.

[jony08]

@kovidgoyal When you're about to delete a highlight, you are asked for Yes or No. Everywhere else in calibre you get the options Cancel or OK.

Feature request: I cannot find a way to browse the highlights on the server viewer? Please add this feature.

[kovidgoyal]

And yes, triple clicking will be fixed in the next release.

@jony08: Not at all in the main calibre program there is a mix of ok/cancel and yes/no for questio dialogs. I have changed it to be always yes/no. And there is no way to browse either highlights or bookmarks or even create book marks in the server viewer, it's on my TODO list.

[jony08]

I got this error trying to copy text in the server viewer, using Firefox on my phone.

TypeError: window.navigator.clipboard is undefined
Error at http://192.168.1.54:8080/:40279:21
Traceback (most recent call last):

ρσ_anonfunc@http://192.168.1.54:8080/:33483:33
copy_to_clipboard@http://192.168.1.54:8080/:34069:31
ρσ_anonfunc@http://192.168.1.54:8080/:40279:21

[jony08]

This was not a beta bug report, moving it to calibre bug tracker.