[GUI Plugin] Modify ePub

[Rev. Bob]

Originally Posted by chaley

Thank you @fvdham and @DNSB.

Version 1.5.7, fixing the problem accessing the help file. Tested on 4.23 and 5.0.1.

If

• this change works for people other than me
• people tell me that the plugin works on calibre versions before 5
• no other problems are reported in the next day or so

then I will release this version.

Have you listed yourself in the credits? If not, please do so to credit yourself for the port, and please add an entry to the changelog to document this update.

I would also suggest not considering the beta version number increments as “real,” since they were only used for testing and not released as official versions. I’m not at my computer to verify the current release version number (the first post in this thread lists two entries for 1.4.0, leading me not to trust that), but I would suggest bumping the current version number to the next 1.x.0 version for this one. So, if you’d picked 1.5.2 (the first of your betas I see) because the current one is 1.5, let’s go with 1.6.0.

I’m still on 4.23 myself, so I’ll try to grab this tonight and test it using my usual CLI settings to see how it goes. Assuming all goes well – and if nobody’s run this on a Google Play book or a Kobo book yet, please speak up so I can be sure to test that – releasing it Tuesday or Wednesday sounds like a fine plan.

[JSWolf]

I have more information on what's going on.

Calibre 4.23 and the option "Add unmanifested files to manifest" and the file that's not manifested is META-INF/com.apple.ibooks.display-options.xml.

[BetterRed]

Originally Posted by Rev. Bob

I’m not at my computer to verify the current release version number (the first post in this thread lists two entries for 1.4.0, leading me not to trust that),

Probably because whoever asked me to post the new zip - gave me the version update text as you saw it (1.40 blah blah) so I blithely coffee-d and pasta-d it

Fixed

BR

[chaley]

Originally Posted by JSWolf

With 5.0.1 and all options checked it's working.

With 4.23 (all options checked)and the ePub I sent to you that's not scrambled.

I think I know what is happening but I don't know how to test it. Would you be willing to send me the failing unscrambled book? I will use it only to test and will not keep it. If you will then send it to to calibre-bugs-mod [at] charleshaley [dot] org (make the replacements).

[chaley]

Originally Posted by Rev. Bob

Have you listed yourself in the credits? If not, please do so to credit yourself for the port, and please add an entry to the changelog to document this update.

I don't need credit. I will update the change log when it is released.

I would also suggest not considering the beta version number increments as “real,” since they were only used for testing and not released as official versions. I’m not at my computer to verify the current release version number (the first post in this thread lists two entries for 1.4.0, leading me not to trust that), but I would suggest bumping the current version number to the next 1.x.0 version for this one. So, if you’d picked 1.5.2 (the first of your betas I see) because the current one is 1.5, let’s go with 1.6.0.

That is what I was planning to do.

I’m still on 4.23 myself, so I’ll try to grab this tonight and test it using my usual CLI settings to see how it goes. Assuming all goes well – and if nobody’s run this on a Google Play book or a Kobo book yet, please speak up so I can be sure to test that – releasing it Tuesday or Wednesday sounds like a fine plan.

I agree, assuming by then I fix the problem @JSWolf found.

[Rev. Bob]

Originally Posted by chaley

I don't need credit.

Nonsense. You deserve it. Credit yo’self.

[BetterRed]

Anyone who won't take the credit for something they do is usually hoping they won't be blamed when said something goes belly up

[JSWolf]

Originally Posted by chaley

I think I know what is happening but I don't know how to test it. Would you be willing to send me the failing unscrambled book? I will use it only to test and will not keep it. If you will then send it to to calibre-bugs-mod [at] charleshaley [dot] org (make the replacements).

Sure thing. I'll send the eBook now.

[Thasaidon]

Originally Posted by Rev. Bob

Nonsense. You deserve it. Credit yo’self.

I agree.

Chaley you may not need it but you deserve it

[chaley]

Beta V1.5.8. Fixes the problem @JSWolf reported.

@JSWolf: I am guessing that your calibre 4.23 installation is 64 bit. In that case the plugin was prepared to handle roughly 18 quintillion items in the epub. That is rather excessive so I lowered it to a more reasonable number: 1 billion. (Gotta have fun when I can!)

[Terisa de morgan]

Originally Posted by BetterRed

Anyone who won't take the credit for something they do is usually hoping they won't be blamed when said something goes belly up

[IndioB]

Originally Posted by chaley

Beta V1.5.8. Fixes the problem @JSWolf reported.

@JSWolf: I am guessing that your calibre 4.23 installation is 64 bit. In that case the plugin was prepared to handle roughly 18 quintillion items in the epub. That is rather excessive so I lowered it to a more reasonable number: 1 billion. (Gotta have fun when I can!)

V1.5.8 Work OK in Calibre 5.01 - Win 8.1 64b

[JSWolf]

Originally Posted by chaley

Beta V1.5.8. Fixes the problem @JSWolf reported.

@JSWolf: I am guessing that your calibre 4.23 installation is 64 bit. In that case the plugin was prepared to handle roughly 18 quintillion items in the epub. That is rather excessive so I lowered it to a more reasonable number: 1 billion. (Gotta have fun when I can!)

4.23 is 64-bit and 5.0.1 is 32-bit (portable).

I'll give the new beta a going over. Thank you.

Oh and there's one thing...I'd like 1 billion and 1 things. 1 billion is not enough.

[JSWolf]

Originally Posted by chaley

Beta V1.5.8. Fixes the problem @JSWolf reported.

@JSWolf: I am guessing that your calibre 4.23 installation is 64 bit. In that case the plugin was prepared to handle roughly 18 quintillion items in the epub. That is rather excessive so I lowered it to a more reasonable number: 1 billion. (Gotta have fun when I can!)

I've tested with 4.23 and 5.0.1. I even tested what happens with no eBooks selected. It's working with 5.0.1, but with 4.23 I've found something rather interesting. When I save the modified ePub, the encoding is off. The quote and apostrophes are showing as black diamonds with a question mark. I've emailed the same eBook so you can have a look.

[chaley]

Originally Posted by JSWolf

I've tested with 4.23 and 5.0.1. I even tested what happens with no eBooks selected. It's working with 5.0.1, but with 4.23 I've found something rather interesting. When I save the modified ePub, the encoding is off. The quote and apostrophes are showing as black diamonds with a question mark. I've emailed the same eBook so you can have a look.

V1.5.9 that fixes the black diamonds and, I hope, broke nothing else.