Plato: A document reader for PDF, ePUB, DjVu, etc.

[NiLuJe]

@baskerville: Week was a bit insane, sorry for the delay .

Here goes the log:

Plato is running on a Kobo Sage.
The framebuffer resolution is 1440 by 1920.
Tap (82, 1329) (1440, 1920)
Tap (123, 94) (1440, 1920)
Tap (1832, 140) (1440, 1920)
Tap (1817, 1363) (1440, 1920)
Tap (1813, 1357) (1920, 1440)
Tap (85, 1336) (1440, 1920)
Tap (93, 108) (1920, 1440)
Tap (1840, 141) (1440, 1920)
Startup rotation: 1.
Mirroring scheme: (0, 1).

Things look okay, except for the fact that it started upside down (actually UD, e.g., how a lefty might hold the device) .

[baskerville]

Thanks, can you try the attached binary and see if the current view rotates in accordance with the device?

[NiLuJe]

@baskerville: Startup is okay, but the gyro is uniformly inverted (UR <-> UD & CW <-> CCW).

As for the manual rotations, UR & UD are okay, but CW & CCW are inverted.

[baskerville]

Originally Posted by NiLuJe

As for the manual rotations, UR & UD are okay, but CW & CCW are inverted.

When the rotation value goes from x to x + 90, the current view should rotate clockwise: aren't you experiencing this?

You can also rotate the current view using the rotation gesture: one finger still, the other doing quarter circles around it.

[NiLuJe]

I'm expecting the *device* to be rotated CW when at 90, which might explain my comment above (although I seem to recall it working that way on the h2o, Forma & Elipsa). I'll double-check tonight .

[baskerville]

Originally Posted by NiLuJe

I'm expecting the *device* to be rotated CW when at 90

When the view rotates clockwise, the user rotates its device anticlockwise.

[NiLuJe]

Originally Posted by baskerville

When the view rotates clockwise, the user rotates its device anticlockwise.

That's because I go by the LinuxFB convention, where the "public" constants in 90° CW increments refer to *screen* rotations, not view/fb rotations .

Anyways, that only leaves the Gyro landscapes inverted, then (and this applies to the Elipsa).

EDIT: It's okay on the Forma.

EDIT²: The "Reboot" button also did something wonky on the Elipsa (e.g., it showed the "Welcome to Kobo" setup message for a few seconds before rebooting a second time for good).

[baskerville]

Originally Posted by NiLuJe

Anyways, that only leaves the Gyro landscapes inverted, then (and this applies to the Elipsa).

Unfortunately, I made a mistake in the last commit and added a rotation quirk for the Sage instead of adjusting the existing gyro quirk. It shouldn't have affected the Elipsa though. Please try the new binary on both devices.

Originally Posted by NiLuJe

The "Reboot" button also did something wonky on the Elipsa (e.g., it showed the "Welcome to Kobo" setup message for a few seconds before rebooting a second time for good).

The reboot action is equivalent to:

sync
reboot

[NiLuJe]

Originally Posted by baskerville

Unfortunately, I made a mistake in the last commit and added a rotation quirk for the Sage instead of adjusting the existing gyro quirk. It shouldn't have affected the Elipsa though. Please try the new binary on both devices.

Sorry, that was unclear, I was still running the latest release on the Elipsa .

[NiLuJe]

Originally Posted by baskerville

sync
reboot

Isn't it also doing something like calling on-animator in some way? Because it did that (as in, show the spinner, live, before the reboot, as soon as possible), first, too.

[baskerville]

Originally Posted by NiLuJe

Isn't it also doing something like calling on-animator in some way?

You found a bug in plato.sh: I thought reboot didn't return. But it does, hence Plato exits normally and nickel.sh is called at the end of the script!

[NiLuJe]

Ah, yeah, that would definitely explain the behavior I saw .

----

And the gyro now behaves as expected with the latest binary (-03) .

[Almamida]

I have a Libra2 and a Sage, if I can help testing anything.

[baskerville]

Originally Posted by Almamida

I have a Libra2 and a Sage, if I can help testing anything.

Could you try the attached binary (replace Plato's binary with it and launch Plato as you normally would) on your Libra 2 and post the relevant lines from info.log (the eight lines that start with Tap, the following two lines and all the lines that start with Framebuffer rotation)?

[Almamida]

Plato is running on a Kobo Libra 2.
The framebuffer resolution is 1264 by 1680.
Tap (93, 99) (1264, 1680)
Tap (67, 1187) (1264, 1680)
Tap (1627, 1181) (1264, 1680)
Tap (1611, 66) (1264, 1680)
Framebuffer rotation: 0 -> 0.
Tap (1595, 75) (1680, 1264)
Framebuffer rotation: 1 -> 1.
Tap (87, 85) (1264, 1680)
Framebuffer rotation: 2 -> 2.
Tap (80, 1162) (1680, 1264)
Framebuffer rotation: 3 -> 3.
Tap (1596, 1150) (1264, 1680)
Framebuffer rotation: 1 -> 1.
Startup rotation: 1.
Mirroring scheme: (3, -1).

I kept the Kobo in portrait the entire time