![]() |
#781 |
Love reading
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 322
Karma: 1000352
Join Date: Jan 2012
Device: Samsung 8 mobile. Samsung 8 and 10 Tablets
|
![]()
I had a message appear in calibre saying update Find Duplicates
So I clicked on it and it has now gone from the top bar Help please ![]() |
![]() |
![]() |
![]() |
#782 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 1,199
Karma: 1995558
Join Date: Aug 2015
Device: Kindle
|
Try re-adding it through preferences > toolbars & menus > Main toolbar
|
![]() |
![]() |
Advert | |
|
![]() |
#783 |
Love reading
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 322
Karma: 1000352
Join Date: Jan 2012
Device: Samsung 8 mobile. Samsung 8 and 10 Tablets
|
|
![]() |
![]() |
![]() |
#784 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 6,637
Karma: 12595249
Join Date: Jun 2009
Location: Madrid, Spain
Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2
|
I've installed the new version (new plugin, really
![]()
|
![]() |
![]() |
![]() |
#785 | |||
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 1,199
Karma: 1995558
Join Date: Aug 2015
Device: Kindle
|
Quote:
Quote:
Quote:
The problem is that since this new mode uses custom columns and templates, we can have a situation where the plugin trying to restore settings and failing because a custom column is no longer there, or user defined template function is deleted. When restoring from saved settings, the code actually checks for all these things, restores columns and algorithms that can be restored, and then presents the user with detailed error messages of what cannot be restored. This can be easily applied to restore the preference from when the user last used the plugin, I just think it is ugly for the user to open the plugin and be greeted with an error message immediately. So, I thought about making this optional, but I am still not sure about the default, should it be set to restore or not, and should I do it as separate option for each dialog or just one that apply to all three dialogs. Edit: Another option is to fail silently without an error message. Last edited by capink; 10-16-2020 at 01:25 PM. |
|||
![]() |
![]() |
Advert | |
|
![]() |
#786 | |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 1,013
Karma: 500000
Join Date: Jun 2015
Device: Rocketbook, kobo aura h2o, kobo forma, kobo libra color
|
Quote:
Or something like that. That way, next time it would be the same as failing silently, except that everything that wasn't broken should work. Another option would be to leave everything broken, print some warnings to the debug log, and force the user into the preferences dialog (maybe with an explanation why) next time they try to use the plugin. The big difference is that if the deleted a column and put it back, the second option should leave everything as it was. |
|
![]() |
![]() |
![]() |
#787 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 6,637
Karma: 12595249
Join Date: Jun 2009
Location: Madrid, Spain
Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2
|
I'm not a fan of giving the information about the error in the debug log, I think that a message as: "xxxxx" preferences are not longer valid, or something like that, is useful, and clearing that default.
|
![]() |
![]() |
![]() |
#788 | ||
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 1,199
Karma: 1995558
Join Date: Aug 2015
Device: Kindle
|
Quote:
There is no preference dialog to direct the user to, you have to check the settings when the user opens the plugin, and take the action then, as it stands now, if an error is found, it would pop a message detailing what went wrong. The restore code already does that, but this going to be missed by most users because you don't normally start calibre in debug mode, and even if you did, you probably miss it if only one template failed in a multi-algorithm rule. Quote:
I thought that the presence of the saved settings feature might be enough for people since you restore it with just a one click, Apparently not. So, I decided to wait on automatic restore of last used settings until I have clear picture of how to do it. Because if I proceed now and changed my mind later, I will have to bump the config file schema version, and add code to convert user's old settings to the conform with the new schema, which I don't really want to do. |
||
![]() |
![]() |
![]() |
#789 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 6,637
Karma: 12595249
Join Date: Jun 2009
Location: Madrid, Spain
Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2
|
No, as before you had to do nothing. Now, you have to select the template and load it every time, it's not just a click. Well, I like the plugin as it is now, but I think I prefer the usability of the previous one, that was enough for my needs.
|
![]() |
![]() |
![]() |
#790 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 1,199
Karma: 1995558
Join Date: Aug 2015
Device: Kindle
|
Give it some time and it will eventually be done. The solution I'm currently leaning towards, is to restore only if the settings are 100% valid, if not do not restore (no message popup), with an option for the user to override the default behavior make it restore with message if errors are found.
|
![]() |
![]() |
![]() |
#791 | |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 6,637
Karma: 12595249
Join Date: Jun 2009
Location: Madrid, Spain
Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2
|
Quote:
|
|
![]() |
![]() |
![]() |
#792 | |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 1,013
Karma: 500000
Join Date: Jun 2015
Device: Rocketbook, kobo aura h2o, kobo forma, kobo libra color
|
Quote:
In my own plugin, I reserved a line or two of "blank" space, and stuffed status messages in there including successes, warnings, errors, etc. If you really want to get fancy, stick a column on the left and when there's errors, stuck a red arrow or some other marker in that column or something like that. (And I'd also put a marker in the message box with a message explaining what it meant.) I think it's easy to put a trigger on the rule and/or marker so that when you hover, the message changes if there is a message. You could also just color the text of the errored rule, but I'm a bit leery of that because I'm always afraid some person isn't going to be able to see the color change or won't understand it or might be using dark mode where the color change makes the text invisible or something annoying. |
|
![]() |
![]() |
![]() |
#793 | |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 1,199
Karma: 1995558
Join Date: Aug 2015
Device: Kindle
|
Quote:
I will defer modifying the error dialog until I see how it goes on the long term, and I suspect the majority does not routinely delete their custom columns or functions, so probably most will not have to deal with them anyway. |
|
![]() |
![]() |
![]() |
#794 |
Wizard
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 1,199
Karma: 1995558
Join Date: Aug 2015
Device: Kindle
|
Version 1.8.2
Update: Restore last used match rules and sort filters. Fix: Allow dialog size to be reduced. The dialog was still not shrinking horizontally, so I had the modify the save/restore box by removing the "add to existing" checkbox and substituting it with a drop-down button. |
![]() |
![]() |
![]() |
#795 |
Grand Sorcerer
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 6,637
Karma: 12595249
Join Date: Jun 2009
Location: Madrid, Spain
Device: Kobo Clara/Aura One/Forma,XiaoMI 5, iPad, Huawei MediaPad, YotaPhone 2
|
Thank you for the changes! There is a minor problem yet. When you're searching between libraries, every time you change the destination library the settings for the search are removed.
|
![]() |
![]() |
![]() |
Tags |
cross library duplicates, in library duplicates |
|
![]() |
||||
Thread | Thread Starter | Forum | Replies | Last Post |
[GUI Plugin] Quality Check | kiwidude | Plugins | 1252 | 08-02-2025 09:53 AM |
[GUI Plugin] Generate Cover | kiwidude | Plugins | 862 | 07-24-2025 08:49 PM |
[GUI Plugin] View Manager | kiwidude | Plugins | 416 | 07-16-2025 05:35 PM |
[GUI Plugin] Open With | kiwidude | Plugins | 404 | 02-21-2025 05:42 AM |
[GUI Plugin] Plugin Updater **Deprecated** | kiwidude | Plugins | 159 | 06-19-2011 12:27 PM |