Comments field

[banjomike]

Is there a regex that will select books with an empty comments field?

I'm going through the process of adding detailed comments to books and I just what to see which ones are left.

[GRiker]

Try comment:false in the search field. That works for covers ...

G

[theducks]

Originally Posted by banjomike

Is there a regex that will select books with an empty comments field?

I'm going through the process of adding detailed comments to books and I just what to see which ones are left.

In the (normal) search box: comments:false

[Starson17]

Originally Posted by theducks

In the (normal) search box: comments:false

Make sure your version is one of the last 2-3 or so. There was a bug in the code and prior to that the "false" searches only found the first entry. (Possibly "not comments:true" would have worked for older versions.)

[banjomike]

Originally Posted by Starson17

Make sure your version is one of the last 2-3 or so. There was a bug in the code and prior to that the "false" searches only found the first entry. (Possibly "not comments:true" would have worked for older versions.)

"not comments:true", works, thanks. (using 0.6.46)

Originally Posted by theducks

In the (normal) search box: comments:false

That mostly works although it also picks up comments with the word "false" in them. Seems like a combined logic AND text search.

[Starson17]

Originally Posted by banjomike

That mostly works although it also picks up comments with the word "false" in them.

Thanks for responding. I saw this error a while back, meant to think about the solution, then forgot about it.

[chaley]

Originally Posted by banjomike

That mostly works although it also picks up comments with the word "false" in them. Seems like a combined logic AND text search.

That is indeed what the code does, and it is a bug. I probably broke it, and I will definitely fix it.

BTW: not comments:true does work correctly.

BTW**2: The regexp comments:~^$ should in theory match an empty comment. However, empty comments are represented as missing text, not text containing no characters, so no regexp (or any other match) is tested. I could make a special case of this pattern, if the general consensus is that it really should work.

[Starson17]

Originally Posted by chaley

That is indeed what the code does, and it is a bug. I probably broke it, and I will definitely fix it.

I spotted the previous bug in the false searches, and while looking for it, I became somewhat familiar with the search code. Later I encountered the bug that "comments:false" found comments that have the word "false" in them, and I remember I was sort of puzzled as I had vaguely recalled the code and thought that this shouldn't have happened. I realize now you must have changed the code.

BTW: not comments:true does work correctly.

Actually, when I suggested that, it was because I remembered the old code had first identified "false" searches, then went on to process non-false searches differently. It's nice to know that it works, but I suspect you will fix the code pretty quickly

BTW**2: The regexp comments:~^$ should in theory match an empty comment. However, empty comments are represented as missing text, not text containing no characters, so no regexp (or any other match) is tested. I could make a special case of this pattern, if the general consensus is that it really should work.

When I spotted the new bug in the false search (locates comments with "false" in the text), the first thing I did was try a regexp search. I suppose if you are in the code again, you might as well add that, as I can imagine people doing that search if they know regex, but not about true/false searches.