Sigil crashes when loading file from the internet

[mrprobert]

I crashed Sigil after I tried to load a file from the the internet. 'Twas an accident, I meant to use a local file. I am pretty sure loading a file from an internet address will never work. But, should it cause a crash?

Below is the URL and the resulting error.

Thanks.

https://www.adfg.alaska.gov/static/f...ort_Fish.1.jpg

Error info: https://www.adfg.alaska.gov/static/f...ort_Fish.1.jpg
Sigil version: 2.5.2
Runtime Qt: 6.8.2
Compiled Qt: 6.8.2
System: Windows 10 Version 22H2
Architecture: x86_64

[DiapDealer]

We hope Sigil would never crash. But we need to know what you mean by "tried to load a file from the internet". Do you mean a remote address was given for an img tag source in the epub's xhtml, or that you tried to add an image to an epub by using an url in the Add File dialog?

[DiapDealer]

I can't get Sigil 2.5.2 to crash on Windows with an internet url used as the src attribute for an img tag. In fact, the image displays just fine. There doesn't seem to be a way to use an url in the Add File dialog, so I guess I'm at a loss as to what exactly you're doing when Sigil crashes.

I even tried opening the remote url with Sigil's Open dialog (changing the filter from .epub to * all files), and while I get an error, I get no crash.

[mrprobert]

What I did was this:

Start Sigil.
Place the cursor in between the paragraph tags.
Using the mouse, select Insert -> File from the menu.
Click on the Other Files button.
Paste the URL into the field at the bottom of the Add Existing Files window.
After about 5 seconds a popup occurs: Sigil has encountered a problem and may need to close.
Click on show details button.
Click on close button.
Sigil crashes.

It's repeatable. Doing add cover in the same fashion also leads to a crash as well. Reading a local file with a path like C:\Users\Mark\Pictures\foo.jpg loads as normal.

[mrprobert]

The .wer file associated with the crash says:

Access Violation 0x00001fdd Qt6Core.dll 6.7.3.0

[DiapDealer]

Got it. Thanks for the details. I can recreate it. I doubt this is new to 2.5.2--it's probably been around for a while.

I agree that it shouldn't really be expected to work, but it also shouldn't crash if at all possible.

[KevinH]

But Qt 6.7.3 is used by the older Sigil 2.4.2, not the newer 2.5.2. So your .wer crashfile might not be accurate.

I will try the same thing now that we know the exact steps to recreate the crash, but under MacOS and Linux to see if we can get a solid backtrace of the crash.

Of course, this just had to be found immediately after a release!

[mrprobert]

Please ignore the last reply as I think it was from an unrelated earlier Sigil crash.

[KevinH]

Originally Posted by mrprobert

Please ignore the last reply as I think it was from an unrelated earlier Sigil crash.

Just how frequently is Sigil crashing on your system? As far as I am concerned, Sigil should never crash, period. If you have experienced crashes with Sigil 2.4.2, please describe each and provide an exact sequence of events to recreate the crash. Actual crashing for any reason is never acceptable.

[KevinH]

And this crash appears to be os specific (native vs non-native file dialogs?). On Mac OS when I try that exact sequence of events and force select the open button I just get a qmessage box that says:

"Sport_Fish.1.jpg"
"File not found."
"Please verify the correct file name was given."

With an Okay button. If you press it all is fine and it brings you back to the non-native file dialog box and gives you a chance to type in or browse to a real file.

If I try any kind of url it seems the MacOS non-native qfiledialog also refuses to allow you to select the open button, leaving only cancel.

This is when I try the url provided above:

https://www.adfg.alaska.gov/static/fishing/images/sport/galleries/Sport_Fish.1.jpg

So on Mac OS no crash, but I really think that is because the non-native file dialog used on MacOS properly handles that case by checking to see if the local file exists.

I will test next under Linux.

[KevinH]

And after testing on Linux (Manjaro under KDE plasma desktop), again the non-native QFileDialog is smart enough to handle that case.

It returns a qmessage box with the following error message:

The selected URL uses an unsupported scheme. Please use the following scheme: file

with an Okay button that when pressed brings you back to the file open dialog so you can try something else.

It is interesting, the MacOS version search for that file locally but could not find it since it was a external file via url. The Linux KDE filedialog, recognized that you were trying a url but it only supports local "file:" schemes for urls not external links.

So this crashing bug seems to be specific to Windows and most likely to its native filedialog box.

There are even Qt bugs that are related to this about how using a QFileDialog from inside a QDialog causes crashes on Windows under certain circumstances. See https://bugreports.qt.io/browse/QTBUG-136333 But they were reported for Qt 6.8.3 not Qt 6.8.2 we use on Windows. But maybe they were never tested.

So we could try using a non-native file dialog box here on Windows as this testing of the file happens inside the qfiledialog and can not be screened for in advance by Sigil code.

[Doitsu]

Originally Posted by mrprobert

I am pretty sure loading a file from an internet address will never work.

Shameless plug: I recently updated my PasteImage Edit plugin, which allows you to paste images into Sigil from the clipboard or via image links.

Maybe the image is not properly encoded, because when I right-click the image and select Copy image and then select Plugins > Edit > PasteImageQt, the image is inserted without problems.
However, when I right-click the image and select Copy image link and then select Plugins > Edit > PasteImageQt, the image is added but Sigil displays it as 0x0px image.

BTW, I was able to reproduce your error on my Windows 11 machine:

Error info: https://www.adfg.alaska.gov/static/fishing/images/sport/galleries/Sport_Fish.1.jpg
Sigil version: 2.5.2
Runtime Qt: 6.8.2
Compiled Qt: 6.8.2
System: Windows 11 Version 22H2
Architecture: x86_64

[mrprobert]

Originally Posted by KevinH

Just how frequently is Sigil crashing on your system? As far as I am concerned, Sigil should never crash, period. If you have experienced crashes with Sigil 2.4.2, please describe each and provide an exact sequence of events to recreate the crash. Actual crashing for any reason is never acceptable.

Sigil crashes are uncommon on my computer. Sometimes I notice a peculiarity that almost always turns out to an error on my part. I do report any crashes that I can reproduce, but this older crash was the type for which I could find no specific invocation of steps to report, and also not something more general that would point to the problem. Indeed, it might be weeks or months between crashes that I suspect stem from the same root cause. The few times I've submitted an error you were able to find a fix, for which I am grateful.

[mrprobert]

Originally Posted by Doitsu

[B]Maybe the image is not properly encoded, because when I right-click the image and select Copy image and then select Plugins > Edit > PasteImageQt, the image is inserted without problems.
However, when I right-click the image and select Copy image link and then select Plugins > Edit > PasteImageQt, the image is added but Sigil displays it as 0x0px image

The first crash happened when I pasted in this URL, which was supposed to open a scaled image from bigjpg.

https://dcdn.disk.zipjpg.com/free/34...at,jpg&big.jpg

It doesn't point to anything useful and is so very odd that I submitted a random image I pulled off the net.

[mrprobert]

I do need to report what I think is a harmless error from using the plugin ConvertAbs2RelCSSValues. If this is my CSS:

/* com1 */
/* com2 */

then the plugin replaces the text with:

/* com1 */;
/* com2 */;

Those semi-colons I believe are superfluous, but harmless. Should I send a report to the thread for the plugin?