Error on Add/Edit to PDF Open with

[BetterRed]

If I try to add an item to, or edit, the PDF Open With list, viz :



I get an error popup and a spinning wheel, viz



The text of the error is:

calibre, version 6.10.0
ERROR: Unhandled exception: <b>TypeError</b>:QIcon(): argument 1 has unexpected type 'QImage'

calibre 6.10  embedded-python: True
Windows-10-10.0.19045-SP0 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.19045')
Python 3.10.1
Windows: ('10', '10.0.19045', 'SP0', 'Multiprocessor Free')
Interface language: en_AU
Successfully initialized third party plugins: CalibreSpy (1, 0, 90) && Count Pages (1, 12, 0) && Favourites Menu (1, 3, 0) && GetFileName (0, 2, 0) && Goodreads (1, 7, 2) && Job Spy (1, 0, 197) && Modify ePub (1, 8, 1) && Scroll Book Details (1, 0, 2) && View Manager (1, 10, 2)
Traceback (most recent call last):
  File "calibre\gui2\open_with.py", line 339, in programs_found
  File "calibre\gui2\open_with.py", line 128, in entry_to_item
TypeError: QIcon(): argument 1 has unexpected type 'QImage'

I get the same error with DOCX Open With->Edit…

I'm guessing it's something to do with some programs not showing an icon (see first image). I have no idea why, and I'm not sure they ever had icons. To be honest, I'd sooner not have the icon clutter.

I don't want to edit the windows_open_with.json file in case I break something that works.

Happy New Year to all.

BR

[kovidgoyal]

yes, this error was introduced in the previous release will be fixed in the next one.

[Comfy.n]

Originally Posted by BetterRed

If I try to add an item to, or edit, the PDF Open With list, viz :

Attachment 198700

off-topic:

Xchange Viewer had always been my default PDF program, until it was superseded by Xchange Editor, which has a nicer rendering of text-based PDFs.

Curiously, yesterday I had to use it again, as I wanted to test its OCR with an image-based PDF.

What I found was very surprising: while ABBYY Fine reader, despite its many features, can't simply put a text layer under an image-based PDF without altering the images quality, Xchange Viewer not only is able to make an accurate OCR, but it will also allow to just save the text layer without touching the PDF images.

I've also tried Xchange Editor, but it added some blur to the OCR'ed PDF...

Happy New Year

[Quoth]

Is this related to nothing at all happening when right click on a cover, Edit, which suggests The GIMP will be used? Linux Mint 20.1
That used to work.

[ownedbycats]

@kovidgoyal: Is this related to the regresion I found with Open With icons?

[BetterRed]

Originally Posted by kovidgoyal

yes, this error was introduced in the previous release will be fixed in the next one.

Thanks

Had an hunch it might be a known regression, but when I checked on GIT the commit was hiding in plain sight, right after the 6.10 change log commit ==>> https://github.com/kovidgoyal/calibr...ee225869d085ff

Have a safe and prosperous 2023 everyone.

BR