Subsetting fonts problem when using pseudo-classes

jackie_w · 09-24-2022, 01:28 PM

I was hoping to use existing code from calibre.ebooks.oeb.polish.subset, specifically subset_all_fonts, to build some extra functionality into one of my personal plugins.

The problem I'm seeing is that text which will be displayed by a CSS rule such as:

Code:

.tx1::first-line {font-family: MySmallcapsFont;}

doesn't seem to be taken into account when the existing subsetting code is deciding which characters need to be retained in the MySmallcapsFont font. In the worst-case scenario, if the above CSS rule was the only one referencing MySmallcapsFont then currently this font would be completely removed from the container.

I do understand that calibre has no idea which/how many characters will appear on the first-line but I wonder if it's possible to have some sort of compromise, i.e. keep all characters used by class="tx1", i.e. the main part of the selector. Just a personal opinion but I'd rather keep too many than too few.

If this is a non-starter then I'll just have to live with it, but if it's something you'd consider fixing/improving I'm happy to open a bug report with a sample epub.

kovidgoyal · 09-25-2022, 12:21 AM

Sure, sounds reasonable. Go ahead and open the bug report.

jackie_w · 09-25-2022, 09:33 AM

Quote:

Originally Posted by kovidgoyal

Sure, sounds reasonable. Go ahead and open the bug report.

Thanks. Opened here.

jackie_w · 09-28-2022, 07:41 PM

Many thanks for fixing this.

kovidgoyal · 09-29-2022, 12:36 AM

You are welcome

09-24-2022, 01:28 PM	#1
jackie_w Grand Sorcerer Posts: 6,269 Karma: 16544702 Join Date: Sep 2009 Location: UK Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3	Subsetting fonts problem when using pseudo-classes I was hoping to use existing code from calibre.ebooks.oeb.polish.subset, specifically subset_all_fonts, to build some extra functionality into one of my personal plugins. The problem I'm seeing is that text which will be displayed by a CSS rule such as: Code: .tx1::first-line {font-family: MySmallcapsFont;} doesn't seem to be taken into account when the existing subsetting code is deciding which characters need to be retained in the MySmallcapsFont font. In the worst-case scenario, if the above CSS rule was the only one referencing MySmallcapsFont then currently this font would be completely removed from the container. I do understand that calibre has no idea which/how many characters will appear on the first-line but I wonder if it's possible to have some sort of compromise, i.e. keep all characters used by class="tx1", i.e. the main part of the selector. Just a personal opinion but I'd rather keep too many than too few. If this is a non-starter then I'll just have to live with it, but if it's something you'd consider fixing/improving I'm happy to open a bug report with a sample epub.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Pseudo classes to be deleted as unused classes	Leonatus	Sigil	2	09-23-2018 10:12 AM
Darkening and subsetting fonts	roger64	Workshop	54	05-03-2018 03:29 AM
Pseudo classes with classes	Macsurfcat	ePub	4	01-07-2016 05:00 AM
Problem with font subsetting	grumbles	Editor	17	06-20-2014 03:35 PM
Font subsetting problem	yktan	Calibre	5	09-20-2013 12:00 AM

09-25-2022, 12:21 AM	#2
kovidgoyal creator of calibre Posts: 45,617 Karma: 28549044 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Sure, sounds reasonable. Go ahead and open the bug report.

09-28-2022, 07:41 PM	#4
jackie_w Grand Sorcerer Posts: 6,269 Karma: 16544702 Join Date: Sep 2009 Location: UK Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3	Many thanks for fixing this.

09-29-2022, 12:36 AM	#5
kovidgoyal creator of calibre Posts: 45,617 Karma: 28549044 Join Date: Oct 2006 Location: Mumbai, India Device: Various	You are welcome

Advert

Advert