PageEdit-1.9.10 Released

[DiapDealer]

PageEdit-1.9.10

PageEdit-1.9.10 is a minor update that represents 3 bug fixes and a single new feature.


New Features:

• support building with Qt6
• make Qt6 versions use their own ini file for settings
• add Ctrl+PgUp/PgDown shortcuts to Prev and Next actions

Bug Fixes:

• harden URLInterceptor to dead QWidget bugs in Qt
• setMovable true on QToolbars to work around broken linux theme issues
• update sigil gumbo version with upstream fixes

--------------------------------- Notes -----------------------------------

The PageEdit user guide has been updated and can always be downloaded from its own repository.


The binary downloads (and source) can be found as assets at the bottom of the PageEdit Github Release page.

[DiapDealer]

Post reserved for future use.

[RbnJrg]

I want to build PageEdit 1.9.10 with qt6 but the program is built with qt5 (of course, I have installed qt6 in my Arch). I tried to compile PageEdit with:

/usr/lib/qt6/bin/qt-cmake "Unix Makefiles" -DINSTALL_BUNDLED_DICTS=0 -DCMAKE_BUILD_TYPE=Release ../pageedit-src

but no case, is compiled with qt5:



By the way, how do I set PageEdit in "dark mode" (Arch)? The option "File/Preferences.../Appearence/Make PageEdit simulate a dark appearence in dark mode" seems not to work.

[KevinH]

Just like with the Sigil build process add this to your cmake command:

-DUSE_QT6=1

And I believe there is a

FORCE_PAGEEDIT_DARKMODE_PALETTE

And if a epub sets its own colours they will overrde the simulated darkmode setting.

[DiapDealer]

Yes the "simulate appearance setting" will only try to affect the background/text color (much like the setting for Preview in Sigil). It is separate from the dark mode for the application itself. But the application must be set to dark mode before that PageEdit setting will have any effect.

[RbnJrg]

Thanks Kevin; two things:

One: PageEdit with Qt6 compiles but it doesn't work; when I compiled it with Qt5 it works as is expected.

Two: no case, even with the statement FORCE_PAGEEDIT_DARKMODE_PALETTE=1 in the enviroment variables, I can't enable dark mode on my Arch. Or I need to do another thing more or dark mode is not working under Linux (by the way, in Windows I don't have any issue -with the Windows version of course-).

Originally Posted by KevinH

Just like with the Sigil build process add this to your cmake command:

-DUSE_QT6=1

And I believe there is a

FORCE_PAGEEDIT_DARKMODE_PALETTE

And if a epub sets its own colours they will overrde the simulated darkmode setting.

[KevinH]

Please define "doesn't work"? Does it crash? What if any error messages are given? I just tried Qt6 PageEdit on macOS and it all works just fine.

Originally Posted by RbnJrg

Thanks Kevin; two things:

One: PageEdit with Qt6 compiles but it doesn't work; when I compiled it with Qt5 it works as is expected.

Two: no case, even with the statement FORCE_PAGEEDIT_DARKMODE_PALETTE=1 in the enviroment variables, I can't enable dark mode on my Arch. Or I need to do another thing more or dark mode is not working under Linux (by the way, in Windows I don't have any issue -with the Windows version of course-).

[DiapDealer]

PageEdit Qt6 has not been tested as nearly as heavily as Sigil Qt6 (at least on Linux and Windows). That's probably on me. But then we've not declared Qt6 versions of either PageEdit or Sigil production-ready quite yet, either.

But if you're satisfied with Sigil Qt6 (and it's really close to being declared production-ready IMO) , there's no real reason you need to build PageEdit with Qt6 to match. PageEdit Qt5 will happily integrate with Sigil Qt6.

[KevinH]

FWIW - I just built PageEdit using QT6 on my Manjaro Linux box following the build instructions and it launches just fine.

Edit:

But will ends up with empty qwebengine pages no matter what I load.

So there does appear to be a problem

[KevinH]

Okay, it seems in WebPageEdit.cpp there is a linux specific background hack for Qt 5.14 that needs to be restricted to Qt5 as it breaks Qt6 versions of PageEdit.

I just pushed a fix for this to PageEdit master.

So now Qt6 versions of PageEdit from master launch and run fine on my Manjaro box but there is still issues with forcing dark mode on Linux that I have not tracked down yet.

[RbnJrg]

Originally Posted by KevinH

Please define "doesn't work"? Does it crash? What if any error messages are given? I just tried Qt6 PageEdit on macOS and it all works just fine.

Well, what you wrote:

But will ends up with empty qwebengine pages no matter what I load.

PageEdit starts but you can't load anything.

[RbnJrg]

Originally Posted by DiapDealer

But if you're satisfied with Sigil Qt5 (and it's really close to being declared production-ready IMO) , there's no real reason you need to build PageEdit with Qt6 to match. PageEdit Qt5 will happily integrate with Sigil Qt6.

I wanted to build PageEdit with Qt6 because I can't set Qt5 version in dark mode; dark mode doesn't work under linux.

[KevinH]

Yes, I am seeing the same thing under both Qt5 and Qt6 in Linux. In Qt6 the file dialogs are properly in dark mode but the main window is not. In Qt5 is appears to be broken as well. I will look into it this afternoon if DiapDealer does not beat me to it.

[DiapDealer]

Hmmm. There was something on Sigil I had to keep going back and forth on to keep dark mode working correctly on newer versions of Qt. Perhaps I missed a forth (or a back) on PageEdit.

[DiapDealer]

We need a Qt check similar to:

https://github.com/Sigil-Ebook/Sigil.../main.cpp#L488

in PageEdit's main at https://github.com/Sigil-Ebook/PageE.../main.cpp#L299

My bad.

Just comment out line 299 in PageEdit's main.cpp if you want to test before I get around to testing and pushing.