The Hindu stopped working

[unkn0wn]

https://github.com/kovidgoyal/calibr...s/hindu.recipe

in line 80

div = soup.find('section', attrs={'id': 'section_'})

change it to

div = soup.find('section', attrs={'id': 'section_1'})

I changed it to _1 and it fetches article links from each section

It loads the whole article text but it doesn't load images like before! looks like they changed that part too.

This is the present code to fetch images (line 49)

def preprocess_html(self, soup):
        img = soup.find('img', attrs={'class': 'lead-img'})
        try:
            for i, source in enumerate(tuple(img.parent.findAll('source', srcset=True))):
                if i == 0:
                    img['src'] = source['srcset'].split()[0]
                source.extract()
        except Exception:
            pass

and this is where the image is

<img class="lead-img" src="https://www.thehindu.com/todays-paper/1cezy4/article65041871.ece/alternates/FREE_660/First-ever-wate%2BGSE9G8VFI.3.jpg.jpg" 
data-src-template="https://www.thehindu.com/todays-paper/1cezy4/article65041871.ece/alternates/FREE_660/First-ever-wate%2BGSE9G8VFI.3.jpg.jpg" 
data-original="https://www.thehindu.com/todays-paper/1cezy4/article65041871.ece/alternates/FREE_660/First-ever-wate%2BGSE9G8VFI.3.jpg.jpg" 
alt="Winged visitors making a splash at a lake in city.NAGARA GOPAL" 
title="Winged visitors making a splash at a lake in city.NAGARA GOPAL" 
data-device-variant="FREE~FREE~FREE~FREE" 
 width="100%" height="100%">

I changed srcset with data-original but it isn't working. Its a bit complex for me.

[kovidgoyal]

https://github.com/kovidgoyal/calibr...9f096f09dc29f5

[unkn0wn]

images weirdly take up the whole page when reading on calibre ebook viewer. I've "object-fit: scale-down;" images so text should've adjusted around it, instead it takes up whole page even for smaller images.


Is there a short fix to this?

this is from ebook viewer's element inspector.

<img alt="Bitter pill?Punjab Congress chief Navjot Singh Sidhu campaigning in Amritsar on Wednesday.PTI-"
 class="lead-img" 
data-device-variant="FREE~FREE~FREE~FREE" 
data-original="https://www.thehindu.com/todays-paper/tp-national/7cq5pp/article65057516.ece/alternates/FREE_660/TH15-SANDEEP-Co%2BGHV9GLCQO.3.jpg.jpg" 
data-src-template="https://www.thehindu.com/todays-paper/tp-national/7cq5pp/article65057516.ece/alternates/FREE_660/TH15-SANDEEP-Co%2BGHV9GLCQO.3.jpg.jpg" 
src="images/img1_u17.jpg" 
title="Bitter pill?Punjab Congress chief Navjot Singh Sidhu campaigning in Amritsar on Wednesday.PTI-" 
data-calibre-src="feed_1/article_4/images/img1_u17.jpg" 
data-75fb396ca421354d3e6a262d-img-data="{&quot;left&quot;:438,&quot;right&quot;:846,&quot;height&quot;:723,&quot;display&quot;:&quot;&quot;}" 
style="break-inside: avoid;">

[kovidgoyal]

Look at the styles view in the inspector and see where the css causing it is coming from

[unkn0wn]

.lead-img {
    height: 100%;
    width: 100%;
    }

okay, lead-img height is set to 100%, if I remove this height, it works normally.

[kovidgoyal]

so add

.lead-img { height: auto !important }

to extra_css in the recipe and it should befine.

[kovidgoyal]

https://github.com/kovidgoyal/calibr...3d5e43303a6600

[unkn0wn]

Arre.. i just learned of this.. added remove attributes 'height' to the recipe, it worked.

and you already posted these changes.

thanks.