PageEdit-1.6.0 Released

[DiapDealer]

PageEdit-1.6.0

PageEdit-1.6.0 is a minor update that represents 3 bug fixes and a single new feature.

New Features:

• Added ability for spine position to be passed in alongside OPF path to simplify the interface between Sigil and PageEdit (with versions 1.6.0+)

Bug Fixes:

• Bring SelectCharacter Dialog to be in sync with its counterpart in Sigil
• Remove tab and disable InsertFile menu if not Media is present to insert
• Fix typo in Greek Letter (Nu) (Thank you Doitsu).

--------------------------------- Notes -----------------------------------

The PageEdit user guide has been updated and can always be downloaded from its own repository.

Mac users should also check out the wiki entry on the New Release File Format

The binary downloads (and source) can be found as assets at the bottom of The PageEdit Github Release page.

[DiapDealer]

Post reserved for future use.

[un_pogaz]

[bug]
When you create a hyperlink to a web address (via the dialog box), PageEdit creates this <a href="../http://www.creepypasta.com/call-me-tomorrow-okay">
Element that may have an influence : The XHTML page is in a subfolder, displayed "12/Section32.xhtml" in the dropdown menu of the loaded elements.

[DiapDealer]

Originally Posted by un_pogaz

[bug]
When you create a hyperlink to a web address (via the dialog box), PageEdit creates this <a href="../http://www.creepypasta.com/call-me-tomorrow-okay">
Element that may have an influence : The XHTML page is in a subfolder, displayed "12/Section32.xhtml" in the dropdown menu of the loaded elements.

Can confirm. Folders other than /OEBPS/Text/ seem to cause issues.

[KevinH]

Most of that link code is copy-pasted directly from Sigil source. Does Sigil display the same bug?

[DiapDealer]

Originally Posted by KevinH

Does Sigil display the same bug?

No. It doesn't seem to.

Also note that PageEdit includes the following as an available target in the Insert Link dialog when in dark mode:

Targets in Book    | Text               
#PageEdit_Injected :root { background-color: #2a2a2a; color: #eeeee

[KevinH]

Hmm ... I am seeing the following:

1. I took and epub in Sigil, fired up PageEdit using the external editor button.

2. Selected some text that will become the link text

3. Hit the chain link icon to create the link

4. Did not select anything in the table and instead in the target I typed:

https://www.mobilreread.com

and it worked but if I instead type:

https://www.mobileread.com/forums

I get a dialog message that you can not insert a link at this point. So literally external links are not being properly handled.
I will look into it.

[KevinH]

Yes I see the same thing with the injected root id for dark mode
which we added to make sure we remove anything injected properly and uniquely otherwise it will become permanent when leaving PageEdit.

[DiapDealer]

Ahh... makes sense.

[KevinH]

Okay, I pushed a fix for this to PageEdit master that will now make it handle any and all external links (any non-relative target - ie. has ':' ) as special cases and therefore not try to build a relative link from the source.

Tested it with https://www.mobileread.com/forums and once PageEdit was in preview mode, the link worked just fine. Triple checked with the Inspector and it should now work.

I still have to screen out #PageEdit_Injected from the SelectHyperlink dialog building.

[KevinH]

Okay, modified to SeletHyperlink to skip PageEdit_Injected ids when making the table of possible targets.

Pushed it to master.

So we should be good to go here.

Thank you for your bug report!