RuntimeError:wrapped C/C++ object of type QAction has been deleted

[dgparryuk]

getting this error, everytime i try and change between libraries

RuntimeError:wrapped C/C++ object of type QAction has been deleted

Spoiler:

calibre, version 4.8.0
ERROR: Unhandled exception: <b>RuntimeError</b>:wrapped C/C++ object of type QAction has been deleted

calibre 4.8 [64bit] embedded-python: True is64bit: True
Windows-7-6.1.7601-SP1 Windows ('64bit', 'WindowsPE')
('Windows', '7', '6.1.7601')
Python 2.7.16+
Windows: ('7', '6.1.7601', 'SP1', u'Multiprocessor Free')
Interface language: en_GB
Successfully initialized third party plugins: Modify ePub (1, 4, 0) && Manage Series (1, 2, 9) && Kobo Utilities (2, 9, 0) && Barnes & Noble (1, 2, 15) && EpubSplit (2, 8, 0) && Find Duplicates (1, 6, 3) && EpubMerge (2, 8, 0) && Clean Metadata (0, 0, 6) && Biblionet_gr (1, 1, 0) && Author Book Count (2, 1, 9) && Count Pages (1, 9, 0) && KindleUnpack - The Plugin (0, 82, 1) && Kobo Books (1, 8, 0) && OPML Importer (1, 0, 1) && EpubCheck (0, 2, 2) && Search The Internet (1, 7, 6) && Fantastic Fiction Adults (1, 1, 0) && Fantastic Fiction (1, 3, 0) && KoboTouchExtended (3, 1, 5) && Anobii Fetcher (1, 1, 0) && Reading List (1, 6, 7) && Quality Check (1, 9, 11) && ADLIBRIS_NO (0, 0, 10) && Beam Ebooks (1, 0, 0) && FictionDB (1, 2, 0) && Resize Cover (1, 0, 2) && Goodreads (1, 4, 0) && View Manager (1, 5, 4) && Open With (1, 5, 11) && Goodreads Sync (1, 13, 4)
Traceback (most recent call last):
File "site-packages\calibre\gui2\dialogs\choose_library.py", line 192, in accept
File "site-packages\calibre\gui2\dialogs\choose_library.py", line 133, in perform_action
File "site-packages\calibre\gui2\actions\choose_library.py", line 625, in choose_library_callback
File "site-packages\calibre\gui2\ui.py", line 759, in library_moved
File "calibre_plugins.open_with.action", line 58, in library_changed
File "calibre_plugins.open_with.action", line 76, in rebuild_menus
RuntimeError: wrapped C/C++ object of type QAction has been deleted

[BetterRed]

Try running with no plugins, at command line: calibre --ignore-plugins

BR

[kovidgoyal]

That's an error in the open with plugin. I sggest uninstalling it. calibre anyway has builtin open with functionality.

[davidfor]

Originally Posted by kovidgoyal

That's an error in the open with plugin. I sggest uninstalling it. calibre anyway has builtin open with functionality.

The plugin does a lot more as it has a menu of options for opening the books with appropriate parameters passed to the executable.

I'm also not able to reproduce the problem here with various versions of calibre. The code in question is:

        for action in self.menu_actions:
            self.gui.keyboard.unregister_shortcut(action.calibre_shortcut_unique_name)
            # starting in calibre 2.10.0, actions are registers at
            # the top gui level for OSX' benefit.
            if calibre_version >= (2,10,0):
                self.gui.removeAction(action)

"action" is a "QAction". The lines above are fairly common thing in the plugins. Which might just means we copied from a common source and it isn't really needed. But, I can see it in several places in calibre.

The OP has three other plugins installed that use the above. And they should be called when the library changes. Is this something we shouldn't be doing then?

[kovidgoyal]

What's that code supposed to be doing?? Why does open with need to rebuild menus on library change? A minimal change to avoid the exception would be to add

try:
    from PyQt5 import sip
except ImportError:
    import sip
if sip.isdeleted(action):
   continue

[davidfor]

Originally Posted by kovidgoyal

What's that code supposed to be doing?? Why does open with need to rebuild menus on library change?

Looking at the code, it doesn't need to. I have made a change to the plugin to not do it and asked @BR to updated it.

I'll have to look at the other plugins that do this. Some might be using the library specific options to build the menu.

A minimal change to avoid the exception would be to add

try:
    from PyQt5 import sip
except ImportError:
    import sip
if sip.isdeleted(action):
   continue

I'll keep that in mind. But, my plan was just to wrap a try block around it and ignore the exception.

@dgparryuk: The updates should be available later. When calibre announces it, install it and it should fix things.

[dgparryuk]

amazing, will check later on and update and will pop back and let you all know :-)

[BetterRed]

New Open With should be available now

BR

[dgparryuk]

and that's fixed it :-)

cheers all :-)

[JSWolf]

Originally Posted by dgparryuk

and that's fixed it :-)

cheers all :-)

To make sure all is working, you should update from 4.8 to 4.9.1.