Doubled tabs for media files

brolny · 02-22-2018, 02:42 AM

On double clicking on audio (in Book Browser), the file is opened each time in a new tab, not in the previously opened one.

KevinH · 02-22-2018, 08:21 AM

I will take a look at this and try to see why the proper existing tab is not brought to the front.

KevinH · 02-22-2018, 09:20 AM

From eyeballing the code, the bug was in TabManager:SwitchedToExistingTab as it is missing the case of Audio/Video AVTabs so it always said the tab was not existing.

The fix will appear in the next release of Sigil.

Thank you for your bug report!

DiapDealer · 02-22-2018, 09:22 AM

To be honest, is there really even a need for media files to open in their own central tabs (Book View or Code View) at all? It's not as if Sigil can edit them.

I don't know how feasible it is to stop a particular resource from opening tabs of their own, but surely the Book View/Code View/Preview tab of the HTML Resource they're embedded in would be sufficient, no?

KevinH · 02-22-2018, 03:00 PM

If opened in its own tab you can use open with to edit the audio or video with your favorite movie or sound editor.

DiapDealer · 02-22-2018, 03:27 PM

I thought the Open With feature worked from the context-menu in Book Browser?

Regardless, it makes a bit more sense to me now. A user may want to preview media sources they've added to their epub before they've embedded them in any of the html. Images and everything else work that way, so there's no sense in reinventing the wheel, I guess.

Thanks for eliminating the bug!

KevinH · 02-23-2018, 10:03 AM

Just pushed the fix to master.

02-22-2018, 02:42 AM	#1
brolny Connoisseur Posts: 64 Karma: 10 Join Date: Sep 2015 Location: Yerevan, Armenia Device: none	Doubled tabs for media files On double clicking on audio (in Book Browser), the file is opened each time in a new tab, not in the previously opened one. Attached Thumbnails Last edited by brolny; 02-22-2018 at 02:57 AM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Wondering out-loud - Calibre and multi-media files	Mark Lee	Library Management	5	07-20-2017 12:03 PM
Building a comprehensive media PC to share media (Mylar, Plex, Calibre, Sickbeard)	Ackis	Devices	1	04-07-2014 06:43 PM
Good management tool as powerful as calibre but for media files?	kevin.cooper	General Discussions	6	03-01-2014 09:05 PM
iPad More People Recognizing That Media iPad Adaptations Feel Like CD-ROM Media	kjk	Apple Devices	1	06-14-2010 06:26 PM
Media files in feeds?	Fhnuzoag	Calibre	1	04-17-2009 09:46 AM

02-22-2018, 08:21 AM	#2
KevinH Sigil Developer Posts: 8,495 Karma: 5703586 Join Date: Nov 2009 Device: many	I will take a look at this and try to see why the proper existing tab is not brought to the front.

02-22-2018, 09:20 AM	#3
KevinH Sigil Developer Posts: 8,495 Karma: 5703586 Join Date: Nov 2009 Device: many	From eyeballing the code, the bug was in TabManager:SwitchedToExistingTab as it is missing the case of Audio/Video AVTabs so it always said the tab was not existing. The fix will appear in the next release of Sigil. Thank you for your bug report!

02-22-2018, 09:22 AM	#4
DiapDealer Grand Sorcerer Posts: 28,375 Karma: 203720150 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	To be honest, is there really even a need for media files to open in their own central tabs (Book View or Code View) at all? It's not as if Sigil can edit them. I don't know how feasible it is to stop a particular resource from opening tabs of their own, but surely the Book View/Code View/Preview tab of the HTML Resource they're embedded in would be sufficient, no?

02-22-2018, 03:00 PM	#5
KevinH Sigil Developer Posts: 8,495 Karma: 5703586 Join Date: Nov 2009 Device: many	If opened in its own tab you can use open with to edit the audio or video with your favorite movie or sound editor.

02-22-2018, 03:27 PM	#6
DiapDealer Grand Sorcerer Posts: 28,375 Karma: 203720150 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	I thought the Open With feature worked from the context-menu in Book Browser? Regardless, it makes a bit more sense to me now. A user may want to preview media sources they've added to their epub before they've embedded them in any of the html. Images and everything else work that way, so there's no sense in reinventing the wheel, I guess. Thanks for eliminating the bug!

02-23-2018, 10:03 AM	#7
KevinH Sigil Developer Posts: 8,495 Karma: 5703586 Join Date: Nov 2009 Device: many	Just pushed the fix to master.

Advert

Advert