Double click in Quick view

[Katja_hbg]

It seems calibre freeze doing the following
Open a search e.g. books from today
Open quickview e.g. book with same author
Double click on an entry in quickview which is not part of the search result as it is same author but not from today

Expectation is a dialog like cannot jump to that book
Currently calibre freeze

[chaley]

Originally Posted by Katja_hbg

It seems calibre freeze doing the following
Open a search e.g. books from today
Open quickview e.g. book with same author
Double click on an entry in quickview which is not part of the search result as it is same author but not from today

Expectation is a dialog like cannot jump to that book
Currently calibre freeze

What version of calibre are you running? I ask because in the situation you describe calibre 3.4 gives shows me an "exception" error dialog. I will change QV to show a more human-friendly error.

I cannot reproduce calibre freezing.

[Katja_hbg]

Version 3.4
I do not get any message, only screen freezing.

Just try to repeat and. ;-) see the error dialog as my QV window is docked today.
Yesterday the eror message was hidden behind the not docked and big QV and therefore not visible and also QV window could not be closed.
Now as I know there is a error message I can use keyboard to close it.

So beside a bit nicer text, more important is to keep the error dialog on top.

[chaley]

Originally Posted by Katja_hbg

So beside a bit nicer text, more important is to keep the error dialog on top.

Thanks for the precision. Before the error window was on top of the calibre window. After my change the error window is on top of the quickview window, which is the calibre window when docked and the QV window when undocked.

[Katja_hbg]

thanks for the fix and nice text, that was realy quick and well done, chaley.

I like to ask an other question for same QV dialog. It is regarding the flag to block the content.
Cursor is on an author and result is shown proper in the QV.
Now I check the flag to block the content (sorry I have only the german description. It is in the dialog left beside dock/undock).
Next I select an other author on the calibre window.
My expectation from the field description is, that the content in QV does not changes but it is now adjusted to the new author.
Do I missunderstand this flag?

[chaley]

Originally Posted by Katja_hbg

thanks for the fix and nice text, that was realy quick and well done, chaley.

I like to ask an other question for same QV dialog. It is regarding the flag to block the content.
Cursor is on an author and result is shown proper in the QV.
Now I check the flag to block the content (sorry I have only the german description. It is in the dialog left beside dock/undock).
Next I select an other author on the calibre window.
My expectation from the field description is, that the content in QV does not changes but it is now adjusted to the new author.
Do I missunderstand this flag?

No, you do not misunderstand the flag.

I broke it when I added the extra columns. There is an "ambiguity" about what to do when preferences (which columns) are changed vs when book data is changed. I resolved that ambiguity by changing the book data in both cases. This is clearly the wrong choice, because that also changes the quickview (QV) window when the *book* changes, thus ignoring the flag.

I have a fix that I want to test more tomorrow before I submit it. After applying the fix, changes both to which book is selected and the metadata for a single book will not be shown in QV. In other words, if QV is locked and you change the series for a book, QV will still show the old series. If QV is locked then changing the selected book will not change the QV screen. I don't think this is ideal -- I would like that the first case to change the line in QV but that the second case to do nothing -- but that is hard given how QV is implemented.

[BetterRed]

Originally Posted by chaley

If QV is locked then changing the selected book will not change the QV screen. I don't think this is ideal -- I would like that the first case to change the line in QV but that the second case to do nothing -- but that is hard given how QV is implemented.

Would it be possible to implement a user initiated Refresh in QV to 'cover' the first case. Apologies if it's already there, I don't have a recent QV to hand.

BR

[chaley]

Originally Posted by BetterRed

Would it be possible to implement a user initiated Refresh in QV to 'cover' the first case. Apologies if it's already there, I don't have a recent QV to hand.

BR

The "implementation problems" I mentioned make this hard to do correctly. QV isn't prepared to have values change in books without also (possibly) changing the values in the left pane.

Given that one can uncheck the box, click on the a book to update QV, then recheck the box; I am not ready to risk breaking things even more.

[chaley]

Originally Posted by BetterRed

Would it be possible to implement a user initiated Refresh in QV to 'cover' the first case. Apologies if it's already there, I don't have a recent QV to hand.

BR

Originally Posted by chaley

The "implementation problems" I mentioned make this hard to do correctly. QV isn't prepared to have values change in books without also (possibly) changing the values in the left pane.

Given that one can uncheck the box, click on the a book to update QV, then recheck the box; I am not ready to risk breaking things even more.

However ...

What I can do is provide a "Refresh" button/shortcut that refreshes the QV pane using the last selected book and column even if the locked box is checked. where "last selected" means the last one that caused the QV information to change. If the book's data in the that column has changed then that change will be taken into account during the refresh. This will give you an up-to-date QV pane without needing to find and click the original book.

This implementation gives usable form of refresh without breaking the internal QV constraints. The data in QV's left pane will still be consistent with the data in QV's book list.

There is no default shortcut for this Refresh function. I don't think it is used enough to steal yet another key sequence.

[BetterRed]

Originally Posted by chaley

However ...

What I can do is provide a "Refresh" button/shortcut that refreshes the QV pane using the last selected book and column even if the locked box is checked. where "last selected" means the last one that caused the QV information to change. If the book's data in the that column has changed then that change will be taken into account during the refresh. This will give you an up-to-date QV pane without needing to find and click the original book.

This implementation gives usable form of refresh without breaking the internal QV constraints. The data in QV's left pane will still be consistent with the data in QV's book list.

There is no default shortcut for this Refresh function. I don't think it is used enough to steal yet another key sequence.

I think this is what I had in mind - a button in the QV panel the user can click as and when he/she needs to.

Assuming it would be a sibling of the Lock, Dock, Search and Close buttons why couldn't it too have an accelerator key, as in Refresh. I'm looking at 3.4.

Added: what I wrote in post #7 was more of a suggestion to help with your dilemma, rather than a change request.

BR

[chaley]

Originally Posted by BetterRed

I think this is what I had in mind - a button in the QV panel the user can click as and when he/she needs to.

Assuming it would be a sibling of the Lock, Dock, Search and Close buttons why couldn't it too have an accelerator key, as in Refresh. I'm looking at 3.4.

BR

It does have an accelerator when the pane is undocked. When the pane is docked then all the accelerators are replaced with shortcuts, assuming the shortcuts are defined.

Also, the Refresh button is enabled only when QV is locked. The function doesn't do anything useful if QV isn't locked because all changes are reflected as they are made.

[BetterRed]

Originally Posted by chaley

It does have an accelerator when the pane is undocked. When the pane is docked then all the accelerators are replaced with shortcuts, assuming the shortcuts are defined.

Also, the Refresh button is enabled only when QV is locked. The function doesn't do anything useful if QV isn't locked because all changes are reflected as they are made.

Tricky stuff - didn't appreciate that.

I don't dock it because I have the book details at the bottom, if I show both I don't see enough of the book list. I have a gadget that allows me to minimise non modal dialogues like QV to a screen or tray icon if they get in the way, QED:



BR

[chaley]

You can use the fixes/changes now if you run calibre from source.