Flight Crew ValidateEpub method

[davidnwelton]

Hi,

Anyone know what is going on here? This is in ValidateEpub.cpp:

   try
    {
        throw(std::exception());
    }
    
    catch ( std::exception& exception )
    {
        results.push_back( Result( ERROR_EPUB_NOT_VALID_ZIP_ARCHIVE )
                           .SetCustomMessage( exception.what() ) );
        return results;
    }

If it's not implemented yet, perhaps that would be a better return/error message?

[Toxaris]

Probably checking if the ePUB is a valid ePUB. After all, it is an zip file. However, it must be created in a certain manner.

[davidnwelton]

Originally Posted by Toxaris

Probably checking if the ePUB is a valid ePUB. After all, it is an zip file. However, it must be created in a certain manner.

Well, as written, it's guaranteed to throw an exception and then an error, no matter what file you give it. Seems kind of odd.

[DiapDealer]

And yet epubs are validated without any errors all the time by the integrated Flightcrew. So we're missing something. As written... yes, there will be an exception and an error, but the snippet of code doesn't tell us when; under what circumstances; or even IF that code gets called.

[davidnwelton]

Originally Posted by DiapDealer

And yet epubs are validated without any errors all the time by the integrated Flightcrew. So we're missing something. As written... yes, there will be an exception and an error, but the snippet of code doesn't tell us when; under what circumstances; or even IF that code gets called.

No, that method does not get called from the integrated code. I read that, and it uses an already opened ePub directory via this method:

FC_WIN_DLL_API std::vector< Result > ValidateEpubRootFolder( const std::string &root_folder_path );

Which works great when I tested it myself. I'm just wondering what the story is with the other method.

I'm interested in this because I'd like to have a flight crew command line executable again, but don't know the code base very well, yet.

Thanks

[DiapDealer]

Which works great when I tested it myself. I'm just wondering what the story is with the other method.

Not sure. Could just be residual debugging stuff. Clearly there's no reason for the integrated Flightcrew to test the validity of a zip archive that already had to be successfully unzipped by Sigil before Flightcrew could be run ... so perhaps it was just a kludge left over from the transition from stand-alone program to integrated library.

[user_none]

The FlightCrew in Sigil and the FlightCrew as a standalone library are not in sync with one another. Sigil doesn't use that method because there is no reason to validate the archive because it was already validated by being opened.

What happened is I replaced zipios with minizip in Sigil. Since that method isn't used by Sigil I just removed the zipios functionality from the bundled FlightCrew. I never got around to changing FlightCrew to use minizip instead of zipios.

[user_none]

Just so it's clear that function actually works and is proper in the standalone FlightCrew source. It's only in Sigil that that function doesn't do anything.

[davidnwelton]

@user_none - thanks for taking the time to answer; it's appreciated. So I guess my next question is: which one should I be utilizing? I went with the Sigil one because I thought that was the latest and greatest, but perhaps it's pretty stable and I should just utilize this one?

https://code.google.com/p/flightcrew/

Thanks!

[crutledge]

Originally Posted by davidnwelton

@user_none - thanks for taking the time to answer; it's appreciated. So I guess my next question is: which one should I be utilizing? I went with the Sigil one because I thought that was the latest and greatest, but perhaps it's pretty stable and I should just utilize this one?

https://code.google.com/p/flightcrew/

Thanks!

the only prolem with this is that one cannot pass an ePub to it on the command line.

At least this is true on win7 pro with the 64bit version,

[PeterT]

Originally Posted by crutledge

the only prolem with this is that one cannot pass an ePub to it on the command line.

At least this is true on win7 pro with the 64bit version,

Huh?

Syntax for cli is 
Usage: flightcrew-cli [options] file...

D:\Downloads>"c:\Program Files\FlightCrew\FlightCrew-cli.exe" "The Pharaoh and the Priest.epub"
No problems found.

and this is using Windows 7, 64 bit and the current version (Windows (x64) build 0.7.2) of FlightCrew.

[theducks]

Originally Posted by crutledge

the only prolem with this is that one cannot pass an ePub to it on the command line.

At least this is true on win7 pro with the 64bit version,

That is true for XP also.
When did that get fixed? My Bug 26 is still open from 2011