Disabled Actions still called by Keyboard Shortcut?

[JimmXinu]

I borrowed some code from SendToDeviceAction to disable my plugins while on device view:

    def location_selected(self, loc):
        enabled = loc == 'library'
        self.qaction.setEnabled(enabled)

But in both my plugin and SendToDeviceAction, the Keyboard Shortcut key still triggered it.

IE, I can select a book in the library, switch to the device view--'Send to Device' on my toolbar is now disabled--and hit 'D' and calibre will send the book from the library to the device.

Is it supposed to work that way? I would expect disabled actions to not work from Keyboard Shortcut either.

[kovidgoyal]

It will only work if the qaction is the "shortcut_action". IIRC, by default, the qaction is not the shortcut_action, it is self.menuless_qaction, disabling that in addition to self.qaction should disable the keyboard shortcut. see the create_action() method in actions/__init__.py for details.

[JimmXinu]

Disabling self.menuless_qaction too does fix the problem. I've changed my code to:

    # disable when not in library. (main,carda,cardb)
    def location_selected(self, loc):
        enabled = loc == 'library'
        self.qaction.setEnabled(enabled)
        self.menuless_qaction.setEnabled(enabled)

Thanks for pointing it out.

Does that suggest that some of calibre's built in actions need that change, too?

I see the same issue--disabled button, but keyboard shortcut works with on last selected library book with ConvertAction, SendToDeviceAction and EditMetadataAction.

And a quick grep finds 12 places gui2/actions/*.py using 'self.qaction.setEnabled(enabled)'.

[kovidgoyal]

The problem is larger than that. Users can assign keyboard shortcuts to all sorts of actions like all the entries in a qactions sub menu, some of those would also have to be disabled. So far I haven't had any complaints from users about this, so I'd rather not fix a theoretical problem.

[JimmXinu]

Fair enough. Thanks for your help.