Calling smarten_punctuation from edit book

[ShellShock]

Re: https://www.mobileread.com/forums/sho...d.php?t=230684.

I have enhanced ebook-polish to add a new command line parameter:

-s SMARTEN_PUNCTUATION_OPT, --smarten-punctuation-opt=SMARTEN_PUNCTUATION_OPT

SMARTEN_PUNCTUATION_OPT gets passed to smartyPants as the attr (the options which control which conversions are done). I have also added additional conversions (for space+hyphen to em-dash etc) to smartyPants.

This all works fine.

But I am not clear on exactly how edit-book can call my new smarten_punctuation_opt command (in ebooks\oeb\polish\main.py) with parameters:

So in gui2\tweak_book\ui.py I have

self.action_smarten_punctuation = reg(
    'smarten-punctuation.png', _('&Smarten punctuation'), partial(
        self.boss.polish, 'smarten_punctuation_opt', _('Smarten punctuation')), 'smarten-punctuation', (), _('Smarten punctuation'))

smarten_punctuation_opt is my new smarten punctuation in ebooks\oeb\polish\main.py:

if opts.smarten_punctuation_opt:
    rt(_('Smartening punctuation'))
    smarten_punctuation(ebook, opts.smarten_punctuation_opt, report)
    #smarten_punctuation(ebook, "H", report)
    report('')

(If I use the commented out line I get the "H" conversion, so I know this call works when the smarten_punctuation options are hard coded).

I need to able to set opts.smarten_punctuation_opt when I call this from edit-book (obviously edit book is also going to need a UI to specify the smarten punctuation options but I will worry about that later).

[kovidgoyal]

You need to modify tweak_polish().

[ShellShock]

Many thanks.

Am I right in thinking that edit book will be getting saved Find and Replace? If so, then another way to achieve a configurable smarten punctuation would be executing a previously saved Find & Replace, something like this:

The saved Find & Replace would need to include all the parameters in the Find and Replace GUI, including Mode, the files to be affected, case sensitivity etc, the action to be performed when executed (Find, Replace, Replace all etc).

The user could automatically execute the saved Find & Replace, without having to first load it into the Find and Replace dialog and execute it from there.

Multiple saved Find & Replaces could be chained together, or executed as children of a parent container.

The overall effect is that a single menu/button click would execute multiple, previously configured regexes. This would be a very powerful feature to enable the user to make a lot of bespoke, automated changes, and goes beyond what Sigil supports. It also solves the problem of the currently hard coded regexes in smartyPants.

Any thoughts on this?

[kovidgoyal]

There will be saved find replace. However, it wont store a list fo files to operate on, as that would make them useless across books. Instead you will have to specify the files when you run them.

[ShellShock]

I was thinking more that when you configure the find replace, you could choose the run-time target as, e.g.,

"Current file" - at run-time this would find and replace in whatever is the current file.
"All HTML files". At run-time this would find and replace in all HTML files in the current ebook.
"All CSS files". At run-time this would find and replace in all CSS files in the current ebook.
"All files". At run-time this would find and replace in all files in the current ebook.
etc

And you could also automatically execute the saved find replace when you load it.