Value for QSpinBox in calibre/src/calibre/gui2/metadata/config.py

[feuille]

Hello Kovid,

in calibre/src/calibre/gui2/metadata/config.py the max value for the number option (spin box) is not set:

class ConfigWidget(QWidget):
...
def create_widgets(self, opt):
        val = self.plugin.prefs[opt.name]
        if opt.type == 'number':
            c = QSpinBox if isinstance(opt.default, numbers.Integral) else QDoubleSpinBox
            widget = c(self)
            widget.setValue(val)

So the max value, that is visible in the generated config GUI, is set to the default value for QSpinBox (99), as indicated in the Qt docs (https://doc.qt.io/qtforpython-5/PySi.../QSpinBox.html).

Could you please add the statement:

            widget.setMaximum(val)

to let the user increase the default value?

Thanks!

[chaley]

The best way to make something like this happen is to do it yourself in a forked source repo, test it, then submit a PR to Kovid. That process permits detailed discussion, keeps a trace of who did what, and as a side benefit runs the unit tests.

I do this by using a forked repo on github then a checked-out repo on my local machine. I pull all changes into the github fork, pull changes to the local repo, do the work, push the changes back, then submit the PR from github.

[kovidgoyal]

https://github.com/kovidgoyal/calibr...b5d817b2c60415

[feuille]

Originally Posted by kovidgoyal

https://github.com/kovidgoyal/calibr...b5d817b2c60415

Thanks, Kovid, for the quick (and certainly better) solution!