Custom identifier: User error?

ownedbycats · 01-17-2023, 07:35 PM

Created this identifier:

Key: googleplay
Name: Google Play
Template: https://play.google.com/store/books/details?id={id}

Pasting in https://play.google.com/store/books/details?id=AAAAAAA results in a URL identifier.

Entering googleplay:AAAAAAA works and leads to the correct link (though in this example, that's an error page).

Did I make a mistake, or is this a similar error to the resolved one with slashes?

kovidgoyal · 01-17-2023, 09:46 PM

This should fix it, though I havent tested it: https://github.com/kovidgoyal/calibr...5a01a5609ba2e9

ownedbycats · 01-17-2023, 10:05 PM

It works. Thank you.

Comfy.n · 01-18-2023, 02:04 AM

I can't see what the problem was, but I'm glad it's fixed, lol.

ownedbycats · 01-18-2023, 02:52 AM

I think the ?id= was tripping it up due to the question mark:

Code:

vals = {'id' : '(?P<new_id>.+)'}

kovidgoyal · 01-18-2023, 05:57 AM

Quote:

Originally Posted by Comfy.n

I can't see what the problem was, but I'm glad it's fixed, lol.

It used a regular expression based on the template. In OP's case the template contains a ? which is a special character in a regexp. So the fix is to escape all special characters in the template before converting it into a regex.

Comfy.n · 01-18-2023, 07:53 AM

Quote:

Originally Posted by kovidgoyal

It used a regular expression based on the template. In OP's case the template contains a ? which is a special character in a regexp. So the fix is to escape all special characters in the template before converting it into a regex.

oh, I see. Thanks.

I wasn't thinking templates. Since the clickable link on book details pane just works, this had me thinking what other use of the URL needed to be fixed

ownedbycats · 01-18-2023, 02:30 PM

I think it was just the 'paste URL' button using that bit of regex. Davidfor wrote that bit of code and he also forgot to account for slashes.

01-17-2023, 07:35 PM	#1
ownedbycats Custom User Title Posts: 10,986 Karma: 75337983 Join Date: Oct 2018 Location: Canada Device: Kobo Libra H2O, formerly Aura HD	Custom identifier: User error? Created this identifier: Key: googleplay Name: Google Play Template: https://play.google.com/store/books/details?id={id} Pasting in https://play.google.com/store/books/details?id=AAAAAAA results in a URL identifier. Entering googleplay:AAAAAAA works and leads to the correct link (though in this example, that's an error page). Did I make a mistake, or is this a similar error to the resolved one with slashes?

01-18-2023, 02:52 AM	#5
ownedbycats Custom User Title Posts: 10,986 Karma: 75337983 Join Date: Oct 2018 Location: Canada Device: Kobo Libra H2O, formerly Aura HD	I think the ?id= was tripping it up due to the question mark: Code: vals = {'id' : '(?P<new_id>.+)'} Last edited by ownedbycats; 01-18-2023 at 03:00 AM. Reason: typo

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Custom identifier: Is it possible to	ownedbycats	Library Management	3	12-06-2022 09:12 AM
Regex for a custom identifier breaking links	ownedbycats	Library Management	4	03-09-2021 12:29 AM
Identifier-like custom column	nqk	Library Management	5	05-20-2017 01:38 AM
Error: Namespace prefix opf for scheme on identifier is not defined	uwe4711	Conversion	4	09-26-2013 12:44 PM
Classic User Made Custom Daily Content	DaveNB	Barnes & Noble NOOK	9	12-14-2009 06:45 AM

01-17-2023, 09:46 PM	#2
kovidgoyal creator of calibre Posts: 45,364 Karma: 27230406 Join Date: Oct 2006 Location: Mumbai, India Device: Various	This should fix it, though I havent tested it: https://github.com/kovidgoyal/calibr...5a01a5609ba2e9

01-17-2023, 10:05 PM	#3
ownedbycats Custom User Title Posts: 10,986 Karma: 75337983 Join Date: Oct 2018 Location: Canada Device: Kobo Libra H2O, formerly Aura HD	It works. Thank you.

01-18-2023, 02:04 AM	#4
Comfy.n want to learn what I want Posts: 1,611 Karma: 7891011 Join Date: Sep 2020 Device: none	I can't see what the problem was, but I'm glad it's fixed, lol.

01-18-2023, 02:30 PM	#8
ownedbycats Custom User Title Posts: 10,986 Karma: 75337983 Join Date: Oct 2018 Location: Canada Device: Kobo Libra H2O, formerly Aura HD	I think it was just the 'paste URL' button using that bit of regex. Davidfor wrote that bit of code and he also forgot to account for slashes.

Advert

Advert