Please revert change to 4.21's editor

JSWolf · 07-31-2020, 01:32 PM

Edit book: In dark mode, make the preview panel also dark.
Closes tickets: 1888071

Please revert this. The white background for the preview is better as it's more like what we'll see. I don't read in night mode so being able to see the preview with a white background make it show up as it will when actually reading.

An option to change it to dark is OK as long as the default is white.

kovidgoyal · 07-31-2020, 01:49 PM

If you are going to be staring at a white background anyway, dont use dark mode, whats the point??

jackie_w · 07-31-2020, 01:50 PM

I can see why some users would like the option for the Preview screen to match the rest of the Editor when using dark mode but I've just been using v4.22 to edit an epub with a lot of footnotes and trying to read the default blue for anchor links on a dark background is very difficult.

My personal choice would be for an option to choose my own background colour for Preview, in the same way that I have a free choice of the background colour for the Code view.

ETA: If the CSS defines a background colour I'd expect that to override anything I'd set in Editor prefs.

kovidgoyal · 07-31-2020, 02:24 PM

Quote:

Originally Posted by jackie_w

ETA: If the CSS defines a background colour I'd expect that to override anything I'd set in Editor prefs.

There is no way to do that, and indeed you should not rely on it. If you set the colors for body/html they get overriden by the viewer as well. So it makes perfect sense for the editor preview to override them.

As for allowing the user to choose bg/fg, sure, someday when I have a moment.

jackie_w · 07-31-2020, 02:44 PM

Quote:

Originally Posted by kovidgoyal

There is no way to do that, and indeed you should not rely on it. If you set the colors for body/html they get overriden by the viewer as well. So it makes perfect sense for the editor preview to override them.

I didn't know that, but anyway fine by me. None of my books specify any colour for body or html.

Quote:

Originally Posted by kovidgoyal

As for allowing the user to choose bg/fg, sure, someday when I have a moment.

Should I open an enhancement ticket?

kovidgoyal · 07-31-2020, 03:04 PM

Quote:

Originally Posted by jackie_w

Should I open an enhancement ticket?

Yes, please do, I am totally swamped at the moment.

jackie_w · 07-31-2020, 03:41 PM

Quote:

Originally Posted by kovidgoyal

Yes, please do, I am totally swamped at the moment.

OK, done Enhancement #1889925

JSWolf · 07-31-2020, 03:52 PM

Can we at least have a code reversal until the enhancement is done?

nqk · 07-31-2020, 08:47 PM

Quote:

Originally Posted by jackie_w

ETA: If the CSS defines a background colour I'd expect that to override anything I'd set in Editor prefs.

Calibre viewer overrides a {color: xxx} in dark mode. But you can try filter to set brightness and invert, to make the selected elements look white.

Don't know if the Viewer/Editor supports Prefers-Color-Scheme.

jackie_w · 08-02-2020, 02:12 PM

Quote:

Originally Posted by kovidgoyal

Yes, please do, I am totally swamped at the moment.

Quote:

Originally Posted by jackie_w

OK, done Enhancement #1889925

@kovid,

Thanks for creating this enhancement so quickly. I look forward to using it in the next calibre release.

JSWolf · 08-02-2020, 03:24 PM

Thank you very much for the enhancement. I look forward to it.

kovidgoyal · 08-03-2020, 12:09 AM

You are welcome

shotsky · 08-04-2020, 09:28 AM

Quote:

Originally Posted by kovidgoyal

If you are going to be staring at a white background anyway, dont use dark mode, whats the point??

The preview should appear as the ebook appears. The code works better for me in dark mode. This worked previously, and only recently changed. Please restore the ability to have the preview pane in normal mode. I actually cannot read the preview pane because of the black background and dark blue text. And when there is a 'white' box in the preview, the text is a very light gray, and that can't be read either.

JSWolf · 08-04-2020, 10:56 AM

Quote:

Originally Posted by shotsky

The preview should appear as the ebook appears. The code works better for me in dark mode. This worked previously, and only recently changed. Please restore the ability to have the preview pane in normal mode. I actually cannot read the preview pane because of the black background and dark blue text. And when there is a 'white' box in the preview, the text is a very light gray, and that can't be read either.

You have something wrong with either your system of the eBook's CSS. The text is not supposed to be gray. It is supposed to be whitish. And as for the white box, that again is because of your eBook. There is no white box by default. The dark blue text are links and that can be overcome until the next Calibre with something like...

Code:

a {
  color: yellow;
}

Just remove that when you are finished editing your book.

thiago.eec · 08-04-2020, 02:11 PM

Quote:

Originally Posted by JSWolf

It is supposed to be whitish.

If the color of the text is defined on CSS, calibre Editor will not override it, doesn't matter if in Dark Mode or no.
Many books have colors set for text (and background in some cases). In this case, there might be CSS rules for white background and gray text.
A good way to avoid this problem is to use "color: inherit". This way, text will adapt from black to white when activating Dark Mode.

07-31-2020, 01:50 PM	#3
jackie_w Grand Sorcerer Posts: 6,269 Karma: 16544702 Join Date: Sep 2009 Location: UK Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3	I can see why some users would like the option for the Preview screen to match the rest of the Editor when using dark mode but I've just been using v4.22 to edit an epub with a lot of footnotes and trying to read the default blue for anchor links on a dark background is very difficult. My personal choice would be for an option to choose my own background colour for Preview, in the same way that I have a free choice of the background colour for the Code view. ETA: If the CSS defines a background colour I'd expect that to override anything I'd set in Editor prefs. Last edited by jackie_w; 07-31-2020 at 01:56 PM. Reason: ETA

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Revert 5.6.5 to 5.4.0 via serial	aholmes5	Kindle Developer's Corner	26	10-04-2015 09:32 AM
Published Date will not change in metadata editor.	M0rph3us	Calibre	5	05-24-2015 02:56 PM
Editor toolbar button change request?	bauerhjb	Editor	4	09-21-2014 07:04 PM
Is there a way to change the editor's background colour and syntax colouring?	nicciglen	Editor	3	01-15-2014 08:20 PM
How to change default text editor	Calyr Elf	Sigil	3	06-01-2012 01:02 PM

07-31-2020, 01:32 PM	#1
JSWolf Resident Curmudgeon Posts: 80,782 Karma: 150249619 Join Date: Nov 2006 Location: Roslindale, Massachusetts Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3	Please revert change to 4.21's editor Edit book: In dark mode, make the preview panel also dark. Closes tickets: 1888071 Please revert this. The white background for the preview is better as it's more like what we'll see. I don't read in night mode so being able to see the preview with a white background make it show up as it will when actually reading. An option to change it to dark is OK as long as the default is white.

07-31-2020, 01:49 PM	#2
kovidgoyal creator of calibre Posts: 45,609 Karma: 28549044 Join Date: Oct 2006 Location: Mumbai, India Device: Various	If you are going to be staring at a white background anyway, dont use dark mode, whats the point??

07-31-2020, 03:52 PM	#8
JSWolf Resident Curmudgeon Posts: 80,782 Karma: 150249619 Join Date: Nov 2006 Location: Roslindale, Massachusetts Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3	Can we at least have a code reversal until the enhancement is done?

08-02-2020, 03:24 PM	#11
JSWolf Resident Curmudgeon Posts: 80,782 Karma: 150249619 Join Date: Nov 2006 Location: Roslindale, Massachusetts Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3	Thank you very much for the enhancement. I look forward to it.

08-03-2020, 12:09 AM	#12
kovidgoyal creator of calibre Posts: 45,609 Karma: 28549044 Join Date: Oct 2006 Location: Mumbai, India Device: Various	You are welcome

Advert

Advert