Space after <br/> tag when prettifying.

[Vanguard3000]

Hey all,

Since Sigil 1.9, I've noticed that when prettifying code, a <br/> tag at the end of a line will combine onto one line as expected, but there will be a space after the tag.

For example:

<p>Space<br/>
The Final Frontier<br/>
These are the voyages of the starship Enterprise.</p>

Expected:

<p>Space<br/>The Final Frontier<br/>These are the voyages of the starship Enterprise.</p>

Actual:

<p>Space<br/> The Final Frontier<br/> These are the voyages of the starship Enterprise.</p>

Is there a reason for this change? Is it something I can adjust (short of reverting to an older Sigil version)? As it is when prettifying a new ebook I now have to do a find/replace to remove that space to satisfy my anal retentiveness.

Obviously it's not a killer problem or anything; I just preferred it when the space wasn't inserted, and am wondering if there's a way to make it not happen.

Thanks in advance for any info, and happy First Contact Day!

[KevinH]

Haven't touched that code in years.

And as far as I am concerned, that is no bug. That space is the converted new line after the <br/> in your example.

HTML converts new line into simple white space when not in pre. The prettifier does the same.


What older version of Sigil are you using that works the way you describe (no space added)?

[BeckyEbook]

@Vanguard3000:
The changed code appeared in Sigil version 0.9.2 in December 2015.

Indeed, prettifying your example produces spaces, but this happens naturally – by condensing white spaces, of which only one remains, just the one after the <br/> tag.

If Sigil were to prettify such a code:

<p>Test<br/>continuation</p>

to:

<p>Test<br/> continuation</p>

... You could think of it as inserting "unnecessary" space.

So you just need to remove these spaces yourself, and another prettifying will not break your code.

[Vanguard3000]

I wasn't reporting it as a bug, just wondering if it was something I could adjust, but it makes sense that it would be the correct behaviour for condensing whitespace. I reinstalled 1.7 to check and it works like this as well, so I must have misremembered it as being a new behaviour.

Anyway, thanks to you both for clarification!

[KevinH]

And of course, a quick find and replace all will make things as you like them.

[JSWolf]

Originally Posted by Vanguard3000

I wasn't reporting it as a bug, just wondering if it was something I could adjust, but it makes sense that it would be the correct behaviour for condensing whitespace. I reinstalled 1.7 to check and it works like this as well, so I must have misremembered it as being a new behaviour.

Anyway, thanks to you both for clarification!

You could have a look at the code and see if you can find where it does this and fix it and give the fix to be added.

[KevinH]

Easier said than done if you are not good with C++ and as I said, it is not a bug, so no "fixes" would be accepted.

Originally Posted by JSWolf

You could have a look at the code and see if you can find where it does this and fix it and give the fix to be added.

[Vanguard3000]

It's been a while since I've used C++; I probably could figure out how to add an exception for non-wrapping tags, but it makes sens to me now that the logic remain consistent. I'll probably just stick with a F&R after prettifying.

Thanks, everyone!

[Binchen]

As far as i remeber this was introduced several versions ago to capture the probelm in the ncx files.

<h1>This is<br />a Heading</h1>

Outcome in ncx: This isa Heading

<h1>This is<br /> a Heading</h1>

Outcome in ncx: This is a Heading

It just saves you time not in the need to add blanks if your headings contains <br />-