Template: unexpected result with gpm

[ownedbycats]

I was modifying one of my templates and although it's valid I got a result I did not expect.

program:
k = field('#kobocoll');
if check_yes_no('#onkobo', 0, 1, 0) then 'sync.png' 
	else if check_yes_no('#onkobo', 0, 0, 1) then
		if list_contains(k, ',', '^Kobo Store$', '1', '') then 'drm-locked.png' fi;
		if list_contains(k, ',', '^Send to Device$', '1', '') then 'sync.png'			
	else 'reader.png'
        fi
    fi
fi

For a book with #onkobo:yes and #kobocoll:"=Kobo Store" I expected to get drm-locked.png.

Instead I got reader.png

I put it in template tester and got the same result so it's not something else accidentally overriding the icon.

I tried removing the ^ and $ in case it was a matching issue but that did not fix it.

What mistake did I make?

[chaley]

The problem is that the ifs, thens, and elses don't connect the way you want. In particular you need to be careful about the difference between "else if" and "elif". The first one, "else if", introduces a new statement block that requires more indented 'fi's that match the correct 'if'. The second, "elif", matches the nearest "if" statement, making placement of 'fi's easier (for me at least).

Another problem is that an "else" clause attaches to the nearest "if". Because of that, your template will return 'reader.png' if k does not contain '^Send to Device$' even if it contains '^Kobo Store$'.

Here is my guess for what you want:

program:
k = field('#kobocoll');
if check_yes_no('#onkobo', 0, 1, 0) then
	'sync.png' 
elif check_yes_no('#onkobo', 0, 0, 1) then
	if list_contains(k, ',', '^Kobo Store$', '1', '') then
		'drm-locked.png'
	elif list_contains(k, ',', '^Send to Device$', '1', '') then
		'sync.png'			
	else
		'reader.png'
	fi
fi

I don't have the columns or values so I can't test it.

Question: is #kobocoll tags-like? If not then you can use

if k == 'Kobo Store' then

instead of list_contains()

[ownedbycats]

The code you gave worked

#kobocoll is taglike so I'll try that other one too

[chaley]

Originally Posted by ownedbycats

#kobocoll is taglike so I'll try that other one too

If #kobocoll is tags-like then '==' won't do anything good if there is more than one value in the list.

The 'in' comparison operator will work on tags-like columns as long as the searched value cannot appear more than once. For example, consider the expression

if 'history' in tags then

It will match 'history', 'military history', 'ancient history' etc.

The 'in' operator is faster than list_contains(), so it is worth using as long as there aren't multiple super-strings of the search expression.

[ownedbycats]

The values in my template don't really have any overlap so I will try that

Nice cat in your avatar

[chaley]

Originally Posted by ownedbycats

Nice cat in your avatar

She is a very strange cat.

We "rescued" her at 6 weeks old. She was feral and she still exhibits a lot of feral behavior. For example, if I approach her then she will bare her teeth and hiss, which is what she is doing in the photo. She is deadly serious; I have the bite and claw scars to prove it. I now use a pair of arm-length leather welders gloves when I need to catch her to take her to the vet.

However, if I am sitting minding my own business then she often approaches me to climb in my lap, purr softly (she has almost no voice), and "nose" my arm. At this point I can pick her up, rub her belly, and do other indignities. However, the rule is I can't directly look at her face. She gets very nervous when that happens.