Forma Lost Wikipedia access

[mzel]

In the last couple of weeks Wikipedia lookup from Nickel stopped working for me. I installed the firmware update, firmware patches, and the new version of NickelMenu. Google search still works.
Is this just me?

[RobertJSawyer]

It's not just you. Me, too. Clara HD.

[PeterT]

I've the same issue. The only mod I have is NickelMenu. When I get home it's reinstall time to see if that makes a difference

[RobertJSawyer]

I have Nickel Menu installed, too, although have nothing using the new selection feature. Still, I wonder if it is the culprit.

[Elektron]

Not here, Wikipedia works on my Ah2o2.

[NiMa]

Confirmed working here also in Canada
Libra H2O

[PeterT]

Sure enough. Uninstalled NickelMenu and wikipedia works

[Elektron]

I have NM tho...

[geek1011]

I apologize for not catching this bug before the v0.5.0 release. I will update my release process to include tests for built-in firmware features related to functions hooked by NickelMenu to prevent this from happening in the future.

I'll fix it later today or tomorrow.

Just in case I can't reproduce it: can someone send me a log with both a normal Wikipedia lookup and a NM selection menu item. Also tell me which language you are using and which language the book is in.

[NiMa]

Originally Posted by geek1011

I apologize for not catching this bug before the v0.5.0 release. I will update my release process to include tests for built-in firmware features related to functions hooked by NickelMenu to prevent this from happening in the future.

I'll fix it later today or tomorrow.

Just in case I can't reproduce it: can someone send me a log with both a normal Wikipedia lookup and a NM selection menu item. Also tell me which language you are using and which language the book is in.

Wikipedia lookup worked fine on my Libra, even though I have NickelMenu + KFMon + Plato + KOReader installed also.
but maybe it worked because the version was older. I think it dates back to the beginning of October, I haven't updated it yet.

[geek1011]

I found the issue:

"https://word.m.wikipedia.org/wiki/Special:Search?search=en" => "Host word.m.wikipedia.org not found"

I mixed up the function parameter order while I did the final refactor...

extern "C" __attribute__((visibility("default"))) void _nm_menu_hook4(WebSearchMixinBase *_this, QString const& selection, QString const& locale) { 
     NM_LOG("hook4: %p %s %s", _this, qPrintable(selection), qPrintable(locale)); 
  
     nm_menu_item_t *it = _nm_menu_hook4_item(NULL); 
     if (!it) { 
         NM_LOG("No current menu item, continuing with default wikipedia search."); 
         WebSearchMixinBase_doWikipediaSearch(_this, locale, selection); 
         return; 
     }

I've released the fix in v0.5.1.

Originally Posted by geek1011

NickelMenu v0.5.1

This release fixes a regression introduced in v0.5.0 which caused the built-in Wikipedia search to fail.

See the release on GitHub for more details.

[mzel]

worked for me in 0.5.1. Thanks a lot, Patrick!