[BUG] Incorrect Case with the test field

un_pogaz · 12-07-2020, 02:21 PM

I discover a bug in the "Search and Replace" module:
When the "Character match" mode is selected, the Case is not correctly applied to the test result field (based on s_r_do_regexp() )

I'm not too sure what to do to submit the fix, so there you go:

in the s_r_paint_results()
source code

Code:

self.test_result.setText(self.s_r_obj.sub(self.s_r_func,
                         unicode_type(self.test_text.text())))

new code

Code:

t = self.s_r_obj.sub(self.s_r_func, unicode_type(self.test_text.text()))
if self.search_mode.currentIndex() == 0:
    rfunc = self.s_r_functions[unicode_type(self.replace_func.currentText())]
    t = rfunc(t)
self.test_result.setText(t)

https://github.com/un-pogaz/calibre/...ca05d82ef62a3c

kovidgoyal · 12-07-2020, 11:54 PM

https://github.com/kovidgoyal/calibr...ca5f7ae1acdec6

12-07-2020, 02:21 PM	#1
un_pogaz Chalut o/ Posts: 486 Karma: 678910 Join Date: Dec 2017 Device: Kobo	[BUG] Incorrect Case with the test field I discover a bug in the "Search and Replace" module: When the "Character match" mode is selected, the Case is not correctly applied to the test result field (based on s_r_do_regexp() ) I'm not too sure what to do to submit the fix, so there you go: in the s_r_paint_results() source code Code: self.test_result.setText(self.s_r_obj.sub(self.s_r_func, unicode_type(self.test_text.text()))) new code Code: t = self.s_r_obj.sub(self.s_r_func, unicode_type(self.test_text.text())) if self.search_mode.currentIndex() == 0: rfunc = self.s_r_functions[unicode_type(self.replace_func.currentText())] t = rfunc(t) self.test_result.setText(t) https://github.com/un-pogaz/calibre/...ca05d82ef62a3c Last edited by un_pogaz; 12-07-2020 at 02:27 PM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Custom series field bug (?)	Nitro	Calibre Companion	2	01-12-2016 10:40 AM
2.x UI bug: How to dismiss dropdown menu in Tags field?	MelBr	Calibre	10	10-19-2014 05:18 PM
Please, test if your Paperwhite has this bug	Antoinekamel	Amazon Kindle	6	10-20-2012 08:21 PM
[Bug?] Field(s) in prefix/suffix	Backi	Library Management	5	03-13-2012 07:22 AM

12-07-2020, 11:54 PM	#2
kovidgoyal creator of calibre Posts: 45,610 Karma: 28549044 Join Date: Oct 2006 Location: Mumbai, India Device: Various	https://github.com/kovidgoyal/calibr...ca5f7ae1acdec6

Advert