Ebook viewer text search bug

[Alsweider]

Since the latest update, I have following bug in the ebook viewer: If I have set the page layout to continuous mode and use the text search in an epub document (ctrl+f, enter text string, press return key):

calibre, version 4.14.0
FEHLER: Error in message handler: RangeError: Maximum call stack size exceeded

Traceback (most recent call last):
    at ensure_selection_visible (userscript:viewer.js:21995:17)
    at ensure_selection_visible (userscript:viewer.js:21995:17)
    at ensure_selection_visible (userscript:viewer.js:21995:17)
    at ensure_selection_visible (userscript:viewer.js:21995:17)
    at ensure_selection_visible (userscript:viewer.js:21995:17)
    at ensure_selection_visible (userscript:viewer.js:21995:17)
    at ensure_selection_visible (userscript:viewer.js:21995:17)
    at ensure_selection_visible (userscript:viewer.js:21995:17)
    at ensure_selection_visible (userscript:viewer.js:21994:17)
    at current_layout_mode (userscript:viewer.js:12784:37)
RangeError: Maximum call stack size exceeded

[kovidgoyal]

https://bugs.launchpad.net/calibre/+bug/1874877

[icallaci]

Thanks for fixing this. I am noticing a different problem in Flow Mode that I don't remember happening before, so I thought I'd mention it: In my CSS, I always use img {max-height: 100%; max-width: 100%}, but large images now spread across more than one screen. Paged Mode doesn't show this problem. I can't remember if this is new behavior or if Flow Mode has always done this?

[kovidgoyal]

Use 100vh and 100vw

[icallaci]

I assume you mean in the CSS. I guess I can do a bulk update, but I've got a gazillion epubs with max-height: 100% and max-width: 100%. Does this mean that percentages are deprecated and won't work on anything anymore? I really don't look forward to updating ~2,000 epubs.

Originally Posted by kovidgoyal

Use 100vh and 100vw

[Brett Merkey]

Does this mean that percentages are deprecated and won't work on anything anymore?

Percentages are fine but are calculated based on tag parent size. The vh and vw units are calculated based on the device view box size. Usually a subtle difference but sometimes important.

I can do a bulk update, but I've got a gazillion epubs

First, test to see if the unit change solves the problem you complained of — and then figure out the next step.

On my Windows 10 test machine, I found that the unit change did not solve the problem. This involved chapter heading images placed thru the CSS file. The images bled into the next page if the Calibre viewer was not a certain width. Weird effect. If your images were placed more conventionally, Kovid's suggestion might work for you.

[icallaci]

Thanks for the info. It's helpful. I've got all kinds of different images (full page, chapter headings, inline, etc.). Oh, well, I've got nothing else to do during the lockdown, so I guess I'll take a look. If my reader's software can deal with percentages (which it has in the past), maybe I'll just use Calibre's Paged Mode. I'm just worried that percentages will be handled differently for all devices from now on, which would force me to edit forty billion CSS files. Ugh, ugh, ugh. Thanks again for the info.

Originally Posted by Brett Merkey

Percentages are fine but are calculated based on tag parent size. The vh and vw units are calculated based on the device view box size. Usually a subtle difference but sometimes important.


First, test to see if the unit change solves the problem you complained of — and then figure out the next step.

On my own Windows 10 test machine, I found that the unit change did not solve the problem. This involved chapter heading images placed thru the CSS file. If your images were placed more conventionally, Kovid's suggestion might work for you.