Register Guidelines E-Books Today's Posts Search

Go Back   MobileRead Forums > E-Book Software > Calibre Companion

Notices

Reply
 
Thread Tools Search this Thread
Old 11-12-2015, 05:17 AM   #1
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 12,443
Karma: 8012886
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
Community question: should searches always be reapplied?

A question in a different thread got me thinking about how CC handles searches when CC is closed. Usually CC remembers the search and re-applies it automatically. However, in some cases related to low memory, CC will forget the search. I can fix this, making CC remember the search in all cases. The fix would have close to zero impact on performance.

The question: is making this change the correct thing to do? It would remove a case where CC behaves differently. On the other hand, it changes CC's behavior.

I don't want to make it optional.
chaley is offline   Reply With Quote
Old 11-12-2015, 08:43 AM   #2
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 12,443
Karma: 8012886
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
Another side effect of the change: currently a search that finds no books resets any grouping then shows an empty book list. If I make the change described above then the search will still reset any grouping, but instead of showing an empty book list it will show a message that it found no books then display all the books on the device.
chaley is offline   Reply With Quote
Advert
Old 11-20-2015, 10:18 AM   #3
kaufman
Calibre Companion Fanatic
kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.
 
kaufman's Avatar
 
Posts: 873
Karma: 1088610
Join Date: Nov 2006
Device: Galaxy Note 4, Kindle Voyage
I think it would be a correct change to make in that its the correct behavior and the change in CC's current behavior is that same sort of change you make whenever you fix a bug.

As far as the second post goes, if there is a way to suppress the "no books found" popup, I would do that. Its one thing to show an old search, because people will understand that they are seeing an old search. If the old search had no results and shows all books, you are giving them information with no context, since the old search is gone at that point.
kaufman is offline   Reply With Quote
Old 11-20-2015, 10:35 AM   #4
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 12,443
Karma: 8012886
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
Quote:
Originally Posted by kaufman View Post
As far as the second post goes, if there is a way to suppress the "no books found" popup, I would do that. Its one thing to show an old search, because people will understand that they are seeing an old search. If the old search had no results and shows all books, you are giving them information with no context, since the old search is gone at that point.
The problem is a side effect of the first change. Before the change, CC showed no books in the book list and some text in the search box saying no books were found. It was very clear to the user what happened. Now, a search that finds nothing acts like no search was done (and this is really hard to change) and there is nothing showing in the search box. Without the popup (what android calls a "toast") the user has no way of knowing that the search was attempted, accidentally cancelled, or if CC is simply broken. I don't think that is acceptable.

The search text is left in the search box so the user can edit it and try again. The text stays there even if the search is explicitly cancelled.

One advantage of using a toast is that the user can ignore it. The UI is still fully active. You don't need to hit OK or something like that to proceed.

Last edited by chaley; 11-20-2015 at 11:04 AM.
chaley is offline   Reply With Quote
Old 11-20-2015, 10:48 AM   #5
kaufman
Calibre Companion Fanatic
kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.kaufman ought to be getting tired of karma fortunes by now.
 
kaufman's Avatar
 
Posts: 873
Karma: 1088610
Join Date: Nov 2006
Device: Galaxy Note 4, Kindle Voyage
I didn't realize that you meant a toast. I thought it was a popup that had to be dismissed.

I agree with you.
kaufman is offline   Reply With Quote
Advert
Reply


Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Question for the community: what to display if "Show empties" if unchecked chaley Calibre Companion 4 10-07-2015 10:39 AM
Question for the prerelease community chaley Calibre Companion 23 09-10-2014 03:17 AM
Saved searches question danwdoo Library Management 9 01-26-2011 01:23 AM
Hello and Question For The E-Books Community PatronQuo Introduce Yourself 8 09-17-2010 12:13 AM
Would it be possible to do three-letter searches? Andanzas Feedback 8 07-10-2007 09:50 PM


All times are GMT -4. The time now is 09:44 AM.


MobileRead.com is a privately owned, operated and funded community.