CC prerelease V3.4.1c has been published

[chaley]

CC prerelease 3.4.1a/3.4.1b/3.4.1c has been published and will be available soon. This release contains the following new features and changes over CC V3.4.1:

• Remove the newly-added goto FAQ menu item. Instead, add a FAQ button to the "failed to connect" dialogs.
• Change text in settings to warn users about CC doing a slow DB upgrade when grouped on lookup names or read info lookup names are changed.
• Add "sorted by" information to the top of the grouping drawer.
• Allow user to turn on WiFi from within CC. Requires a new permission: change WiFi state.
• [3.4.1b]Fix regression in sending books from calibre
• [3.4.1c]Fix failure-to-connect regression for devices running pre-KitKat Android releases
• [BUG FIX]Do not allow connection to calibre during a DB upgrade. Prevents possible corruption of metadata.
• [BUG FIX]Do not reset the book list to the top if read info changes.
• [BUG FIX]Make restore settings do a DB upgrade if necessary.
• [BUG FIX]Fix problems with syncing read information across multiple libraries.
• [BUG FIX]Fix "Send book to app".
• [BUG FIX]Fix incorrect month in auto-generated backup file name.
• [BUG FIX]Show a better error message when device runs out of space while writing book files.

This prerelease was intended to be a minimal change release to correct the problems with read sync and multiple libraries and a few other small bugs, but events conspired against that. I found several problems where because of what I think are Android bugs, setting a preference in one place was not reflected in another unless the preference screen was closed. The problem was particularly acute concerning changing what is shown in the grouping drawer and then changing autosorts. In addition, Android memory management was causing CC to crash in some circumstances. In addition, detecting out-of-space was more complicated than it should have been. Fixing these problems required changing some basic CC code. Finally, of course I have no self control so I added new features, but fortunately they are close to risk free.

What I ask of testers is simply to use CC, and in particular visit the various settings screens. Thank you all!

My hope is to release this version to production this weekend. We will see.

This release has no DB upgrade.

[kaufman]

Originally Posted by chaley

Add "sorted by" information to the top of the grouping drawer.

Three things about this:

1) Love it. This is a great addition, because now the grouping drawer shows exactly what will be shown when the drawer is closed. Excellent idea.

2) Just a personal opinion, by I think it would look better as

XXX books sorted by SortType (direction)

Does anyone else agree/disagree? If its just me, I will shut up, but I think the parenthesis make the sort type stand out more.

3) Playing with this, I realized that custom sorts only go in one direction. Selecting them again does nothing. That makes sense, but it hadn't occurred to me.

[jackie_w]

Sorry to be a party-pooper but I've just installed CCv3.4.1a on my Note3 phone (android 4.3) and there's something badly amiss. I tried to send a new book via Wireless Device to my normal books directory on external SD card. This is the last section of the calibre debug log plus I've sent the CC debug log via email.

Spoiler:

SMART_DEV (1707.08:  1.201) set_progress_reporter
Job: 18 Send metadata to device started
SMART_DEV (1707.17:  0.000) sync_booklists collection attributes [u'tag']
DEBUG: 1600.1 Starting get_collections: on_connect
DEBUG: 1600.1 Renaming rules: {}
DEBUG: 1600.1 Formatting template: {value}{category:| (|)}
DEBUG: 1600.1 Sorting rules: [(['*'], '#coll505sort')]
SMART_DEV (1707.41:  0.063) _call_client SEND_BOOKLISTS wfr False
SMART_DEV (1707.44:  0.000) card_prefix
SMART_DEV (1707.47:  0.000) free_space
SMART_DEV (1707.49:  0.000) _call_client FREE_SPACE wfr True
DeviceJob: 18 Send metadata to device done, calling callback
DeviceJob: 18 Send metadata to device callback returned
SMART_DEV (1707.85:  0.328) _call_client NOOP wfr True
Job: 18 Send metadata to device finished
No details available.
SMART_DEV (1710.12:  2.246) _call_client NOOP wfr True
SMART_DEV (1712.53:  2.372) _call_client NOOP wfr True
SMART_DEV (1714.88:  2.324) _call_client NOOP wfr True
SMART_DEV (1717.35:  2.435) _call_client NOOP wfr True
SMART_DEV (1719.80:  2.402) _call_client NOOP wfr True
SMART_DEV (1730.20: 10.374) _call_client NOOP wfr True
SMART_DEV (1740.64: 10.406) _call_client NOOP wfr True
SMART_DEV (1751.09: 10.421) _call_client NOOP wfr True
SMART_DEV (1761.54: 10.421) _call_client NOOP wfr True
SMART_DEV (1771.98: 10.405) _call_client NOOP wfr True
SMART_DEV (1782.32: 10.296) _call_client NOOP wfr True
SMART_DEV (1782.71:  0.359) set_progress_reporter
Job: 19 Upload 1 books to device:Black Water started
SMART_DEV (1782.77:  0.000) set_plugboards
Device using plugboard epub SMART_DEVICE_APP [[u'{author_sort}', u'authors']]
Setting metadata in: Black Water at: C:\Users\JackieS\AppData\Local\Temp\calibre_4pzw2u\zdlpkhcaltmpfmt.epub
SMART_DEV (1782.91:  0.109) upload_books
SMART_DEV (1782.95:  0.000) upload_books lpath Parker, T Jefferson - Merci Rayborn 03 - Black Water.epub
SMART_DEV (1782.98:  0.000) _json_encode series sort =  Merci Rayborn
SMART_DEV (1783.68:  0.670) _send_byte_string socket error [Errno 10054] An existing connection was forcibly closed by the remote host 10054
SMART_DEV (1783.71:  0.000) _write_metadata_cache
SMART_DEV (1784.07:  0.327) _write_metadata_cache wrote 125 entries, purged 0 entries
DeviceJob: 19 Upload 1 books to device:Black Water done, calling callback
[Errno 10054] An existing connection was forcibly closed by the remote host

Traceback (most recent call last):
  File "site-packages\calibre\gui2\device.py", line 86, in run
  File "site-packages\calibre\gui2\device.py", line 571, in _upload_books
  File "site-packages\calibre\devices\smart_device_app\driver.py", line 50, in _synchronizer
  File "site-packages\calibre\devices\smart_device_app\driver.py", line 1405, in upload_books
  File "site-packages\calibre\devices\smart_device_app\driver.py", line 680, in _put_file
  File "site-packages\calibre\devices\smart_device_app\driver.py", line 571, in _send_byte_string
error: [Errno 10054] An existing connection was forcibly closed by the remote host

DeviceJob: 19 Upload 1 books to device:Black Water callback returned
SMART_DEV (1784.30:  0.187) post_yank_cleanup
DEBUG: 1787.2 self.plugin_device_connection_changed.__class__:  <type 'PyQt5.QtCore.pyqtBoundSignal'>
DEBUG: 1787.2 Methods for self.plugin_device_connection_changed:  ['__call__', '__class__', '__delattr__', '__doc__', '__format__', '__getattribute__', '__getitem__', '__hash__', '__init__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', 'connect', 'disconnect', 'emit', 'signal']
DEBUG: 1787.2 KoboUtilites:_on_device_connection_changed - Device disconnected
DEBUG: 1787.2 No Kobo Touch, Glo or Mini appears to be connected
DEBUG: 1787.2 rebuild_menus - self.supports_ratings=False
Job: 19 Upload 1 books to device:Black Water finished
[Errno 10054] An existing connection was forcibly closed by the remote host
	
	Traceback (most recent call last):
	  File "site-packages\calibre\gui2\device.py", line 86, in run
	  File "site-packages\calibre\gui2\device.py", line 571, in _upload_books
	  File "site-packages\calibre\devices\smart_device_app\driver.py", line 50, in _synchronizer
	  File "site-packages\calibre\devices\smart_device_app\driver.py", line 1405, in upload_books
	  File "site-packages\calibre\devices\smart_device_app\driver.py", line 680, in _put_file
	  File "site-packages\calibre\devices\smart_device_app\driver.py", line 571, in _send_byte_string
	error: [Errno 10054] An existing connection was forcibly closed by the remote host

The error pop-up I got in CC was

Spoiler:

There was a problem writing to device storage. That usually means the device is out of space.
Free space 22,004,676KB

I double-checked, there's loads of free space on the Note3. There was a tiny (2KB) corrupt file transferred but it certainly wasn't in epub format.

I haven't updated CC on my tablet (Galaxy TabPRO android 4.4.2) yet so I tried to transfer the same book (to Calibre_Companion default dir) using CCv3.4.1 - no problem at all.

I then repeated the exercise with a completely different book on both devices. The results were the same. No problem with CCv3.4.1 on tablet, big problem with CCv3.4.1a on Note3 phone.

[kaufman]

I'm getting the same error on my 4.4.2 Note3. Lots of free space and a failure to copy a book over.

[chaley]

The code to test running out of space got left in the release.



New release shortly ...

[chaley]

V3.4.1b uploaded.

[chaley]

Originally Posted by kaufman

2) Just a personal opinion, by I think it would look better as

XXX books sorted by SortType (direction)

Does anyone else agree/disagree? If its just me, I will shut up, but I think the parenthesis make the sort type stand out more.

For me, 6 of one, 1/2 dozen of the other.

3) Playing with this, I realized that custom sorts only go in one direction. Selecting them again does nothing. That makes sense, but it hadn't occurred to me.

The problem comes from the direction being explicitly provided in the sort specification. I considered inverting the internally-provided directions, but that got complicated both conceptually and in code so I put it aside as a bad idea.

[a_daley]

Just Loaded 3.4.1b and getting an error communicating as a wire less connection:

calibre, version 1.47.0
ERROR: Error: Error communicating with device

Device responded with incorrect information

Traceback (most recent call last):
File "site-packages\calibre\gui2\device.py", line 86, in run
File "site-packages\calibre\gui2\device.py", line 467, in _get_device_information
File "site-packages\calibre\devices\smart_device_app\driver.p y", line 50, in _synchronizer
File "site-packages\calibre\devices\smart_device_app\driver.p y", line 1207, in free_space
File "site-packages\calibre\devices\smart_device_app\driver.p y", line 50, in _synchronizer
File "site-packages\calibre\devices\smart_device_app\driver.p y", line 609, in _call_client
File "site-packages\calibre\devices\smart_device_app\driver.p y", line 651, in _receive_from_client
ControlError: Device responded with incorrect information

Have tried changing port numbers with no joy

Yet when using it as a server device communicates perfectly???

[a_daley]

I forgot to add it happens both with manually specifing IP addresses / Ports and letting calibre companion / calibre choose a port manually...

[chaley]

Originally Posted by a_daley

Just Loaded 3.4.1b and getting an error communicating as a wire less connection:

calibre, version 1.47.0
ERROR: Error: Error communicating with device

Device responded with incorrect information

Traceback (most recent call last):
File "site-packages\calibre\gui2\device.py", line 86, in run
File "site-packages\calibre\gui2\device.py", line 467, in _get_device_information
File "site-packages\calibre\devices\smart_device_app\driver.p y", line 50, in _synchronizer
File "site-packages\calibre\devices\smart_device_app\driver.p y", line 1207, in free_space
File "site-packages\calibre\devices\smart_device_app\driver.p y", line 50, in _synchronizer
File "site-packages\calibre\devices\smart_device_app\driver.p y", line 609, in _call_client
File "site-packages\calibre\devices\smart_device_app\driver.p y", line 651, in _receive_from_client
ControlError: Device responded with incorrect information

Have tried changing port numbers with no joy

Yet when using it as a server device communicates perfectly???

Could you send me a CC debug log? Go to CC's settings, scroll to the bottom, and choose Send a debug log to MultiPie. Please erase the multipie.co.uk To: address. There is no reason to clog my son's mailbox. Thanks.

[chaley]

@a_daley: never mind the debug log. I found the problem. My Android development environment suggested that I change some code, but it didn't tell me that doing so would break CC on Android 4.2 and earlier devices. Unfortunately my test devices run 4.3 and 4.4, so I didn't see it. Sigh.

I undid the changes and pushed V3.4.1c.

[chaley]

@a_daley: got the debug log and it confirms the problem. V3.4.1c will fix it.

[a_daley]

Thanks for the super fast response

It really is appreciated...

[kaufman]

Originally Posted by chaley

For me, 6 of one, 1/2 dozen of the other.

Don't worry about it. No one else seems to care, and I am getting used to it.

Originally Posted by chaley

The problem comes from the direction being explicitly provided in the sort specification. I considered inverting the internally-provided directions, but that got complicated both conceptually and in code so I put it aside as a bad idea.

Don't misunderstand me. I think you have the correct behavior, it just hadn't occurred to me.

[kaufman]

I confirm that I can send books to the device again with V3.4.1c.