edit tweak preferences BUG v1.23 64 bit

[cybmole]

will someone please test & confrim this:

My reproducible test sequence:
1. close calibre
2 open calibre ( so we have a clean start point)
navigate: preferences - tweaks.. scroll to save original files...
click on restore defaults then click apply ( the 2 bottom-of-screen boxes)
no reaction from program.
now go to top left & click apply
I then get :
Error: Invalid Tweaks
calibre, version 1.23.0
ERROR: Invalid tweaks: The tweaks you entered are invalid, try resetting the tweaks to default and changing them one by one until you find the invalid setting.

Traceback (most recent call last):
File "site-packages\calibre\gui2\preferences\tweaks.py", line 421, in commit
File "<string>", line 623
Qt = <class 'PyQt4.QtCore.Qt'>
^
SyntaxError: invalid syntax

NB I did not enter any data, I simply clicked on restore defaults.

[BetterRed]

@cybmole - OK here, after clicking the top line apply I was offered the restart as per normal

But if I don't do the bottom Restore, then the top Restore does not return Save original files... to default values - False, False - they remain as - True, True. But that doesn't seem to be the case with other Tweaks. So there appears to be something not quite right with respect to that specific tweak - which seems odd.

Suggestion to developers - rename the item buttons (the ones at the bottom) to Reset Tweak and Set Tweak. This is an instance where using different words to convey the same idea, but at a different level, within the same context has merit. Doing otherwise borders on being diabolically evil

BR

[cybmole]

thanks for checking, I am confused by having 2 "apply" buttons
I think the defaults are true & true, actually, but I want to set true & false.

so is there a way to change polish to False & get that to stick ?

retesting, and this is after an overnight PC power off + reboot...
the top apply is greyed out until the bottom apply is used.

the top "apply" is greyed out until th bottom "apply" is used.
after 2nd apply I still get:
Traceback (most recent call last):
File "site-packages\calibre\gui2\preferences\tweaks.py", line 421, in commit
File "<string>", line 623
Qt = <class 'PyQt4.QtCore.Qt'>
^
SyntaxError: invalid syntax

[kovidgoyal]

You've got some invalid tweaks in your config. Click the restore defaults at the top, then click apply at the top, then restart calibre and you should be able to make the changes.

[cybmole]

Originally Posted by kovidgoyal

You've got some invalid tweaks in your config. Click the restore defaults at the top, then click apply at the top, then restart calibre and you should be able to make the changes.

no joy:
preferences, tweaks- restore defaults ( at top) - apply (at top);
similar error, but I see it's pointing to a different line of code now.
calibre, version 1.23.0
ERROR: Invalid tweaks: The tweaks you entered are invalid, try resetting the tweaks to default and changing them one by one until you find the invalid setting.

Traceback (most recent call last):
File "site-packages\calibre\gui2\preferences\tweaks.py", line 421, in commit
File "<string>", line 623
Qt = <class 'PyQt4.QtCore.Qt'>
^
SyntaxError: invalid syntax

strange thing is, except for the save original format tweak, I don't recall ever going to / altering this section

[kovidgoyal]

Go to preferences->miscellaneous->open configuration directory

then quit calibre

then delete tweaks.py

[cybmole]

ok thanks- that seems to have fixed it - do you want to see the old problematic tweaks.py from my backup folder .- I attach a zip of it

now I can play the memory game of "what other tweaks might I have set once upon a time - that now need resetting "

[kovidgoyal]

Your problem was caused by the open with plugin. It inserts some invalid code into the tweaks file to customize its menus.

[cybmole]

thanks for explaining that. I did adjust that plug in recently to amend my hotkey settings. I trust the plug-in author is aware of the issue.

PS I see that my open_with hot keys all still work though - they have not been reset by the reset defaults process.