[Plugin] ImgShrinker (ImageMagick-Wrapper)

[KevinH]

The official gui for Sigil under Qt6 is not PyQt6 but instead Qt's official PySide6. DiapDealer has created a plugin_utils.py module to make supporting PyQt5 and PySide6 easily done. He also has a plugib_utils_light.py module for use with Sigil 2.0.0 or later versions of Sigil.

Integrating one of those two modules into this plugin would definitely be useful to others.

[LostOnTheLine]

Originally Posted by KevinH

The official gui for Sigil under Qt6 is not PyQt6 but instead Qt's official PySide6. DiapDealer has created a plugin_utils.py module to make supporting PyQt5 and PySide6 easily done. He also has a plugib_utils_light.py module for use with Sigil 2.0.0 or later versions of Sigil.

Integrating one of those two modules into this plugin would definitely be useful to others.

Cool. Thanks for that. Is there one that would be better than the other? I'll edit to incorporate whichever is best. As I said, I'm not a coder, so I'll be fiddling around to get it to work so any information on what needs to be imported to start with would be a big help.

I'm currently using Sigil Version: 2.5.2 with Loaded Qt: 6.8.2 & the plugin seems to work without issue on my end as is, but I'll happily update it to a newer version so that it will work better for others as well as myself & to prevent interruptions when there are future changes.

[KevinH]

Since Sigil moved to Qt6, we only support PySide6 on Windows and Mac, and now for Linux AppImage. The plugin_util.py file created by DiapDealer also supports PyQt5 for those Linux users stuck with only Qt5.

So if you want your plugin to work well on Windows, Mac, and the Linux AppImage using the embedded Python use PySide6 not PyQt6.

[Mark Nord]

Originally Posted by LostOnTheLine

....
I'm currently using Sigil Version: 2.5.2 with Loaded Qt: 6.8.2 & the plugin seems to work without issue on my end as is, but I'll happily update it to a newer version so that it will work better for others as well as myself & to prevent interruptions when there are future changes.

Same here, we've already set the path to the imageMagick executable and

#------------------------------------
# display ImageMagick file selection dialog
#------------------------------------
def GetFileName():
    ''' displays the ImageMagick file selection dialog '''
    # requires Sigil 0.9.8 or higher or PyQt6/PySide6
    home = expanduser('~')
    from PySide6.QtWidgets import QApplication, QWidget, QFileDialog
    app = QApplication(sys.argv)
    w = QWidget()
    file_path, filter = QFileDialog.getOpenFileName(w,'Select ImageMagick exe-file', home, 'ImageMagick-Executable (magick.exe)')
   
    return file_path

is, as I read the code, the only place relying on the GUI. And this part is, after the initial run, never called again.

So the fix shall go to this function, replacing the import

from PySide6.QtWidgets import QApplication, QWidget, QFileDialog

with some from the helper modules. - But still not sure how to do it.

To test any new code we will have to remove the line with

"magick_exe_path"

from the ImgShrinker.json configuration-file

Just my 2 cents

[Mark Nord]

Just updated Post #1 with version 0.0.4
Many thanks to Doitsu for his help and suggestions.

The GetFileName-Dialog is realized with imports from plugin_utils.py
relevant code:

    #--------------------------------------
    # file selection dialog
    # Code courtesy of Doitsu / KindleGenQt
    #--------------------------------------
    def GetFileName():
        ''' simple file selection dialog box '''
        fpath = None
        if not PluginApplication.instance():
            app = PluginApplication(sys.argv, bk)
        else:
            app = PluginApplication.instance()
        dlg = QtWidgets.QFileDialog()
        .....
        if dlg.exec():
        ....