MobileRead Forums - View Single Post - KoReader 2019.1

Frenzie · 01-10-2019, 12:24 PM

While the automated tests didn't and couldn't catch the MuPDF issue on some systems (like Android) issue, it's unclear to me why they didn't catch this wider issue with DjVu. These two tests open a DjVu file and they don't fail, even though it did in the actual program.

I nuked the borked v2019.1 release files and I'll replace them with v2019.1.1 tonight.

I'll hopefully also find some time to write a test that'll properly fail on v2019.1 to prevent future regressions like this.

01-10-2019, 12:24 PM	#4
Frenzie Wizard Posts: 1,616 Karma: 724945 Join Date: Oct 2014 Location: Antwerp Device: Kobo Aura H2O	While the automated tests didn't and couldn't catch the MuPDF issue on some systems (like Android) issue, it's unclear to me why they didn't catch this wider issue with DjVu. These two tests open a DjVu file and they don't fail, even though it did in the actual program. I nuked the borked v2019.1 release files and I'll replace them with v2019.1.1 tonight. I'll hopefully also find some time to write a test that'll properly fail on v2019.1 to prevent future regressions like this.