MobileRead Forums - View Single Post

refj · 01-11-2016, 04:54 PM

Thanks again tshering.

I've been working on these changes for koreader and noticed a couple of problems with $dontTamperwithFrontlight in KSM. (a) The meaning was inverted: The code changes the value of the frontlight when this variable is set to "true" and (b) it wasn't used everywhere I believe it should.

For this reason I've put together a patch that (a) fixes this and also (b) allows koreader to be aware of and delete "onstart/nickelkoreaderloop.sh" to end the koreader-nickel / nickel-koreader loop. https://gist.github.com/dset0x/a02f4ef0ff1897608e15

(Edit: By the way: why are "trilogy" and "pixie" excluded from this?)

Please let me know if you see any issues with it. It would be great if it could made it to the next KSM release.

01-11-2016, 04:54 PM	#74
refj Junior Member Posts: 5 Karma: 10 Join Date: Dec 2015 Device: Kobo Glo HD	Thanks again tshering. I've been working on these changes for koreader and noticed a couple of problems with $dontTamperwithFrontlight in KSM. (a) The meaning was inverted: The code changes the value of the frontlight when this variable is set to "true" and (b) it wasn't used everywhere I believe it should. For this reason I've put together a patch that (a) fixes this and also (b) allows koreader to be aware of and delete "onstart/nickelkoreaderloop.sh" to end the koreader-nickel / nickel-koreader loop. https://gist.github.com/dset0x/a02f4ef0ff1897608e15 (Edit: By the way: why are "trilogy" and "pixie" excluded from this?) Please let me know if you see any issues with it. It would be great if it could made it to the next KSM release. Last edited by refj; 01-11-2016 at 05:02 PM.