View Single Post
Old 02-06-2020, 02:15 PM   #10
mbrisco
(gtfo/freak)
mbrisco ought to be getting tired of karma fortunes by now.mbrisco ought to be getting tired of karma fortunes by now.mbrisco ought to be getting tired of karma fortunes by now.mbrisco ought to be getting tired of karma fortunes by now.mbrisco ought to be getting tired of karma fortunes by now.mbrisco ought to be getting tired of karma fortunes by now.mbrisco ought to be getting tired of karma fortunes by now.mbrisco ought to be getting tired of karma fortunes by now.mbrisco ought to be getting tired of karma fortunes by now.mbrisco ought to be getting tired of karma fortunes by now.mbrisco ought to be getting tired of karma fortunes by now.
 
Posts: 113
Karma: 2288750
Join Date: Nov 2019
Device: Likebook Alita
Quote:
Originally Posted by Frenzie View Post
That seems to be part of the else path on a swipe. It used to be if north/south/west/east (leaving diagonal) but it looks like north & south have since migrated elsewhere, leaving them to be treated as if they were diagonal.

https://github.com/koreader/koreader/pull/2659

https://github.com/koreader/koreader....lua#L485-L490

Edit: removed in https://github.com/koreader/koreader...a1a13a70fbce6c

Same true here https://github.com/koreader/koreader....lua#L404-L428
Would this be a bug then? Weird though, because even if it treats the north south swipes as diagonal, the diagonal refresh gesture is off. Shouldn’t be refreshing at all, I think
mbrisco is offline   Reply With Quote