View Single Post
Old 05-30-2018, 04:02 PM   #38
JSWolf
Resident Curmudgeon
JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.
 
JSWolf's Avatar
 
Posts: 74,304
Karma: 129333566
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3
Quote:
Originally Posted by Terisa de morgan View Post
Sorry, JSWolf, but I think you're understanding it wrong. You can patch this in the same way that till this moment. What other users are requesting is a wat of not having to modify EVERY SINGLE VERSION OF A PATCH, and instead keep the change in a configuration file you can use in every version (till the patch changes, that is).
Please explain the following from this thread please.

Quote:
Originally Posted by Terisa de morgan View Post
I have a question. There are some patches that, aside of been enabled or no, accept some customization (Custom footer (page number text), for example). How would you handle it here?
Quote:
Originally Posted by geek1011 View Post
I wouldn't. That's currently beyond the scope of kobopatch, because there is no clean way it can be implemented (covering edge cases, validation) and it would make it a bit confusing to use. I also wanted to keep as much logic as possible in the patch files itself to make it easier to maintain (it's currently the same number of lines of code as the original one). More complexity means more bugs and less checks. The way I was considering was a variables section in kobopatch.yaml which is substituted into all patches which match, but I decided against it. Also keep in mind that users may not necessarily know how to use the feature.

If one of you can think of a better way to implement this, I'd be happy to consider it.

Also, what would you think of a print instruction to show a message to the user during patching? This would be useful to inform about dangerous patches or things like that.
To me, that reads like it's not possible to make changes to the patches.
JSWolf is offline   Reply With Quote