Thread: Comments field
View Single Post
Old 04-08-2010, 03:18 PM   #8
Starson17
Wizard
Starson17 can program the VCR without an owner's manual.Starson17 can program the VCR without an owner's manual.Starson17 can program the VCR without an owner's manual.Starson17 can program the VCR without an owner's manual.Starson17 can program the VCR without an owner's manual.Starson17 can program the VCR without an owner's manual.Starson17 can program the VCR without an owner's manual.Starson17 can program the VCR without an owner's manual.Starson17 can program the VCR without an owner's manual.Starson17 can program the VCR without an owner's manual.Starson17 can program the VCR without an owner's manual.
 
Posts: 4,004
Karma: 177841
Join Date: Dec 2009
Device: WinMo: IPAQ; Android: HTC HD2, Archos 7o; Java:Gravity T
Quote:
Originally Posted by chaley View Post
That is indeed what the code does, and it is a bug. I probably broke it, and I will definitely fix it.
I spotted the previous bug in the false searches, and while looking for it, I became somewhat familiar with the search code. Later I encountered the bug that "comments:false" found comments that have the word "false" in them, and I remember I was sort of puzzled as I had vaguely recalled the code and thought that this shouldn't have happened. I realize now you must have changed the code.

Quote:
BTW: not comments:true does work correctly.
Actually, when I suggested that, it was because I remembered the old code had first identified "false" searches, then went on to process non-false searches differently. It's nice to know that it works, but I suspect you will fix the code pretty quickly

Quote:
BTW**2: The regexp comments:~^$ should in theory match an empty comment. However, empty comments are represented as missing text, not text containing no characters, so no regexp (or any other match) is tested. I could make a special case of this pattern, if the general consensus is that it really should work.
When I spotted the new bug in the false search (locates comments with "false" in the text), the first thing I did was try a regexp search. I suppose if you are in the code again, you might as well add that, as I can imagine people doing that search if they know regex, but not about true/false searches.
Starson17 is offline   Reply With Quote