Quote:
Originally Posted by Norbi24
Yes, previously I had 2019.04, it was working fine, but I was not using it as it was not supporting external dictonary apps, as this has been implemented now for 2019.07, I installed july build and since then it is occuring ... I even went back to 2019.06 just to isolate it, and there it is still fine ....
There must have occured something between june and july builds.
As I now am also able to build koreader on my Debian VM, I could checkout particular commits, build and test and thus isolate which commit may have caused this ...
If you or @pazos had any idea, where to start, I could do it next week and let you know
Thanks, Norbert
|
You need to look at specific changes in
https://github.com/koreader/android-...commits/master.
AFAICT there is no suspicious commit but:
https://github.com/koreader/android-...e3de5defec5075 introduces some overhead (screen helper hold a reference to the activity context from onCreate to onDestroy). It shouldn't hurt on a single activity - single instance application but anyways.
https://github.com/koreader/android-...44858b8827e681 migrates to androidX support libraries. It shouldn't add overhead at runtime (it does quite a bit at buildtime)
And the only commit I would find suspicious (but was present in 2019.06 too):
https://github.com/koreader/android-...821fd583907184. It uses a surfaceview to make java aware of the native window and have means to control it. It seems to setup a HW accel renderer even if we don't use it. On the logs you'll see a lot of GL spam on supported devices. Tolinos w FW11 are the ones that spam all those logs. Any modern android phone will spam them too. Legacy ereaders on 4.0.? don't seem to enable a hw accel surface, which is nice because we don't really need it.