please see my comments underlined
Good start.
thx
My feedback:
- Don't focus on how keyboards will be loaded, this is still tbd. Sure. I was only keeping in mind to have easy way open.
- Avoid having business logic in xml files (doMark). there is not bussines logic in XML. File kb.xml is only my keyboard testin utility - it is not part of keyboard. Enyhow I'll keep it in mind.
- Try to avoid target.bla =, preferably define dummy function and expose only public stuff. (check existing prs+ code for examples) I'll try to take a look. I use this target.bla stuff only for keyboard code, it is not pushed into 'user' XML.
- Don't expose vk internals, nobody should be able to directly push something into its arrays. Not sure I know how to avoid this.
- Letters need to be bigger no problem. On the other hand - bigger letter=bigger keyboard
and a bit more squarish (vertical size closer to horizontal). I have in my mind that it could be usefull to have several letters on key. eg SPC for space ect.
- Column indices are missing I know. It is of this visual sugar missing I'm going to improve this anyhow soon.
- tab labels what are tab labes? 'keyborad switchers? might have fixed size, but not the same as letters, switching between them should be by using some key (uhm, say "holding numeric button", tbd)
- A bit more comments in the code would be nice...
it is only proof of concept, not public code. I'll put comments, do not worry
- I'd dream about dynamic column number. (sudoku has code that is resizing/moving stuff around) I'm going to implement resizing in means of vertical size anyway. Not sure what changing number of columns will give us. But why not - TBD
- Would be nice to have colored stripes mildly highlighting rows/columns do not understand
- Keep in mind, that eventually VK group will land in main.xml I'm not sure it could be done. Whole keyboard XML (vkbd.xml) is included using view element
Fine, at least I know it is not complet s..t and could be continued.