06-05-2010, 06:51 AM
|
#1271
|
PRS+ author
Posts: 1,637
Karma: 2446233
Join Date: Dec 2007
Device: Sony PRS-300, 505, 600, 650, 950
|
m-land
Good start.
My feedback: - Don't focus on how keyboards will be loaded, this is still tbd.
- Avoid having business logic in xml files (doMark).
- Try to avoid target.bla =, preferably define dummy function and expose only public stuff. (check existing prs+ code for examples)
- Don't expose vk internals, nobody should be able to directly push something into its arrays.
- Letters need to be bigger and a bit more squarish (vertical size closer to horizontal).
- Column indices are missing
- tab labels might have fixed size, but not the same as letters, switching between them should be by using some key (uhm, say "holding numeric button", tbd)
- A bit more comments in the code would be nice...

- I'd dream about dynamic column number. (sudoku has code that is resizing/moving stuff around)
- Would be nice to have colored stripes mildly highlighting rows/columns
- Keep in mind, that eventually VK group will land in main.xml
Last edited by kartu; 06-05-2010 at 06:56 AM.
|
|
|