View Single Post
Old 07-21-2009, 09:42 AM   #2
rogue_ronin
Banned
rogue_ronin has learned how to read e-booksrogue_ronin has learned how to read e-booksrogue_ronin has learned how to read e-booksrogue_ronin has learned how to read e-booksrogue_ronin has learned how to read e-booksrogue_ronin has learned how to read e-booksrogue_ronin has learned how to read e-books
 
Posts: 475
Karma: 796
Join Date: Sep 2008
Location: Honolulu
Device: Nokia 770 (fbreader)
Hi Alex,

Just took a quick look at it in both Firefox and IE. Noticed some things:

In the head,
Code:
<head>
	<title>War is a Racket</title>
	<meta name="Author" content="Alex Bell afjbell@bigpond.net.au"/>
	<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
	<link rel="stylesheet" type="text/css" href="ebook.css"/>
	<!-- Version 1 of this book 2009-07-20 -->
</head>
Are you the author? I think Smedley is... Maybe you could use a meta value like preparer or proofer or publisher? Also, you might want to move the versioning and the preparation date into meta values, too. Machine readable, donchaknow!

Also, the cover is not showing, and the source doesn't have any code to display it.

Saw this, too:
Code:
			<img src="SmedleyButler.jpg"
			alt="Pachelbel" width="300" height="376"/>
What does "Pachelbel" mean? Maybe you copy/pasted? I think you want a value like "Photograph of Maj.General Smedley D. Butler" or something.

In the CSS I saw this:
Code:
div.photoholder {
    margin: auto;  /* Centres block level elements */
	padding: 0;
	width: 300px; /* For ebooks must be same as image */
		  } /* Manages graphics */
And I wonder if you want to hard-code the width into your photoholder class? If you use the class for another image, and it's not natively 300px, your comment suggests that it might cause issues.

That's just a quick look, hope it helps.

m a r
rogue_ronin is offline   Reply With Quote