View Single Post
Old 07-19-2009, 08:13 AM   #23
rogue_ronin
Banned
rogue_ronin has learned how to read e-booksrogue_ronin has learned how to read e-booksrogue_ronin has learned how to read e-booksrogue_ronin has learned how to read e-booksrogue_ronin has learned how to read e-booksrogue_ronin has learned how to read e-booksrogue_ronin has learned how to read e-books
 
Posts: 475
Karma: 796
Join Date: Sep 2008
Location: Honolulu
Device: Nokia 770 (fbreader)
Quote:
Originally Posted by AlexBell View Post
I really admire the enormous amount of work you have put into this, and it looks good in a browser.

But I hope you don't mind me pointing out that the W3C Markup validation service at http://validator.w3.org/ finds 167 errors in the XHTML, and the W3C CSS validation service at http://jigsaw.w3.org/css-validator/validator finds 2 errors in the CSS.

Many of the errors in the XHTML are minor, like leaving out alt in the markup for an image. But I've learned from bitter experience that even minor errors can come back to bite you.

Regards, Alex
No problem at all, and thanks for the compliment, too!

My subconscious must be as quick as you are (but not my conscious mind, it's a turns like a battleship) -- I was nosing around in my text editor (NOTETAB, HOOAH!) and it has a menu entry to run tidy.exe. Just had to download it, and stick it in the NoteTab directory. So I ran it and found most of those errors, too!

I fixed all the alt tags, and updated the macros to add them. And I found the silly unclosed img tags and fixed those (and their macros.) There were a couple of regex-missed strong tags -- got 'em. Now tidy reports no errors!

What were the CSS errors, can I ask? The zipfile attached here has a new one, so maybe no errors now... and it has some additional table icons. (I may add a basic map of Barsoom, so I added the symbol for the map tables -- plus it makes the tables consistent to all have an icon/button, so I added Tables, too.)

Give this a try, if you have time, and let me know. I have made the covers for the next four books in the series, and I expect I should be able to knock them all out with the same CSS. The next ones could all come very quickly once this is settled in place.

Thanks AlexBell! I definitely appreciate the feedback.

m a r

EDIT: I ran the CSS through the validator -- it's clean now! One text/font mixup, one bad value and three floats that had no width (which I had no idea was necessary.) Thanks for the link!

EDIT 2: I wasn't sure if I had updated the CSS and HTML in this zip, so I switched to a new zip. If you downloaded it (and one person did!) you may want to re-download.
Attached Files
File Type: zip 01_APrincessOfMars.zip (1.18 MB, 293 views)

Last edited by rogue_ronin; 07-20-2009 at 05:48 AM. Reason: Changed zip file. And some weird attachment glitch.
rogue_ronin is offline   Reply With Quote